From: Maxime Devos <maximedevos@telenet.be>
To: Attila Lendvai <attila@lendvai.name>
Cc: 54232-done@debbugs.gnu.org
Subject: bug#54232: [PATCH 1/2] gnu: python-daemon: Use the git repo as source instead of pypi.
Date: Thu, 03 Mar 2022 15:46:15 +0100 [thread overview]
Message-ID: <974683641d47f041c71bb9a9adbeda16b45b0908.camel@telenet.be> (raw)
In-Reply-To: <BtNtdfnf-dcUUWnXeT3q2VMWjIRMeOCp0K1d6ix3L8fukjO-JwU-1cW7FFhSreDvX_R59AUC-kmz3Ax2PZ_SWVW_5ek3V2Okc1hugdZG7iU=@lendvai.name>
[-- Attachment #1: Type: text/plain, Size: 1114 bytes --]
Attila Lendvai schreef op do 03-03-2022 om 14:42 [+0000]:
> > Also, how does this address the test failure? The pypi and git are
> > at
> > the same version. Did upstream adjust the 'release/2.3.0' tag in
> > place
> > or something?
>
> sorry for not being clear enough! sending this patch was essentially
> a mistake: the tests do work fine.
>
> probably i have added the disabling of the test prior to the
> SUBSTITUTE* (that
> is basically a backport of the fix commit in upstream), and when i
> rebased some
> pending changes, then i mistakenly included the now irrelevant
> disabling.
>
> feel free to apply or reject this as you see fit. it's not important
> for me to build from git, even though i also find it better. probably
> the software heritage archives also work better with git.
They do support tarballs to some degree, and disarchive to some degree
compensates for mismatches. I don't know how well this works in
practice.
Anyway, I'm closing for now, but if it is discussed on guix-devel@ with
a positive conclusion, feel free to reopen.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-03-03 14:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 10:58 [bug#54232] [PATCH] gnu: python-daemon: Fix build by temporarily disabling the tests Attila Lendvai
2022-03-03 12:33 ` Maxime Devos
2022-03-03 14:19 ` [bug#54232] [PATCH 1/2] gnu: python-daemon: Use the git repo as source instead of pypi Attila Lendvai
2022-03-03 14:30 ` Maxime Devos
2022-03-03 14:42 ` Attila Lendvai
2022-03-03 14:46 ` Maxime Devos [this message]
2022-03-03 23:48 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=974683641d47f041c71bb9a9adbeda16b45b0908.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=54232-done@debbugs.gnu.org \
--cc=attila@lendvai.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).