unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Attila Lendvai <attila@lendvai.name>, 54232@debbugs.gnu.org
Subject: [bug#54232] [PATCH 1/2] gnu: python-daemon: Use the git repo as source instead of pypi.
Date: Thu, 03 Mar 2022 15:30:56 +0100	[thread overview]
Message-ID: <6897aa67f40268ae9749fb4708486b63ea77bd4a.camel@telenet.be> (raw)
In-Reply-To: <20220303141929.6981-1-attila@lendvai.name>

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

Attila Lendvai schreef op do 03-03-2022 om 15:19 [+0100]:
>      (source
>       (origin
> -       (method url-fetch)
> -       (uri (pypi-uri "python-daemon" version))
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://pagure.io/python-daemon.git")
> +             (commit (string-append "release/" version))))
> +       (file-name (git-file-name name version))
>         (sha256
> -        (base32
> -         "1bxfn2bq56sd4w0nm9mqy8y0905m7fc8vmhnjxlrf49vcbqr7adx"))))
> +        (base32 "1ysynb1m9vsww2nmhcypkk08xwifc3gw5yq10h1a1i11yn27w4y6"))))

I'm not opposed to building things from version control more often
(it makes things like "--with-commit" work more often).  However,
this seems more a change to discuss at guix-devel@.

Also, how does this address the test failure?  The pypi and git are at
the same version. Did upstream adjust the 'release/2.3.0' tag in place
or something?

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  reply	other threads:[~2022-03-03 14:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-03 10:58 [bug#54232] [PATCH] gnu: python-daemon: Fix build by temporarily disabling the tests Attila Lendvai
2022-03-03 12:33 ` Maxime Devos
2022-03-03 14:19 ` [bug#54232] [PATCH 1/2] gnu: python-daemon: Use the git repo as source instead of pypi Attila Lendvai
2022-03-03 14:30   ` Maxime Devos [this message]
2022-03-03 14:42     ` Attila Lendvai
2022-03-03 14:46       ` bug#54232: " Maxime Devos
2022-03-03 23:48         ` [bug#54232] " zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6897aa67f40268ae9749fb4708486b63ea77bd4a.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=54232@debbugs.gnu.org \
    --cc=attila@lendvai.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).