unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#53510] [PATCH] tests: Assert that cyclic graphs can be produced.
@ 2022-01-24 18:15 Liliana Marie Prikler
  2022-02-04 22:11 ` Ludovic Courtès
  0 siblings, 1 reply; 2+ messages in thread
From: Liliana Marie Prikler @ 2022-01-24 18:15 UTC (permalink / raw)
  To: 53510

* tests/graph.scm ("package DAG, oops it was a cycle"): New test.
---
 tests/graph.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/tests/graph.scm b/tests/graph.scm
index fadac265f9..baa08a6be2 100644
--- a/tests/graph.scm
+++ b/tests/graph.scm
@@ -36,6 +36,7 @@ (define-module (test-graph)
   #:use-module (gnu packages libunistring)
   #:use-module (gnu packages bootstrap)
   #:use-module (ice-9 match)
+  #:use-module (ice-9 sandbox)
   #:use-module (srfi srfi-1)
   #:use-module (srfi srfi-11)
   #:use-module (srfi srfi-26)
@@ -113,6 +114,33 @@ (define (edge->tuple source target)
                           (list p4 p4)
                           (list p2 p3))))))))
 
+(test-assert "package DAG, oops it was a cycle"
+  (let-values (((backend nodes+edges) (make-recording-backend)))
+    (letrec ((p1 (dummy-package "p1" (inputs `(("p3" ,p3)))))
+             (p2 (dummy-package "p2" (inputs `(("p1" ,p1)))))
+             (p3 (dummy-package "p3" (inputs `(("p2" ,p2) ("p1", p1))))))
+      (call-with-time-limit
+       600 ;; If ever this test should fail, we still want it to terminate
+       (lambda ()
+         (run-with-store %store
+           (export-graph (list p3) 'port
+                         #:node-type %package-node-type
+                         #:backend backend)))
+       (lambda ()
+         (run-with-store %store
+           (export-graph
+            (list (dummy-package "timeout-reached"))
+            'port
+            #:node-type %package-node-type
+            #:backend backend))))
+      ;; We should see nothing more than these 3 packages.
+      (let-values (((nodes edges) (nodes+edges)))
+        (and (equal? nodes (map package->tuple (list p3 p2 p1)))
+             (equal? edges
+                     (map edge->tuple
+                          (list p3 p3 p2 p1)
+                          (list p2 p1 p1 p3))))))))
+
 (test-assert "reverse package DAG"
   (let-values (((backend nodes+edges) (make-recording-backend)))
     (run-with-store %store
-- 
2.34.0





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [bug#53510] [PATCH] tests: Assert that cyclic graphs can be produced.
  2022-01-24 18:15 [bug#53510] [PATCH] tests: Assert that cyclic graphs can be produced Liliana Marie Prikler
@ 2022-02-04 22:11 ` Ludovic Courtès
  0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2022-02-04 22:11 UTC (permalink / raw)
  To: Liliana Marie Prikler; +Cc: 53510

Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:

> * tests/graph.scm ("package DAG, oops it was a cycle"): New test.

LGTM, thanks!

Ludo'.




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-02-04 22:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-24 18:15 [bug#53510] [PATCH] tests: Assert that cyclic graphs can be produced Liliana Marie Prikler
2022-02-04 22:11 ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).