From: mpatras <madalinionel.patrascu@mdc-berlin.de>
To: Leo Famulari <leo@famulari.name>
Cc: 32984@debbugs.gnu.org
Subject: [bug#32984] [PATCH] gnu: filtlong: update path in aux script.
Date: Mon, 5 Nov 2018 17:26:12 +0100 [thread overview]
Message-ID: <92b28f6e-4a68-5b5f-dcb7-40c376774f22@mdc-berlin.de> (raw)
In-Reply-To: <20181011205550.GF7201@jasmine.lan>
[-- Attachment #1: Type: text/plain, Size: 1761 bytes --]
Hello Leo,
I am sorry for this delayed response!
In the initial version of this description, I have put the auxiliary
scripts in /scripts/.
I didn't know that all auxiliary scripts should be put in
/share/name_of_package/scripts.
The script loads the package using a relative path.
Ludo corrected my description and changed my substitute lines to this,
- (wrap-program (string-append out "/scripts/histogram.py")
+ (wrap-program (string-append out
+ "/share/filtlong/scripts/histogram.py")
Now the script is on the right place
(/share/filtlong/scripts/histogram.py), but it does not contain the
right relative path. So, this patch is needed to correct the relative path.
+ (substitute* "scripts/read_info_histograms.sh"
+ (("/../") "/../../../"))
Sorry, from the beginning was my mistake!
On 11.10.2018 22:55, Leo Famulari wrote:
> On Tue, Oct 09, 2018 at 06:22:39PM +0200, pimi wrote:
>> * gnu/packages/bioinformatics.scm (filtlong)[extra scritps]: corrected
>> the loading path for the filtlong in the script read_info_histograms.sh.
> [...]
>
>> (lambda _
>> (substitute* "scripts/read_info_histograms.sh"
>> (("awk") (which "gawk")))
>> + (substitute* "scripts/read_info_histograms.sh"
>> + (("/../") "/../../../"))
>> #t)))))
> Can you add a code comment explaining the effect of this change? It's
> rather cryptic! :)
--
All the best!
Mădălin Ionel Patrașcu
System Administrator
The Berlin Institute for Medical Systems Biology (BIMSB)
Max Delbrück Center (MDC)
Robert-Rössle-Straße 10
House 87, room 1.10
13125 Berlin, Germany
[-- Attachment #2: Type: text/html, Size: 3558 bytes --]
prev parent reply other threads:[~2018-11-05 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 9:17 [bug#32984] [PATCH] gnu: Add filtlong pimi
2018-10-08 16:32 ` bug#32984: " Ludovic Courtès
2018-10-09 16:22 ` [bug#32984] [PATCH] gnu: filtlong: update path in aux script pimi
2018-10-11 20:55 ` Leo Famulari
2018-11-05 16:26 ` mpatras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92b28f6e-4a68-5b5f-dcb7-40c376774f22@mdc-berlin.de \
--to=madalinionel.patrascu@mdc-berlin.de \
--cc=32984@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).