From: Juliana Sims <juli@incana.org>
To: 63473@debbugs.gnu.org
Subject: [bug#63473] [PATCH] gnu: praat: Update to 6.3.10.
Date: Mon, 26 Jun 2023 01:52:57 -0400 [thread overview]
Message-ID: <90JUWR.AJBFPRKS0IKT3@incana.org> (raw)
In-Reply-To: <60c20787457b3c531db6948f2b9773e79214b1f4.1683929239.git.firestone.preston@gmail.com>
Hi Preston,
Would it be possible to split some of these changes into separate
patches? For example, rewriting the style of the inputs field and
removing the #t's could be in their own patch. Ideally any changes not
strictly related to the update should be in a separate patch from the
changes strictly necessary for the update, and each patch should
contain one logically-related set of changes.
Related, were you able to fix the build of the old version? If so,
could you commit that fix as the first in a patch series?
> + ;; FIXME: Why doesn't this test pass?
It seems like this is answered later by
> + ;; Run only the tests that don't require a GUI.
and if that's the case the first comment could be changed. Also, you
can get X during build with xorg-server-for-tests as a native-input and
a build stage like this one from the geary package defintion:
```
(add-before 'check 'setup-xvfb
(lambda _
(system "Xvfb :1 &")
(setenv "DISPLAY" ":1")))
```
While I don't know that such an addition will resolve the failing test,
it might be worth trying.
Everything else seems to look fine. You may want to run guix style -S
arguments to port it to g-expressions while you're here, but I don't
think that's strictly necessary, just preferred.
All the best,
Juli
next prev parent reply other threads:[~2023-06-26 5:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 22:09 [bug#63473] [PATCH] gnu: praat: Update to 6.3.10 Preston M. Firestone
2023-06-21 12:00 ` Preston Miller Firestone
2023-06-26 4:25 ` Liliana Marie Prikler
2023-06-26 5:52 ` Juliana Sims [this message]
2023-06-26 17:42 ` [bug#63473] [PATCH 1/4] gnu: praat: Update to 6.1.49 Preston M. Firestone
2023-06-26 17:42 ` [bug#63473] [PATCH 2/4] gnu: praat: Update to 6.3.10 Preston M. Firestone
2023-06-26 17:42 ` [bug#63473] [PATCH 3/4] gnu: praat: Add tests to praat Preston M. Firestone
2023-06-26 17:42 ` [bug#63473] [PATCH 4/4] gnu: praat: Fix style Preston M. Firestone
2023-06-26 17:53 ` [bug#63473] [PATCH] gnu: praat: Update to 6.3.10 Preston Miller Firestone
2023-08-07 14:21 ` bug#63473: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90JUWR.AJBFPRKS0IKT3@incana.org \
--to=juli@incana.org \
--cc=63473@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).