From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id kC7gMwsomWQmdQEASxT56A (envelope-from ) for ; Mon, 26 Jun 2023 07:54:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id kHzTMwsomWT8swAA9RJhRA (envelope-from ) for ; Mon, 26 Jun 2023 07:54:19 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 776B12C272 for ; Mon, 26 Jun 2023 07:54:19 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDfAr-00031l-Cz; Mon, 26 Jun 2023 01:54:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDfAp-00031E-3e for guix-patches@gnu.org; Mon, 26 Jun 2023 01:54:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qDfAo-0006FW-Qa for guix-patches@gnu.org; Mon, 26 Jun 2023 01:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qDfAo-00041a-EZ for guix-patches@gnu.org; Mon, 26 Jun 2023 01:54:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63473] [PATCH] gnu: praat: Update to 6.3.10. References: <60c20787457b3c531db6948f2b9773e79214b1f4.1683929239.git.firestone.preston@gmail.com> In-Reply-To: <60c20787457b3c531db6948f2b9773e79214b1f4.1683929239.git.firestone.preston@gmail.com> Resent-From: Juliana Sims Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 26 Jun 2023 05:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63473 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63473@debbugs.gnu.org Received: via spool by 63473-submit@debbugs.gnu.org id=B63473.168775880215394 (code B ref 63473); Mon, 26 Jun 2023 05:54:02 +0000 Received: (at 63473) by debbugs.gnu.org; 26 Jun 2023 05:53:22 +0000 Received: from localhost ([127.0.0.1]:44187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDfA9-00040E-Qo for submit@debbugs.gnu.org; Mon, 26 Jun 2023 01:53:22 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:36371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDfA4-0003zp-RP for 63473@debbugs.gnu.org; Mon, 26 Jun 2023 01:53:20 -0400 X-GND-Sasl: juli@incana.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=incana.org; s=gm1; t=1687758790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=E6viISMrmLVmmTg5iliIHxVWuxeCC++9+1DE+2c/tT4=; b=PvqhM1WqXpHq5qTIKa5rsrS1824aMhDj3KewT9Ivt51iHotsDQJz88qkE8IzcmUiydF+Y3 Zw5SqQ/losyFngoX1zf3M86T/Uf1OOX+jDvqpQyCLtqZDoS1zRxFW9AocJFfbglLPxMTXz uYgjM7wPQ1WDzLTnfY1R8mnG67ViZ30JaiRjk4Y3bsp1bdLr8sNn3L+9f6alSlmazJHrRy 9oXJlfcRP9UoRTQxYGeWxBnA9m88tVuma6iGkdPhrqhQPcysU8ZLpOHpLAOvmvRMejct/J tZWrAd0VnKHc92StTZ4VEKCTvAPMarJVLaEqulJ4lZRKpsKxfWFK/m7zFRV23A== Received: by mail.gandi.net (Postfix) with ESMTPSA id F2D0240005 for <63473@debbugs.gnu.org>; Mon, 26 Jun 2023 05:53:09 +0000 (UTC) Date: Mon, 26 Jun 2023 01:52:57 -0400 From: Juliana Sims Message-Id: <90JUWR.AJBFPRKS0IKT3@incana.org> X-Mailer: geary/43.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1687758859; a=rsa-sha256; cv=none; b=WdD1VqZ4KWWqdWNC3VxnassZBqAZxTI0YL4IiGL8GUh33Vcj1cybLaNnqelQXXFkWIgcVc SMJX4q1Uhw2GJG+lph1xuVpG8M44G69zyOeI5z247e32DTf+hJJYRf7XTPF0v6FCjSulQp nkk/X8QolG4u/bATY20gxJygoQJ6eFThZeHeJAugyJoE6PUJ3U4jHZkEC161HIa4Tww7TY 2wCyPEBCBijBPKjrrNnZJBmj2auc4RH1nAjGPDxykvcbcMy7P0gLGM3dbiJ6tE4AXNOzoS 5pVmA+Iccin05+U6HFb9EJCldQnxXd0HuyJVAD3J6lXR6MKAzPEihNXZOB+pYw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=incana.org header.s=gm1 header.b=PvqhM1Wq; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1687758859; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=E6viISMrmLVmmTg5iliIHxVWuxeCC++9+1DE+2c/tT4=; b=F7myZ/R+EJFnyIlwSODl3mExLj/MkroSb5Rm2sjXI7EAtbAbz/4c8eZpzZwojQqSMDeT5d Y/8hlHvXLAA4kVReOqy0Yu3fVBiJN4ziUwP4O3o9LYXxij7X53NlXiyM7JMwK0A6ZPtUFM wqQUgEDC47t1V2Go3wT2uWI6/Aw5GkIMxhT7c4lbXYmG+CLYTJHehbZhAYSmLNrlVGvBij pW3Jh3n1auuohnN4/LrQEPH5ixnZsT7R/G8IGvDTVQlBL8PlAcUGeWOxQsjsCLXFXpxVEC dCpzB39jWkOuoyQG7haGLtrkC0dYZIYppJMMsYkL7ZablU+XvRC+xSbYT1kMSQ== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=incana.org header.s=gm1 header.b=PvqhM1Wq; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -3.05 X-Spam-Score: -3.05 X-Migadu-Queue-Id: 776B12C272 X-TUID: GNjWbgVbdFXC Hi Preston, Would it be possible to split some of these changes into separate patches? For example, rewriting the style of the inputs field and removing the #t's could be in their own patch. Ideally any changes not strictly related to the update should be in a separate patch from the changes strictly necessary for the update, and each patch should contain one logically-related set of changes. Related, were you able to fix the build of the old version? If so, could you commit that fix as the first in a patch series? > + ;; FIXME: Why doesn't this test pass? It seems like this is answered later by > + ;; Run only the tests that don't require a GUI. and if that's the case the first comment could be changed. Also, you can get X during build with xorg-server-for-tests as a native-input and a build stage like this one from the geary package defintion: ``` (add-before 'check 'setup-xvfb (lambda _ (system "Xvfb :1 &") (setenv "DISPLAY" ":1"))) ``` While I don't know that such an addition will resolve the failing test, it might be worth trying. Everything else seems to look fine. You may want to run guix style -S arguments to port it to g-expressions while you're here, but I don't think that's strictly necessary, just preferred. All the best, Juli