unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#69600] [PATCH] gnu: mc: Update to 4.8.31
@ 2024-03-07  5:25 Andy Tai
  2024-03-08  0:16 ` [bug#69600] [PATCH v2] " Juliana Sims via Guix-patches via
  2024-03-08  6:31 ` Andy Tai
  0 siblings, 2 replies; 6+ messages in thread
From: Andy Tai @ 2024-03-07  5:25 UTC (permalink / raw)
  To: 69600; +Cc: Andy Tai

* gnu/packages/mc.scm (mc): Update to 4.8.31

Change-Id: Ib610e76b2ef5e6c1a1f49f34073015c0b260ea77
---
 gnu/packages/mc.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/mc.scm b/gnu/packages/mc.scm
index 994f89f524..5181718306 100644
--- a/gnu/packages/mc.scm
+++ b/gnu/packages/mc.scm
@@ -40,14 +40,14 @@ (define-module (gnu packages mc)
 (define-public mc
   (package
     (name "mc")
-    (version "4.8.30")
+    (version "4.8.31")
     (source
      (origin
       (method url-fetch)
       (uri (string-append "https://ftp.osuosl.org/pub/midnightcommander/mc-"
                           version ".tar.xz"))
       (sha256
-       (base32 "1py7jm620lsas7rcv5j69608gdshmp25d9gx958hr5sb2jr3rg2y"))))
+       (base32 "06mbnhxd2k29jah4wp1ciicw1gb51a5d3af43zivhxbncvw1q694"))))
     (build-system gnu-build-system)
     (arguments
      (list

base-commit: b4107ca3ad8bb8a6b8e669c298be2f14ff0237da
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#69600] [PATCH v2] gnu: mc: Update to 4.8.31
  2024-03-07  5:25 [bug#69600] [PATCH] gnu: mc: Update to 4.8.31 Andy Tai
@ 2024-03-08  0:16 ` Juliana Sims via Guix-patches via
  2024-03-08  0:37   ` Andy Tai
  2024-03-08  6:31 ` Andy Tai
  1 sibling, 1 reply; 6+ messages in thread
From: Juliana Sims via Guix-patches via @ 2024-03-08  0:16 UTC (permalink / raw)
  To: 69600; +Cc: atai

From: Andy Tai <atai@atai.org>

Hello,

This patch failed to build because `mkstemp` could not find
"src/vfs/fish/fish.c.XXXXXX". Removing the reference to "src/vfs/fish/fish.c" in
the first `substitute*` form of the `patch-file-names` phase results in a
successful build. Attached is a patch making that very minor correction.

With that change made, this builds fine on x86 and aarch64, so I'm comfortable
saying it's good to go :)

Thanks,
Juli

* gnu/packages/mc.scm (mc): Update to 4.8.31

Change-Id: Ib610e76b2ef5e6c1a1f49f34073015c0b260ea77
---
 gnu/packages/mc.scm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/mc.scm b/gnu/packages/mc.scm
index 994f89f5248..8cf760ac53c 100644
--- a/gnu/packages/mc.scm
+++ b/gnu/packages/mc.scm
@@ -40,14 +40,14 @@ (define-module (gnu packages mc)
 (define-public mc
   (package
     (name "mc")
-    (version "4.8.30")
+    (version "4.8.31")
     (source
      (origin
       (method url-fetch)
       (uri (string-append "https://ftp.osuosl.org/pub/midnightcommander/mc-"
                           version ".tar.xz"))
       (sha256
-       (base32 "1py7jm620lsas7rcv5j69608gdshmp25d9gx958hr5sb2jr3rg2y"))))
+       (base32 "06mbnhxd2k29jah4wp1ciicw1gb51a5d3af43zivhxbncvw1q694"))))
     (build-system gnu-build-system)
     (arguments
      (list
@@ -68,7 +68,6 @@ (define-public mc
                   (list "lib/utilunix.c"
                         "src/filemanager/ext.c"
                         "src/usermenu.c"
-                        "src/vfs/fish/fish.c"
                         ;; This file hard-codes other shells, but they're never
                         ;; tried after mc's first choice (bash) is found.
                         "lib/shell.c")

base-commit: 06e61f9cd2f4c317e19bf4eca817737af6544c42
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#69600] [PATCH v2] gnu: mc: Update to 4.8.31
  2024-03-08  0:16 ` [bug#69600] [PATCH v2] " Juliana Sims via Guix-patches via
@ 2024-03-08  0:37   ` Andy Tai
  0 siblings, 0 replies; 6+ messages in thread
From: Andy Tai @ 2024-03-08  0:37 UTC (permalink / raw)
  To: Juliana Sims; +Cc: 69600

the modified patch looks good to me.  Hope a commiter picks it up and commit

On Thu, Mar 7, 2024 at 4:31 PM Juliana Sims <juli@incana.org> wrote:
>
> From: Andy Tai <atai@atai.org>
>
> Hello,
>
> This patch failed to build because `mkstemp` could not find
> "src/vfs/fish/fish.c.XXXXXX". Removing the reference to "src/vfs/fish/fish.c" in
> the first `substitute*` form of the `patch-file-names` phase results in a
> successful build. Attached is a patch making that very minor correction.
>
> With that change made, this builds fine on x86 and aarch64, so I'm comfortable
> saying it's good to go :)
>
> Thanks,
> Juli
>
> * gnu/packages/mc.scm (mc): Update to 4.8.31
>
> Change-Id: Ib610e76b2ef5e6c1a1f49f34073015c0b260ea77
> ---
>  gnu/packages/mc.scm | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/mc.scm b/gnu/packages/mc.scm
> index 994f89f5248..8cf760ac53c 100644
> --- a/gnu/packages/mc.scm
> +++ b/gnu/packages/mc.scm
> @@ -40,14 +40,14 @@ (define-module (gnu packages mc)
>  (define-public mc
>    (package
>      (name "mc")
> -    (version "4.8.30")
> +    (version "4.8.31")
>      (source
>       (origin
>        (method url-fetch)
>        (uri (string-append "https://ftp.osuosl.org/pub/midnightcommander/mc-"
>                            version ".tar.xz"))
>        (sha256
> -       (base32 "1py7jm620lsas7rcv5j69608gdshmp25d9gx958hr5sb2jr3rg2y"))))
> +       (base32 "06mbnhxd2k29jah4wp1ciicw1gb51a5d3af43zivhxbncvw1q694"))))
>      (build-system gnu-build-system)
>      (arguments
>       (list
> @@ -68,7 +68,6 @@ (define-public mc
>                    (list "lib/utilunix.c"
>                          "src/filemanager/ext.c"
>                          "src/usermenu.c"
> -                        "src/vfs/fish/fish.c"
>                          ;; This file hard-codes other shells, but they're never
>                          ;; tried after mc's first choice (bash) is found.
>                          "lib/shell.c")
>
> base-commit: 06e61f9cd2f4c317e19bf4eca817737af6544c42
> --
> 2.41.0
>




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#69600] [PATCH v2] gnu: mc: Update to 4.8.31
  2024-03-07  5:25 [bug#69600] [PATCH] gnu: mc: Update to 4.8.31 Andy Tai
  2024-03-08  0:16 ` [bug#69600] [PATCH v2] " Juliana Sims via Guix-patches via
@ 2024-03-08  6:31 ` Andy Tai
  2024-03-08  6:33   ` Andy Tai
  2024-03-09  3:43   ` bug#69600: " 宋文武 via Guix-patches via
  1 sibling, 2 replies; 6+ messages in thread
From: Andy Tai @ 2024-03-08  6:31 UTC (permalink / raw)
  To: 69600; +Cc: Andy Tai

* gnu/packages/mc.scm (mc): Update to 4.8.31

Change-Id: Ib610e76b2ef5e6c1a1f49f34073015c0b260ea77
---
 gnu/packages/mc.scm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/mc.scm b/gnu/packages/mc.scm
index 994f89f524..8cf760ac53 100644
--- a/gnu/packages/mc.scm
+++ b/gnu/packages/mc.scm
@@ -40,14 +40,14 @@ (define-module (gnu packages mc)
 (define-public mc
   (package
     (name "mc")
-    (version "4.8.30")
+    (version "4.8.31")
     (source
      (origin
       (method url-fetch)
       (uri (string-append "https://ftp.osuosl.org/pub/midnightcommander/mc-"
                           version ".tar.xz"))
       (sha256
-       (base32 "1py7jm620lsas7rcv5j69608gdshmp25d9gx958hr5sb2jr3rg2y"))))
+       (base32 "06mbnhxd2k29jah4wp1ciicw1gb51a5d3af43zivhxbncvw1q694"))))
     (build-system gnu-build-system)
     (arguments
      (list
@@ -68,7 +68,6 @@ (define-public mc
                   (list "lib/utilunix.c"
                         "src/filemanager/ext.c"
                         "src/usermenu.c"
-                        "src/vfs/fish/fish.c"
                         ;; This file hard-codes other shells, but they're never
                         ;; tried after mc's first choice (bash) is found.
                         "lib/shell.c")

base-commit: f18d13b5f89c161c6ee88d15ecdaa8d973ee4503
-- 
2.34.1





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#69600] [PATCH v2] gnu: mc: Update to 4.8.31
  2024-03-08  6:31 ` Andy Tai
@ 2024-03-08  6:33   ` Andy Tai
  2024-03-09  3:43   ` bug#69600: " 宋文武 via Guix-patches via
  1 sibling, 0 replies; 6+ messages in thread
From: Andy Tai @ 2024-03-08  6:33 UTC (permalink / raw)
  To: 69600

new patch v2 to make Juliana's suggested change official so Guix QA
can pick it up


On Thu, Mar 7, 2024 at 10:31 PM Andy Tai <atai@atai.org> wrote:
>
> * gnu/packages/mc.scm (mc): Update to 4.8.31
>
> Change-Id: Ib610e76b2ef5e6c1a1f49f34073015c0b260ea77
> ---
>  gnu/packages/mc.scm | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/mc.scm b/gnu/packages/mc.scm
> index 994f89f524..8cf760ac53 100644
> --- a/gnu/packages/mc.scm
> +++ b/gnu/packages/mc.scm
> @@ -40,14 +40,14 @@ (define-module (gnu packages mc)
>  (define-public mc
>    (package
>      (name "mc")
> -    (version "4.8.30")
> +    (version "4.8.31")
>      (source
>       (origin
>        (method url-fetch)
>        (uri (string-append "https://ftp.osuosl.org/pub/midnightcommander/mc-"
>                            version ".tar.xz"))
>        (sha256
> -       (base32 "1py7jm620lsas7rcv5j69608gdshmp25d9gx958hr5sb2jr3rg2y"))))
> +       (base32 "06mbnhxd2k29jah4wp1ciicw1gb51a5d3af43zivhxbncvw1q694"))))
>      (build-system gnu-build-system)
>      (arguments
>       (list
> @@ -68,7 +68,6 @@ (define-public mc
>                    (list "lib/utilunix.c"
>                          "src/filemanager/ext.c"
>                          "src/usermenu.c"
> -                        "src/vfs/fish/fish.c"
>                          ;; This file hard-codes other shells, but they're never
>                          ;; tried after mc's first choice (bash) is found.
>                          "lib/shell.c")
>
> base-commit: f18d13b5f89c161c6ee88d15ecdaa8d973ee4503
> --
> 2.34.1
>




^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#69600: [PATCH v2] gnu: mc: Update to 4.8.31
  2024-03-08  6:31 ` Andy Tai
  2024-03-08  6:33   ` Andy Tai
@ 2024-03-09  3:43   ` 宋文武 via Guix-patches via
  1 sibling, 0 replies; 6+ messages in thread
From: 宋文武 via Guix-patches via @ 2024-03-09  3:43 UTC (permalink / raw)
  To: Andy Tai; +Cc: 69600-done

Andy Tai <atai@atai.org> writes:

> * gnu/packages/mc.scm (mc): Update to 4.8.31
>
> Change-Id: Ib610e76b2ef5e6c1a1f49f34073015c0b260ea77

Applied as commit d13cfbc3f9, thank you!




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-03-09  3:43 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-07  5:25 [bug#69600] [PATCH] gnu: mc: Update to 4.8.31 Andy Tai
2024-03-08  0:16 ` [bug#69600] [PATCH v2] " Juliana Sims via Guix-patches via
2024-03-08  0:37   ` Andy Tai
2024-03-08  6:31 ` Andy Tai
2024-03-08  6:33   ` Andy Tai
2024-03-09  3:43   ` bug#69600: " 宋文武 via Guix-patches via

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).