From: Marius Bakke <mbakke@fastmail.com>
To: Danny Milosavljevic <dannym@scratchpost.org>, 30497@debbugs.gnu.org
Subject: [bug#30497] [PATCH] services: slim: Make the logged-in session show up in "w".
Date: Sat, 17 Feb 2018 16:36:28 +0100 [thread overview]
Message-ID: <87zi47typv.fsf@fastmail.com> (raw)
In-Reply-To: <20180217120022.696-1-dannym@scratchpost.org>
[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]
Danny Milosavljevic <dannym@scratchpost.org> writes:
> * gnu/services/xorg.scm (slim-shepherd-service): Make the logged-in session
> show up in "w".
Nit-pick: Instead of reusing the commit title here, it would be better
to mention what is being done, e.g. "Use SESSREG to register X11
session".
[...]
> diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm
> index 50af2408b..b73dbe0d7 100644
> --- a/gnu/services/xorg.scm
> +++ b/gnu/services/xorg.scm
> @@ -467,6 +467,8 @@ authfile /var/run/slim.auth
> login_cmd exec " xinitrc " %session
> sessiondir /run/current-system/profile/share/xsessions
> session_msg session (F1 to change):
> +sessionstart_cmd " sessreg "/bin/sessreg -a -l $DISPLAY %user
> +sessionstop_cmd " sessreg "/bin/sessreg -d -l $DISPLAY %user
I'm surprised that this works. I would have expected sessreg to be
unbound in this context, and that it would have to be added to the
<slim-configuration> record similar to xauth and startx.
However I suspect it may be better to add it to the record regardless,
to stay consistent and allow overriding it. WDYT?
This is a change that affects most GuixSD users, so we better not break
anything here :-)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2018-02-17 15:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-17 12:00 [bug#30497] [PATCH] services: slim: Make the logged-in session show up in "w" Danny Milosavljevic
2018-02-17 15:36 ` Marius Bakke [this message]
2018-02-17 16:34 ` [bug#30497] [PATCH v2] " Danny Milosavljevic
2018-02-19 21:27 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi47typv.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=30497@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).