From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33870)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1en4Xx-0001rA-Uo
	for guix-patches@gnu.org; Sat, 17 Feb 2018 10:37:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1en4Xu-0005Qk-Qd
	for guix-patches@gnu.org; Sat, 17 Feb 2018 10:37:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:40553)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1en4Xu-0005Qd-Le
	for guix-patches@gnu.org; Sat, 17 Feb 2018 10:37:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1en4Xu-0006o7-Dq
	for guix-patches@gnu.org; Sat, 17 Feb 2018 10:37:02 -0500
Subject: [bug#30497] [PATCH] services: slim: Make the logged-in session show
	up in "w".
Resent-Message-ID: <handler.30497.B30497.151888179226129@debbugs.gnu.org>
From: Marius Bakke <mbakke@fastmail.com>
In-Reply-To: <20180217120022.696-1-dannym@scratchpost.org>
References: <20180217120022.696-1-dannym@scratchpost.org>
Date: Sat, 17 Feb 2018 16:36:28 +0100
Message-ID: <87zi47typv.fsf@fastmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>, 30497@debbugs.gnu.org

--=-=-=
Content-Type: text/plain

Danny Milosavljevic <dannym@scratchpost.org> writes:

> * gnu/services/xorg.scm (slim-shepherd-service): Make the logged-in session
> show up in "w".

Nit-pick: Instead of reusing the commit title here, it would be better
to mention what is being done, e.g. "Use SESSREG to register X11
session".

[...]

> diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm
> index 50af2408b..b73dbe0d7 100644
> --- a/gnu/services/xorg.scm
> +++ b/gnu/services/xorg.scm
> @@ -467,6 +467,8 @@ authfile /var/run/slim.auth
>  login_cmd  exec " xinitrc " %session
>  sessiondir /run/current-system/profile/share/xsessions
>  session_msg session (F1 to change):
> +sessionstart_cmd " sessreg "/bin/sessreg -a -l $DISPLAY %user
> +sessionstop_cmd " sessreg "/bin/sessreg -d -l $DISPLAY %user

I'm surprised that this works.  I would have expected sessreg to be
unbound in this context, and that it would have to be added to the
<slim-configuration> record similar to xauth and startx.

However I suspect it may be better to add it to the record regardless,
to stay consistent and allow overriding it.  WDYT?

This is a change that affects most GuixSD users, so we better not break
anything here :-)

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlqIS/wACgkQoqBt8qM6
VPqHDAgAi8UihyG1UBr8gjk027BPTyiiY7acqsvAJRSGtBvRY5eAqAYTxhDDWIFP
esNh4M8xeoWBDIkMjJjJg+Ws9Xb7F25HXRK72NIf6NPND7Uc+nPQi5hwjyGWzQbE
Wkd1TsI/rxF4vKEzTBjra/ra56U3ylDUFh5mh5EX0mUFgBbwmJqWNsyYCeKoAwIY
txKx2k70m40Ga8NTotOz78LpRatfu9eh2oMpMqZ5xn7s8lA7Kck28ek3oL4DuAWH
zqbo50r4oewgSK5dEI8o7oyJiPpCm0LYp1eKiyCygTPbsdAmw9i/1TVHpe2xNIYz
e2i5P28QpNE3otLlJCgkTT4F/Okd4g==
=rYl+
-----END PGP SIGNATURE-----
--=-=-=--