* [bug#36628] Minor fixes for pngcrush and python-aiorpcx @ 2019-07-12 21:41 Arne Babenhauserheide 2019-07-12 21:41 ` [bug#36628] [PATCH 1/2] gnu: pngcrush: fix typo in description Arne Babenhauserheide 2019-07-12 21:41 ` [bug#36629] [PATCH 2/2] gnu: python-aiorpcx: capitalize description Arne Babenhauserheide 0 siblings, 2 replies; 6+ messages in thread From: Arne Babenhauserheide @ 2019-07-12 21:41 UTC (permalink / raw) To: 36628 Hi, The following two patches are just fixing a typo and making guix lint happier. Happy Hacking! - Arne ^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#36628] [PATCH 1/2] gnu: pngcrush: fix typo in description 2019-07-12 21:41 [bug#36628] Minor fixes for pngcrush and python-aiorpcx Arne Babenhauserheide @ 2019-07-12 21:41 ` Arne Babenhauserheide 2019-07-12 22:19 ` Tobias Geerinckx-Rice 2019-07-12 21:41 ` [bug#36629] [PATCH 2/2] gnu: python-aiorpcx: capitalize description Arne Babenhauserheide 1 sibling, 1 reply; 6+ messages in thread From: Arne Babenhauserheide @ 2019-07-12 21:41 UTC (permalink / raw) To: 36628; +Cc: Arne Babenhauserheide * gnu/packages/image.scm (pngcrush): fix typo in description --- gnu/packages/image.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm index 511f5302b7..b465ff376e 100644 --- a/gnu/packages/image.scm +++ b/gnu/packages/image.scm @@ -250,7 +250,7 @@ APNG patch provides APNG support to libpng.") ("zlib" , zlib))) (home-page "https://pmt.sourceforge.io/pngcrush") (synopsis "Utility to compress PNG files") - (description "pngcrusqh is an optimizer for PNG (Portable Network Graphics) + (description "pngcrush is an optimizer for PNG (Portable Network Graphics) files. It can compress them as much as 40% losslessly.") (license license:zlib))) -- 2.22.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#36628] [PATCH 1/2] gnu: pngcrush: fix typo in description 2019-07-12 21:41 ` [bug#36628] [PATCH 1/2] gnu: pngcrush: fix typo in description Arne Babenhauserheide @ 2019-07-12 22:19 ` Tobias Geerinckx-Rice 2019-07-13 7:12 ` Arne Babenhauserheide 0 siblings, 1 reply; 6+ messages in thread From: Tobias Geerinckx-Rice @ 2019-07-12 22:19 UTC (permalink / raw) To: arne_bab; +Cc: 36628 [-- Attachment #1: Type: text/plain, Size: 1784 bytes --] Arne, Arne Babenhauserheide wrote: > * gnu/packages/image.scm (pngcrush): fix typo in description > --- > gnu/packages/image.scm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm > index 511f5302b7..b465ff376e 100644 > --- a/gnu/packages/image.scm > +++ b/gnu/packages/image.scm > @@ -250,7 +250,7 @@ APNG patch provides APNG support to > libpng.") > ("zlib" , zlib))) > (home-page "https://pmt.sourceforge.io/pngcrush") > (synopsis "Utility to compress PNG files") > - (description "pngcrusqh is an optimizer for PNG (Portable > Network Graphics) > + (description "pngcrush is an optimizer for PNG (Portable > Network Graphics) > files. It can compress them as much as 40% losslessly.") > (license license:zlib))) Thanks! I was going to quickly apply these two before sleepytimes but noticed that your other patch changes the description (only) to begin with a capital letter, while this one remains lowercase. Is that deliberate? I also couldn't help myself and kept editing... What do you think of the following? (It's still awfully short but that's another issue.) --- a/gnu/packages/image.scm +++ b/gnu/packages/image.scm @@ -250,8 +250,8 @@ APNG patch provides APNG support to libpng.") ("zlib" , zlib))) (home-page "https://pmt.sourceforge.io/pngcrush") (synopsis "Utility to compress PNG files") - (description "pngcrusqh is an optimizer for PNG (Portable Network Graphics) -files. It can compress them as much as 40% losslessly.") + (description "Pngcrush optimizes @acronym{PNG, Portable Network Graphics} +images. It can losslessly compress files by as much as an additional 40%.") (license license:zlib))) Or something, T G-R [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 227 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#36628] [PATCH 1/2] gnu: pngcrush: fix typo in description 2019-07-12 22:19 ` Tobias Geerinckx-Rice @ 2019-07-13 7:12 ` Arne Babenhauserheide 0 siblings, 0 replies; 6+ messages in thread From: Arne Babenhauserheide @ 2019-07-13 7:12 UTC (permalink / raw) To: Tobias Geerinckx-Rice; +Cc: 36628 [-- Attachment #1: Type: text/plain, Size: 2462 bytes --] Tobias Geerinckx-Rice <me@tobias.gr> writes: > Arne, > > Arne Babenhauserheide wrote: >> * gnu/packages/image.scm (pngcrush): fix typo in description >> --- >> gnu/packages/image.scm | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm >> index 511f5302b7..b465ff376e 100644 >> --- a/gnu/packages/image.scm >> +++ b/gnu/packages/image.scm >> @@ -250,7 +250,7 @@ APNG patch provides APNG support to libpng.") >> ("zlib" , zlib))) >> (home-page "https://pmt.sourceforge.io/pngcrush") >> (synopsis "Utility to compress PNG files") >> - (description "pngcrusqh is an optimizer for PNG (Portable >> Network Graphics) >> + (description "pngcrush is an optimizer for PNG (Portable Network >> Graphics) >> files. It can compress them as much as 40% losslessly.") >> (license license:zlib))) > > Thanks! I was going to quickly apply these two before sleepytimes but > noticed that your other patch changes the description (only) to begin > with a capital letter, while this one remains lowercase. Is that > deliberate? For the other one guix lint complained, here it did not (maybe because it started with exactly the package name?). That’s the only reason. > I also couldn't help myself and kept editing... What do you think of > the following? (It's still awfully short but that's another issue.) > > --- a/gnu/packages/image.scm > +++ b/gnu/packages/image.scm > @@ -250,8 +250,8 @@ APNG patch provides APNG support to libpng.") > ("zlib" , zlib))) > (home-page "https://pmt.sourceforge.io/pngcrush") > (synopsis "Utility to compress PNG files") > - (description "pngcrusqh is an optimizer for PNG (Portable Network > Graphics) > -files. It can compress them as much as 40% losslessly.") > + (description "Pngcrush optimizes @acronym{PNG, Portable Network > Graphics} > +images. It can losslessly compress files by as much as an additional > 40%.") > (license license:zlib))) That sounds better. I think the correct English is "compress losslessly" and not "losslessly compress", but aside from that it’s much more crisp. I don’t think that being short is a problem, rather the opposite: if it’s easy to read and provides the information needed, short is often better. So go for it! :) Best wishes, Arne -- Unpolitisch sein heißt politisch sein ohne es zu merken [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 1076 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#36629] [PATCH 2/2] gnu: python-aiorpcx: capitalize description 2019-07-12 21:41 [bug#36628] Minor fixes for pngcrush and python-aiorpcx Arne Babenhauserheide 2019-07-12 21:41 ` [bug#36628] [PATCH 1/2] gnu: pngcrush: fix typo in description Arne Babenhauserheide @ 2019-07-12 21:41 ` Arne Babenhauserheide 2019-07-15 10:44 ` bug#36629: " Ludovic Courtès 1 sibling, 1 reply; 6+ messages in thread From: Arne Babenhauserheide @ 2019-07-12 21:41 UTC (permalink / raw) To: 36629; +Cc: Arne Babenhauserheide * gnu/packages/python-web.scm (python-aiorpcx): capitalize description --- gnu/packages/python-web.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm index 35f471084f..e07951978e 100644 --- a/gnu/packages/python-web.scm +++ b/gnu/packages/python-web.scm @@ -168,8 +168,8 @@ using @url{https://github.com/saghul/pycares,pycares}.") (home-page "https://github.com/kyuupichan/aiorpcX") (synopsis "Generic asyncio RPC implementation") (description - "aiorpcX is a generic asyncio library implementation of RPC suitable for -an application that is a client, server or both. + "The aiorpcX library is a generic asyncio implementation of RPC suitable +for an application that is a client, server or both. The package includes a module with full coverage of JSON RPC versions 1.0 and 2.0, JSON RPC protocol auto-detection, and arbitrary message framing. It also -- 2.22.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#36629: [PATCH 2/2] gnu: python-aiorpcx: capitalize description 2019-07-12 21:41 ` [bug#36629] [PATCH 2/2] gnu: python-aiorpcx: capitalize description Arne Babenhauserheide @ 2019-07-15 10:44 ` Ludovic Courtès 0 siblings, 0 replies; 6+ messages in thread From: Ludovic Courtès @ 2019-07-15 10:44 UTC (permalink / raw) To: Arne Babenhauserheide; +Cc: 36629-done Arne Babenhauserheide <arne_bab@web.de> skribis: > * gnu/packages/python-web.scm (python-aiorpcx): capitalize description Applied, thanks! ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-07-15 10:45 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-07-12 21:41 [bug#36628] Minor fixes for pngcrush and python-aiorpcx Arne Babenhauserheide 2019-07-12 21:41 ` [bug#36628] [PATCH 1/2] gnu: pngcrush: fix typo in description Arne Babenhauserheide 2019-07-12 22:19 ` Tobias Geerinckx-Rice 2019-07-13 7:12 ` Arne Babenhauserheide 2019-07-12 21:41 ` [bug#36629] [PATCH 2/2] gnu: python-aiorpcx: capitalize description Arne Babenhauserheide 2019-07-15 10:44 ` bug#36629: " Ludovic Courtès
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).