From: "Ludovic Courtès" <ludo@gnu.org>
To: Konrad Hinsen <konrad.hinsen@fastmail.net>
Cc: 38436@debbugs.gnu.org
Subject: [bug#38436] [PATCH] gnu: Add gfortran-toolchain
Date: Mon, 09 Dec 2019 15:30:38 +0100 [thread overview]
Message-ID: <87zhg1efld.fsf@gnu.org> (raw)
In-Reply-To: <m1a78arcu8.fsf@fastmail.net> (Konrad Hinsen's message of "Mon, 02 Dec 2019 16:01:19 +0100")
[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]
Hi Konrad,
Konrad Hinsen <konrad.hinsen@fastmail.net> skribis:
> * gnu/packages/commencement.scm: (gfortran-toolchain): New variable.
> * gnu/packages/commencement.scm: (make-gcc-toolchain): Added argument "language"
This LGTM, though I’d have a minor request:
> - (synopsis "Complete GCC tool chain for C/C++ development")
> + (synopsis (format #f
> + "Complete GCC tool chain for ~a development"
> + language))
> (description
> - "This package provides a complete GCC tool chain for C/C++ development to
> -be installed in user profiles. This includes GCC, as well as libc (headers
> -an d binaries, plus debugging symbols in the @code{debug} output), and Binutils.")
> + (format
> + #f
> + "This package provides a complete GCC tool chain for ~a development to
> +be installed in user profiles. This includes GCC, as well as libc (headers
> +and binaries, plus debugging symbols in the @code{debug} output), and Binutils."
> + language))
There’s this weird requirement that for the sake of i18n, we must not
construct synopses/descriptions like this:
https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html
I’d suggest something as shown below.
Could you update the patch along those lines?
Thanks,
Ludo’.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1308 bytes --]
diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm
index 68030376fc..00de771bc4 100644
--- a/gnu/packages/commencement.scm
+++ b/gnu/packages/commencement.scm
@@ -2523,8 +2523,12 @@ COREUTILS-FINAL vs. COREUTILS, etc."
;; (define-public gcc-glibc-2.27-toolchain
;; (make-gcc-toolchain gcc glibc-2.27))
-(define* (make-gcc-toolchain gcc
+(define* (make-gcc-toolchain language gcc
#:optional
+ ;; Note: Keep the synopsis literal string here so
+ ;; that xgettext "sees" it.
+ (synopsis
+ "Complete GCC tool chain for C/C++ development")
(libc #f))
"Return a complete toolchain for GCC. If LIBC is specified, target that libc."
(let ((gcc (if libc (make-gcc-libc gcc libc) gcc))
@@ -2559,7 +2563,7 @@ COREUTILS-FINAL vs. COREUTILS, etc."
(search-paths (package-search-paths gcc))
(license (package-license gcc))
- (synopsis "Complete GCC tool chain for C/C++ development")
+ (synopsis synopsis)
(description
"This package provides a complete GCC tool chain for C/C++ development to
be installed in user profiles. This includes GCC, as well as libc (headers
next prev parent reply other threads:[~2019-12-09 14:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 17:46 [bug#38436] [PATCH] gnu; Add gfortran-toolchain Konrad Hinsen
2019-12-02 15:01 ` [bug#38436] [PATCH] gnu: " Konrad Hinsen
2019-12-09 14:30 ` Ludovic Courtès [this message]
2019-12-10 13:11 ` Konrad Hinsen
2019-12-10 14:38 ` Ludovic Courtès
2019-12-11 10:30 ` Konrad Hinsen
2019-12-11 10:30 ` Konrad Hinsen
2019-12-11 11:12 ` Ludovic Courtès
2019-12-11 20:34 ` Konrad Hinsen
2019-12-12 13:20 ` Ludovic Courtès
2019-12-12 15:19 ` Konrad Hinsen
2019-12-12 21:22 ` Ludovic Courtès
2019-12-13 12:56 ` Konrad Hinsen
2019-12-13 12:53 ` Konrad Hinsen
2019-12-13 12:56 ` Jonathan Brielmaier
2019-12-14 23:22 ` bug#38436: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhg1efld.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=38436@debbugs.gnu.org \
--cc=konrad.hinsen@fastmail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).