From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:39195) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieK3z-0008FM-GI for guix-patches@gnu.org; Mon, 09 Dec 2019 09:31:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ieK3y-0003wU-7o for guix-patches@gnu.org; Mon, 09 Dec 2019 09:31:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46856) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ieK3x-0003wC-Nv for guix-patches@gnu.org; Mon, 09 Dec 2019 09:31:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ieK3x-0004Ca-K1 for guix-patches@gnu.org; Mon, 09 Dec 2019 09:31:01 -0500 Subject: [bug#38436] [PATCH] gnu: Add gfortran-toolchain Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Mon, 09 Dec 2019 15:30:38 +0100 In-Reply-To: (Konrad Hinsen's message of "Mon, 02 Dec 2019 16:01:19 +0100") Message-ID: <87zhg1efld.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Konrad Hinsen Cc: 38436@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Konrad, Konrad Hinsen skribis: > * gnu/packages/commencement.scm: (gfortran-toolchain): New variable. > * gnu/packages/commencement.scm: (make-gcc-toolchain): Added argument "la= nguage" This LGTM, though I=E2=80=99d have a minor request: > - (synopsis "Complete GCC tool chain for C/C++ development") > + (synopsis (format #f > + "Complete GCC tool chain for ~a development" > + language)) > (description > - "This package provides a complete GCC tool chain for C/C++ develo= pment to > -be installed in user profiles. This includes GCC, as well as libc (he= aders > -an d binaries, plus debugging symbols in the @code{debug} output), and = Binutils.") > + (format > + #f > + "This package provides a complete GCC tool chain for ~a developm= ent to > +be installed in user profiles. This includes GCC, as well as libc (head= ers > +and binaries, plus debugging symbols in the @code{debug} output), and Bi= nutils." > + language)) There=E2=80=99s this weird requirement that for the sake of i18n, we must n= ot construct synopses/descriptions like this: https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.= html I=E2=80=99d suggest something as shown below. Could you update the patch along those lines? Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm index 68030376fc..00de771bc4 100644 --- a/gnu/packages/commencement.scm +++ b/gnu/packages/commencement.scm @@ -2523,8 +2523,12 @@ COREUTILS-FINAL vs. COREUTILS, etc." ;; (define-public gcc-glibc-2.27-toolchain ;; (make-gcc-toolchain gcc glibc-2.27)) -(define* (make-gcc-toolchain gcc +(define* (make-gcc-toolchain language gcc #:optional + ;; Note: Keep the synopsis literal string here so + ;; that xgettext "sees" it. + (synopsis + "Complete GCC tool chain for C/C++ development") (libc #f)) "Return a complete toolchain for GCC. If LIBC is specified, target that libc." (let ((gcc (if libc (make-gcc-libc gcc libc) gcc)) @@ -2559,7 +2563,7 @@ COREUTILS-FINAL vs. COREUTILS, etc." (search-paths (package-search-paths gcc)) (license (package-license gcc)) - (synopsis "Complete GCC tool chain for C/C++ development") + (synopsis synopsis) (description "This package provides a complete GCC tool chain for C/C++ development to be installed in user profiles. This includes GCC, as well as libc (headers --=-=-=--