* [bug#41380] [PATCH] gnu: add glabels
@ 2020-05-18 21:11 Vinicius Monego
2020-05-20 18:07 ` Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: Vinicius Monego @ 2020-05-18 21:11 UTC (permalink / raw)
To: 41380; +Cc: Vinicius Monego
---
gnu/packages/gnome.scm | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index d5a2032ccf..2f258089be 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -50,6 +50,7 @@
;;; Copyright © 2020 raingloom <raingloom@riseup.net>
;;; Copyright © 2020 Nicolas Goaziou <mail@nicolasgoaziou.fr>
;;; Copyright © 2020 Naga Malleswari <nagamalli@riseup.net>
+;;; Copyright © 2020 Vinicius Monego <monego@posteo.net>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -10216,3 +10217,34 @@ communicating using the GVariant serialization format instead of JSON when
both peers support it. You might want that when communicating on a single
host to avoid parser overhead and memory-allocator fragmentation.")
(license license:lgpl2.1+)))
+
+(define-public glabels
+ (package
+ (name "glabels")
+ (version "3.4.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/" name "/"
+ (version-major+minor version) "/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "0f2rki8i27pkd9r0gz03cdl1g4vnmvp0j49nhxqn275vi8lmgr0q"))))
+ (build-system glib-or-gtk-build-system)
+ (native-inputs
+ `(("pkg-config" ,pkg-config)
+ ("glib:bin" ,glib "bin")
+ ("gettext" ,gettext-minimal)
+ ("intltool" ,intltool)
+ ("itstool" ,itstool)))
+ (inputs
+ `(("gtk+" ,gtk+)
+ ("librsvg" ,librsvg)
+ ("libxml2" ,libxml2)))
+ (home-page "http://glabels.org/")
+ (synopsis "Program for creating labels and business cards.")
+ (description
+ "gLabels is a program for creating labels and business cards. It is
+designed to work with various laser/ink-jet peel-off label and business
+card sheets that you’ll find at most office supply stores.")
+ (license license:gpl3+)))
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#41380] [PATCH] gnu: add glabels
2020-05-18 21:11 [bug#41380] [PATCH] gnu: add glabels Vinicius Monego
@ 2020-05-20 18:07 ` Nicolas Goaziou
2020-05-21 3:02 ` [bug#41430] [PATCH v2] gnu: Add glabels Vinicius Monego
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2020-05-20 18:07 UTC (permalink / raw)
To: Vinicius Monego; +Cc: 41380
Hello,
Vinicius Monego <monego@posteo.net> writes:
> ---
> gnu/packages/gnome.scm | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
Thank you! Could you use "git format-patch" and provide a commit message
in line with what we usually do for new packages? You may want to check
the commits in the repository to get an idea.
> +(define-public glabels
> + (package
> + (name "glabels")
> + (version "3.4.1")
> + (source (origin
Nitpick: Could you move "(origin" on the next line?
> + (method url-fetch)
> + (uri (string-append "mirror://gnome/sources/" name "/"
> + (version-major+minor version) "/"
> + name "-" version ".tar.xz"))
Could you replace "name" with "glabels"? We do not hard-code names
anymore in package definitions.
> + (sha256
> + (base32
> + "0f2rki8i27pkd9r0gz03cdl1g4vnmvp0j49nhxqn275vi8lmgr0q"))))
Nitpick: Could you put the string on the same line as `base32'?
> + (build-system glib-or-gtk-build-system)
> + (native-inputs
> + `(("pkg-config" ,pkg-config)
> + ("glib:bin" ,glib "bin")
> + ("gettext" ,gettext-minimal)
> + ("intltool" ,intltool)
> + ("itstool" ,itstool)))
Could you re-order alphabetically the native inputs?
> + (inputs
> + `(("gtk+" ,gtk+)
> + ("librsvg" ,librsvg)
> + ("libxml2" ,libxml2)))
> + (home-page "http://glabels.org/")
The home-page should be using https
> + (synopsis "Program for creating labels and business cards.")
Synopsis shouldn't end with a full stop. You may want to lint your
package definition with "guix lint".
> + (description
> + "gLabels is a program for creating labels and business cards. It is
> +designed to work with various laser/ink-jet peel-off label and business
> +card sheets that you’ll find at most office supply stores.")
> + (license license:gpl3+)))
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#41430] [PATCH v2] gnu: Add glabels.
2020-05-20 18:07 ` Nicolas Goaziou
@ 2020-05-21 3:02 ` Vinicius Monego
2020-05-22 15:45 ` bug#41430: " Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: Vinicius Monego @ 2020-05-21 3:02 UTC (permalink / raw)
To: 41430; +Cc: Vinicius Monego
* gnu/packages/gnome.scm (glabels): New variable.
---
gnu/packages/gnome.scm | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index d5a2032ccf..f7e4a4f348 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -50,6 +50,7 @@
;;; Copyright © 2020 raingloom <raingloom@riseup.net>
;;; Copyright © 2020 Nicolas Goaziou <mail@nicolasgoaziou.fr>
;;; Copyright © 2020 Naga Malleswari <nagamalli@riseup.net>
+;;; Copyright © 2020 Vinicius Monego <monego@posteo.net>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -10216,3 +10217,34 @@ communicating using the GVariant serialization format instead of JSON when
both peers support it. You might want that when communicating on a single
host to avoid parser overhead and memory-allocator fragmentation.")
(license license:lgpl2.1+)))
+
+(define-public glabels
+ (package
+ (name "glabels")
+ (version "3.4.1")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/" name "/"
+ (version-major+minor version) "/"
+ "glabels-" version ".tar.xz"))
+ (sha256
+ (base32 "0f2rki8i27pkd9r0gz03cdl1g4vnmvp0j49nhxqn275vi8lmgr0q"))))
+ (build-system glib-or-gtk-build-system)
+ (native-inputs
+ `(("gettext" ,gettext-minimal)
+ ("glib:bin" ,glib "bin")
+ ("intltool" ,intltool)
+ ("itstool" ,itstool)
+ ("pkg-config" ,pkg-config)))
+ (inputs
+ `(("gtk+" ,gtk+)
+ ("librsvg" ,librsvg)
+ ("libxml2" ,libxml2)))
+ (home-page "https://glabels.org/")
+ (synopsis "Program for creating labels and business cards")
+ (description
+ "gLabels is a program for creating labels and business cards. It is
+designed to work with various laser/ink-jet peel-off label and business
+card sheets that you’ll find at most office supply stores.")
+ (license license:gpl3+)))
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#41430: [PATCH v2] gnu: Add glabels.
2020-05-21 3:02 ` [bug#41430] [PATCH v2] gnu: Add glabels Vinicius Monego
@ 2020-05-22 15:45 ` Nicolas Goaziou
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2020-05-22 15:45 UTC (permalink / raw)
To: Vinicius Monego; +Cc: 41430-done
Hello,
Vinicius Monego <monego@posteo.net> writes:
> * gnu/packages/gnome.scm (glabels): New variable.
Applied. Thank you!
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-22 15:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-18 21:11 [bug#41380] [PATCH] gnu: add glabels Vinicius Monego
2020-05-20 18:07 ` Nicolas Goaziou
2020-05-21 3:02 ` [bug#41430] [PATCH v2] gnu: Add glabels Vinicius Monego
2020-05-22 15:45 ` bug#41430: " Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).