From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Tanguy Le Carrour <tanguy@bioneland.org>
Cc: 44077@debbugs.gnu.org
Subject: [bug#44077] [PATCH 1/2] gnu: Add python-poetry-core.
Date: Tue, 20 Oct 2020 13:51:40 +0200 [thread overview]
Message-ID: <87zh4h6roz.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20201019132912.13941-1-tanguy@bioneland.org> (Tanguy Le Carrour's message of "Mon, 19 Oct 2020 15:29:11 +0200")
Hello,
Tanguy Le Carrour <tanguy@bioneland.org> writes:
> * gnu/packages/python-xyz.scm (python-poetry-core): New variable.
Thank you.
> +(define-public python-poetry-core
> + (package
> + (name "python-poetry-core")
> + (version "1.0.0")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "poetry-core" version))
> + (sha256
> + (base32
> + "1mgv276h1iphn5fqhp2sgkgd5d0c39hs33vgaf157x5ri7rlyrka"))))
Nitpick: move the string on the same line as `base32'.
> + (build-system python-build-system)
> + (home-page "https://github.com/python-poetry/poetry-core")
> + (synopsis "Poetry PEP 517 Build Backend")
Nitpick: I would avoid unnecessary capitalization:
Poetry PEP 517 build back-end
> + (description
> + "A PEP 517 build backend implementation developed for Poetry. This project
> +is intended to be a light weight, fully compliant, self-contained package allowing
> +PEP 517 compatible build frontends to build Poetry managed projects.")
The first sentence should be complete, i.e., with a subject and a verb.
Otherwise, LGTM.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-10-20 11:52 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 13:26 [bug#44077] [PATCH 0/2] gnu: poetry: Update to 1.1.3 Tanguy Le Carrour
2020-10-19 13:29 ` [bug#44077] [PATCH 1/2] gnu: Add python-poetry-core Tanguy Le Carrour
2020-10-19 13:29 ` [bug#44077] [PATCH 2/2] gnu: poetry: Update to 1.1.3 Tanguy Le Carrour
2020-10-20 11:55 ` Nicolas Goaziou
2020-10-20 15:32 ` Tanguy Le Carrour
2020-10-20 11:51 ` Nicolas Goaziou [this message]
2020-10-20 15:30 ` [bug#44077] [PATCH 1/2] gnu: Add python-poetry-core Tanguy Le Carrour
2020-10-21 19:46 ` Nicolas Goaziou
2020-10-22 7:22 ` Tanguy Le Carrour
2020-10-20 15:39 ` [bug#44077] [PATCH v2 " Tanguy Le Carrour
2020-10-20 15:39 ` [bug#44077] [PATCH v2 2/2] gnu: poetry: Update to 1.1.3 Tanguy Le Carrour
2020-10-22 7:20 ` [bug#44077] [PATCH v3 1/2] gnu: Add python-poetry-core Tanguy Le Carrour
2020-10-22 7:20 ` [bug#44077] [PATCH v3 2/2] gnu: poetry: Update to 1.1.3 Tanguy Le Carrour
2020-10-23 6:54 ` [bug#44077] [WIP][PATCH 0/2] " Tanguy Le Carrour
2020-10-30 18:17 ` [bug#44077] [PATCH v2 0/7] gnu: poetry: Update to 1.1.4 Tanguy Le Carrour
2020-10-30 18:17 ` [bug#44077] [PATCH v2 1/7] gnu: python-packaging: Update to 20.4 Tanguy Le Carrour
2020-10-30 18:17 ` [bug#44077] [PATCH v2 2/7] gnu: python-virtualenv: Update to 20.1.0 Tanguy Le Carrour
2020-10-30 18:17 ` [bug#44077] [PATCH v2 3/7] gnu: python-distlib: Update to 0.3.1 Tanguy Le Carrour
2020-10-30 18:17 ` [bug#44077] [PATCH v2 4/7] gnu: python-pip: Update to 20.2.4 Tanguy Le Carrour
2020-10-30 18:17 ` [bug#44077] [PATCH v2 5/7] gnu: python-tomlkit: Update to 0.7.0 Tanguy Le Carrour
2020-10-30 18:17 ` [bug#44077] [PATCH v2 6/7] gnu: Add python-poetry-core Tanguy Le Carrour
2020-10-30 18:17 ` [bug#44077] [PATCH v2 7/7] gnu: poetry: Update to 1.1.4 Tanguy Le Carrour
2020-11-26 13:36 ` [bug#44077] " Tanguy Le Carrour
2020-11-27 20:14 ` Nicolas Goaziou
2020-11-28 14:11 ` Tanguy LE CARROUR
2020-11-28 15:41 ` Nicolas Goaziou
2020-11-29 17:56 ` Tanguy LE CARROUR
2020-11-29 19:34 ` Tanguy LE CARROUR
2020-11-29 20:06 ` Marius Bakke
2020-11-30 8:27 ` Tanguy LE CARROUR
2020-12-03 21:39 ` Marius Bakke
2020-11-30 9:45 ` [bug#44077] [PATCH v4 1/7] gnu: python-packaging: Update to 20.4 Tanguy Le Carrour
2020-11-30 9:45 ` [bug#44077] [PATCH v4 2/7] gnu: Add python-distlib/next Tanguy Le Carrour
2020-11-30 9:45 ` [bug#44077] [PATCH v4 3/7] gnu: python-virtualenv: Update to 20.2.1 Tanguy Le Carrour
2020-11-30 9:45 ` [bug#44077] [PATCH v4 4/7] gnu: python-pip: Update to 20.2.4 Tanguy Le Carrour
2020-11-30 9:45 ` [bug#44077] [PATCH v4 5/7] gnu: python-tomlkit: Update to 0.7.0 Tanguy Le Carrour
2020-11-30 9:45 ` [bug#44077] [PATCH v4 6/7] gnu: Add python-poetry-core Tanguy Le Carrour
2020-11-30 9:45 ` [bug#44077] [PATCH v4 7/7] gnu: poetry: Update to 1.1.4 Tanguy Le Carrour
2020-11-30 9:48 ` [bug#44077] [PATCH v5 1/7] gnu: python-packaging: Update to 20.4 Tanguy Le Carrour
2020-11-30 9:48 ` [bug#44077] [PATCH v5 2/7] gnu: Add python-distlib/next Tanguy Le Carrour
2020-11-30 9:48 ` [bug#44077] [PATCH v5 3/7] gnu: python-virtualenv: Update to 20.2.1 Tanguy Le Carrour
2020-11-30 9:49 ` [bug#44077] [PATCH v5 4/7] gnu: python-pip: Update to 20.2.4 Tanguy Le Carrour
2020-11-30 9:49 ` [bug#44077] [PATCH v5 5/7] gnu: python-tomlkit: Update to 0.7.0 Tanguy Le Carrour
2020-11-30 9:49 ` [bug#44077] [PATCH v5 6/7] gnu: Add python-poetry-core Tanguy Le Carrour
2020-11-30 9:49 ` [bug#44077] [PATCH v5 7/7] gnu: poetry: Update to 1.1.4 Tanguy Le Carrour
2020-11-30 21:42 ` bug#44077: " Nicolas Goaziou
2020-12-01 7:03 ` [bug#44077] " Tanguy LE CARROUR
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh4h6roz.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=44077@debbugs.gnu.org \
--cc=tanguy@bioneland.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).