From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GEM9IWrPjl+JYwAA0tVLHw (envelope-from ) for ; Tue, 20 Oct 2020 11:52:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cJRMHWrPjl/sFgAA1q6Kng (envelope-from ) for ; Tue, 20 Oct 2020 11:52:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EF96C940215 for ; Tue, 20 Oct 2020 11:52:09 +0000 (UTC) Received: from localhost ([::1]:57626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUqBU-0002oa-DT for larch@yhetil.org; Tue, 20 Oct 2020 07:52:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUqBO-0002n0-4g for guix-patches@gnu.org; Tue, 20 Oct 2020 07:52:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60506) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUqBN-0004jv-Rb for guix-patches@gnu.org; Tue, 20 Oct 2020 07:52:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUqBN-0004sm-Q4 for guix-patches@gnu.org; Tue, 20 Oct 2020 07:52:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44077] [PATCH 1/2] gnu: Add python-poetry-core. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 20 Oct 2020 11:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44077 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tanguy Le Carrour Cc: 44077@debbugs.gnu.org Received: via spool by 44077-submit@debbugs.gnu.org id=B44077.160319471018748 (code B ref 44077); Tue, 20 Oct 2020 11:52:01 +0000 Received: (at 44077) by debbugs.gnu.org; 20 Oct 2020 11:51:50 +0000 Received: from localhost ([127.0.0.1]:43819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUqBC-0004sK-85 for submit@debbugs.gnu.org; Tue, 20 Oct 2020 07:51:50 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:57885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUqBA-0004s4-96 for 44077@debbugs.gnu.org; Tue, 20 Oct 2020 07:51:49 -0400 X-Originating-IP: 176.137.73.130 Received: from localhost (chr13-h03-176-137-73-130.dsl.sta.abo.bbox.fr [176.137.73.130]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 205D440002; Tue, 20 Oct 2020 11:51:40 +0000 (UTC) From: Nicolas Goaziou References: <20201019132649.13548-1-tanguy@bioneland.org> <20201019132912.13941-1-tanguy@bioneland.org> Date: Tue, 20 Oct 2020 13:51:40 +0200 In-Reply-To: <20201019132912.13941-1-tanguy@bioneland.org> (Tanguy Le Carrour's message of "Mon, 19 Oct 2020 15:29:11 +0200") Message-ID: <87zh4h6roz.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: u+ny9pD89xT6 Hello, Tanguy Le Carrour writes: > * gnu/packages/python-xyz.scm (python-poetry-core): New variable. Thank you. > +(define-public python-poetry-core > + (package > + (name "python-poetry-core") > + (version "1.0.0") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "poetry-core" version)) > + (sha256 > + (base32 > + "1mgv276h1iphn5fqhp2sgkgd5d0c39hs33vgaf157x5ri7rlyrka")))) Nitpick: move the string on the same line as `base32'. > + (build-system python-build-system) > + (home-page "https://github.com/python-poetry/poetry-core") > + (synopsis "Poetry PEP 517 Build Backend") Nitpick: I would avoid unnecessary capitalization: Poetry PEP 517 build back-end > + (description > + "A PEP 517 build backend implementation developed for Poetry. This project > +is intended to be a light weight, fully compliant, self-contained package allowing > +PEP 517 compatible build frontends to build Poetry managed projects.") The first sentence should be complete, i.e., with a subject and a verb. Otherwise, LGTM. Regards, -- Nicolas Goaziou