unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: John Soo <jsoo1@asu.edu>
Cc: 45050@debbugs.gnu.org
Subject: [bug#45050] [PATCH] gnu: Update emacs-guix to temporary repository.
Date: Fri, 11 Dec 2020 18:47:49 +0100	[thread overview]
Message-ID: <87zh2k44l6.fsf@gnu.org> (raw)
In-Reply-To: <87r1o4lte7.fsf@asu.edu> (John Soo's message of "Fri, 04 Dec 2020 21:21:52 -0800")

Hi!

John Soo <jsoo1@asu.edu> skribis:

>>From 28abdd7140c31425f6add54470ad683bc46e8de7 Mon Sep 17 00:00:00 2001
> From: John Soo <jsoo1@asu.edu>
> Date: Thu, 12 Nov 2020 23:04:27 -0800
> Subject: [PATCH] gnu: Update emacs-guix.
>
> * gnu/packages/emacs-xyz.scm (emacs-guix): Update it, [inputs] Use guile for
> guix.

If it fixes one of the bugs in the tracker, we can mention it in the
commit log with “Fixes <https://bugs.gnu.org/XYZ>.”

>  (define-public emacs-guix
> -  (let ((commit "58a840d0671091e3064e36244790ef8839da87d6")
> -        (revision "2"))
> +  (let* ((commit "a694fdbcedb6edd2239a31d326e475c763ee32f8")
> +         (revision "1"))

Please increment the revision number rather than decrement it.

>      (package
> -      (name "emacs-guix")
> -      (version (git-version "0.5.2" revision commit))

Please don’t reindent, the original formatting was fine.  :-)

Could you send an updated patch?

I guess it’s fine to use your repo until we hear from Alex Kost.

Thanks for taking care of this!

Ludo’.




  parent reply	other threads:[~2020-12-11 18:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-05  5:21 [bug#45050] [PATCH] gnu: Update emacs-guix to temporary repository John Soo
2020-12-05  5:24 ` [bug#45050] Oops! John Soo
2020-12-07 16:01 ` [bug#45050] [PATCH] gnu: Update emacs-guix to temporary repository zimoun
2020-12-07 16:15   ` John Soo
2020-12-07 16:55     ` zimoun
2020-12-11 17:47 ` Ludovic Courtès [this message]
2020-12-11 20:27   ` John Soo
2020-12-12 17:40     ` bug#45050: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zh2k44l6.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=45050@debbugs.gnu.org \
    --cc=jsoo1@asu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).