From: John Soo <jsoo1@asu.edu>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 45050@debbugs.gnu.org
Subject: [bug#45050] [PATCH] gnu: Update emacs-guix to temporary repository.
Date: Fri, 11 Dec 2020 12:27:51 -0800 [thread overview]
Message-ID: <87tussw0jc.fsf@asu.edu> (raw)
In-Reply-To: <87zh2k44l6.fsf@gnu.org> ("Ludovic Courtès"'s message of "Fri, 11 Dec 2020 18:47:49 +0100")
[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]
Hello!
Ludovic Courtès <ludo@gnu.org> writes:
>> * gnu/packages/emacs-xyz.scm (emacs-guix): Update it, [inputs] Use guile for
>> guix.
>
> If it fixes one of the bugs in the tracker, we can mention it in the
> commit log with “Fixes <https://bugs.gnu.org/XYZ>.”
Alright, done.
>> (define-public emacs-guix
>> - (let ((commit "58a840d0671091e3064e36244790ef8839da87d6")
>> - (revision "2"))
>> + (let* ((commit "a694fdbcedb6edd2239a31d326e475c763ee32f8")
>> + (revision "1"))
>
> Please increment the revision number rather than decrement it.
Ah yes, sorry I thought it would be the "revision at commit". I bumped
it to rev 3.
>> (package
>> - (name "emacs-guix")
>> - (version (git-version "0.5.2" revision commit))
>
> Please don’t reindent, the original formatting was fine. :-)
Oh oops, sorry. I think I forgot to reindent after a previous revision.
> I guess it’s fine to use your repo until we hear from Alex Kost.
Hopefully soon :)
Thanks for your review,
John
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Update-emacs-guix.patch --]
[-- Type: text/x-patch, Size: 2099 bytes --]
From 4fd99ba6fa6ef61e1077f1fcad6b5d56bbbbf69a Mon Sep 17 00:00:00 2001
From: John Soo <jsoo1@asu.edu>
Date: Thu, 12 Nov 2020 23:04:27 -0800
Subject: [PATCH] gnu: Update emacs-guix.
* gnu/packages/emacs-xyz.scm (emacs-guix): Update it, [inputs] Use guile for
guix.
* Fixes https://bugs.gnu.org/44062
---
gnu/packages/emacs-xyz.scm | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ceb99f402d..5798af80d6 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -2795,20 +2795,21 @@ type, for example: packages, buffers, files, etc.")
(license license:gpl3+)))
(define-public emacs-guix
- (let ((commit "58a840d0671091e3064e36244790ef8839da87d6")
- (revision "2"))
+ (let* ((commit "a694fdbcedb6edd2239a31d326e475c763ee32f8")
+ (revision "3"))
(package
(name "emacs-guix")
(version (git-version "0.5.2" revision commit))
(source (origin
(method git-fetch)
(uri (git-reference
- (url "https://gitlab.com/emacs-guix/emacs-guix")
+ ;; TODO: Use the official version when it has a new home
+ (url "https://github.com/jsoo1/guix.el")
(commit commit)))
(file-name (git-file-name name version))
(sha256
(base32
- "1qnr5sixmvrhr9rinrhfy7sy20mikjvvwbdixwkbx30qpcdwgwj1"))))
+ "1pqw7zbgxzwpig4xr0izc3z8h80c72i6bl5yi12br0d7aq6dbkvj"))))
(build-system gnu-build-system)
(native-inputs
`(("autoconf" ,autoconf)
@@ -2817,7 +2818,8 @@ type, for example: packages, buffers, files, etc.")
("texinfo" ,texinfo)
("emacs" ,emacs-minimal)))
(inputs
- `(("guile" ,@(assoc-ref (package-native-inputs guix) "guile"))
+ `(("guile"
+ ,@(assoc-ref (package-native-inputs guix) "guile"))
("guix" ,guix)))
(propagated-inputs
`(("geiser" ,emacs-geiser)
--
2.29.2
next prev parent reply other threads:[~2020-12-11 20:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-05 5:21 [bug#45050] [PATCH] gnu: Update emacs-guix to temporary repository John Soo
2020-12-05 5:24 ` [bug#45050] Oops! John Soo
2020-12-07 16:01 ` [bug#45050] [PATCH] gnu: Update emacs-guix to temporary repository zimoun
2020-12-07 16:15 ` John Soo
2020-12-07 16:55 ` zimoun
2020-12-11 17:47 ` Ludovic Courtès
2020-12-11 20:27 ` John Soo [this message]
2020-12-12 17:40 ` bug#45050: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tussw0jc.fsf@asu.edu \
--to=jsoo1@asu.edu \
--cc=45050@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).