unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 43946@debbugs.gnu.org
Subject: [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section.
Date: Fri, 15 Jan 2021 14:30:47 +0100	[thread overview]
Message-ID: <87zh1axr7c.fsf@gnu.org> (raw)
In-Reply-To: <20201012082003.19936-1-zimon.toutoune@gmail.com> (zimoun's message of "Mon, 12 Oct 2020 10:20:03 +0200")

Hi Simon!

zimoun <zimon.toutoune@gmail.com> skribis:

> * doc/contributing.texi (Submitting Patches): Add item about 'git-format-patch
> --base'.
> ---
>  doc/contributing.texi | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/doc/contributing.texi b/doc/contributing.texi
> index af3601442e..5ea3cb1899 100644
> --- a/doc/contributing.texi
> +++ b/doc/contributing.texi
> @@ -932,6 +932,12 @@ Before submitting a patch that adds or modifies a package definition,
>  please run through this check list:
>  
>  @enumerate
> +@cindex @code{git format-patch}
> +@cindex @code{git-format-patch}
> +@item
> +We recommend to use the command @code{git format-patch --base} to
> +include the commit where your patch applies.

I’m not entirely convinced TBH, in part because I know I often pile a
couple of WIP branches on top of one another, “knowing what I’m doing”
(actually hoping that I do), and so the base commit would be useless in
this case.

Closing?  :-)

Thanks,
Ludo’.




  parent reply	other threads:[~2021-01-15 14:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-12  8:20 [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section zimoun
2020-10-24  9:01 ` bug#43946: " Oleg Pykhalov
2020-10-24  9:17   ` [bug#43946] " zimoun
2021-01-15 13:30 ` Ludovic Courtès [this message]
2021-01-15 14:00   ` zimoun
2021-03-26  5:40     ` zimoun
2021-09-21  9:53   ` zimoun
2021-09-22 13:02     ` bug#43946: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zh1axr7c.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=43946@debbugs.gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).