From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YAfHNWWmAWAYQwAA0tVLHw (envelope-from ) for ; Fri, 15 Jan 2021 14:27:49 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id QFKHMWWmAWAjRgAAB5/wlQ (envelope-from ) for ; Fri, 15 Jan 2021 14:27:49 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5984E9403EB for ; Fri, 15 Jan 2021 14:27:49 +0000 (UTC) Received: from localhost ([::1]:53758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0Q4q-0008Ps-7a for larch@yhetil.org; Fri, 15 Jan 2021 09:27:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0PBu-0006y0-Rd for guix-patches@gnu.org; Fri, 15 Jan 2021 08:31:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:56828) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0PBu-000705-Hk for guix-patches@gnu.org; Fri, 15 Jan 2021 08:31:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l0PBu-0001VO-Eq for guix-patches@gnu.org; Fri, 15 Jan 2021 08:31:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 15 Jan 2021 13:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43946 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Received: via spool by 43946-submit@debbugs.gnu.org id=B43946.16107174565773 (code B ref 43946); Fri, 15 Jan 2021 13:31:02 +0000 Received: (at 43946) by debbugs.gnu.org; 15 Jan 2021 13:30:56 +0000 Received: from localhost ([127.0.0.1]:40141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0PBo-0001V3-7R for submit@debbugs.gnu.org; Fri, 15 Jan 2021 08:30:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0PBm-0001Um-R9 for 43946@debbugs.gnu.org; Fri, 15 Jan 2021 08:30:55 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57464) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0PBg-0006uL-Jh; Fri, 15 Jan 2021 08:30:48 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=39224 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l0PBg-0004eM-7e; Fri, 15 Jan 2021 08:30:48 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201012082003.19936-1-zimon.toutoune@gmail.com> Date: Fri, 15 Jan 2021 14:30:47 +0100 In-Reply-To: <20201012082003.19936-1-zimon.toutoune@gmail.com> (zimoun's message of "Mon, 12 Oct 2020 10:20:03 +0200") Message-ID: <87zh1axr7c.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 43946@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.86 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5984E9403EB X-Spam-Score: -2.86 X-Migadu-Scanner: scn1.migadu.com X-TUID: BIMbjEueacvT Hi Simon! zimoun skribis: > * doc/contributing.texi (Submitting Patches): Add item about 'git-format-= patch > --base'. > --- > doc/contributing.texi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/doc/contributing.texi b/doc/contributing.texi > index af3601442e..5ea3cb1899 100644 > --- a/doc/contributing.texi > +++ b/doc/contributing.texi > @@ -932,6 +932,12 @@ Before submitting a patch that adds or modifies a pa= ckage definition, > please run through this check list: >=20=20 > @enumerate > +@cindex @code{git format-patch} > +@cindex @code{git-format-patch} > +@item > +We recommend to use the command @code{git format-patch --base} to > +include the commit where your patch applies. I=E2=80=99m not entirely convinced TBH, in part because I know I often pile= a couple of WIP branches on top of one another, =E2=80=9Cknowing what I=E2=80= =99m doing=E2=80=9D (actually hoping that I do), and so the base commit would be useless in this case. Closing? :-) Thanks, Ludo=E2=80=99.