unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#47659] [PATCH] gnu: guile-cv: Use guile2.2 version of guile-lib.
@ 2021-04-08 17:25 Masaya Tojo
  2021-04-08 20:05 ` Maxime Devos
  2021-04-09 15:28 ` bug#47659: " Ludovic Courtès
  0 siblings, 2 replies; 4+ messages in thread
From: Masaya Tojo @ 2021-04-08 17:25 UTC (permalink / raw)
  To: 47659; +Cc: Masaya Tojo

* gnu/packages/guile-xyz.scm (guile-cv)[propagated-inputs]: Change from
guile-lib to guile2.2-lib.
---
 gnu/packages/guile-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index e2ee5454a0..75256e0f11 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -28,7 +28,7 @@
 ;;; Copyright © 2020 Jack Hill <jackhill@jackhill.us>
 ;;; Copyright © 2020 Julien Lepiler <julien@lepiller.eu>
 ;;; Copyright © 2020 Marius Bakke <marius@gnu.org>
-;;; Copyright © 2020 Masaya Tojo <masaya@tojo.tokyo>
+;;; Copyright © 2020, 2021 Masaya Tojo <masaya@tojo.tokyo>
 ;;; Copyright © 2020 Jesse Gibbons <jgibbons2357@gmail.com>
 ;;; Copyright © 2020 Mike Rosset <mike.rosset@gmail.com>
 ;;; Copyright © 2020 Leo Prikler <leo.prikler@student.tugraz.at>
@@ -3519,7 +3519,7 @@ feature-set, fully programmable in Guile Scheme.")
                                         texlive-fonts-iwona)))
        ("pkg-config" ,pkg-config)))
     (propagated-inputs
-     `(("guile-lib" ,guile-lib)))
+     `(("guile-lib" ,guile2.2-lib)))
     (home-page "https://www.gnu.org/software/guile-cv/")
     (synopsis "Computer vision library for Guile")
     (description "Guile-CV is a Computer Vision functional programming library
-- 
2.31.1





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#47659] [PATCH] gnu: guile-cv: Use guile2.2 version of guile-lib.
  2021-04-08 17:25 [bug#47659] [PATCH] gnu: guile-cv: Use guile2.2 version of guile-lib Masaya Tojo
@ 2021-04-08 20:05 ` Maxime Devos
  2021-04-09 14:36   ` Masaya Tojo
  2021-04-09 15:28 ` bug#47659: " Ludovic Courtès
  1 sibling, 1 reply; 4+ messages in thread
From: Maxime Devos @ 2021-04-08 20:05 UTC (permalink / raw)
  To: Masaya Tojo, 47659

[-- Attachment #1: Type: text/plain, Size: 767 bytes --]

On Fri, 2021-04-09 at 02:25 +0900, Masaya Tojo wrote:
> * gnu/packages/guile-xyz.scm (guile-cv)[propagated-inputs]: Change from
> guile-lib to guile2.2-lib.

I believe the current naming convention for guile packages is:

* guile1.8-PACKAGE: for guile@1.8
* guile2.0-PACKAGE: for guile@2.0
* guile2.2-PACKAGE: for guile@2.2
* guile-PACKAGE: for guile@3.0

... though this is not always adhered to.  Basically, ‘we’ want to use
the latest version of guile by default.

So I would suggest:

A (preferred): replace guile-2.2 with guile-3.0 in 'inputs'.  But perhaps
  guile-cv does not (yet) support guile-3.0 (there have been a few incompatible
  2.2 -> 3.0 changes)
or
B: your patch, and rename guile-cv to guile2.2-cv.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#47659] [PATCH] gnu: guile-cv: Use guile2.2 version of guile-lib.
  2021-04-08 20:05 ` Maxime Devos
@ 2021-04-09 14:36   ` Masaya Tojo
  0 siblings, 0 replies; 4+ messages in thread
From: Masaya Tojo @ 2021-04-09 14:36 UTC (permalink / raw)
  To: Maxime Devos, 47659

Hello,

> A (preferred): replace guile-2.2 with guile-3.0 in 'inputs'.  But perhaps
>   guile-cv does not (yet) support guile-3.0 (there have been a few incompatible
>   2.2 -> 3.0 changes)
> or
> B: your patch, and rename guile-cv to guile2.2-cv.

I tested to build guile-cv with guile-3.0.  But guile-cv's test is
failed, so your suggesion A is not easy.

Therefore, I think suggesion B is better.

Best Regards,

--
Masaya Tojo




^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#47659: [PATCH] gnu: guile-cv: Use guile2.2 version of guile-lib.
  2021-04-08 17:25 [bug#47659] [PATCH] gnu: guile-cv: Use guile2.2 version of guile-lib Masaya Tojo
  2021-04-08 20:05 ` Maxime Devos
@ 2021-04-09 15:28 ` Ludovic Courtès
  1 sibling, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2021-04-09 15:28 UTC (permalink / raw)
  To: Masaya Tojo; +Cc: Maxime Devos, 47659-done

Hi,

Masaya Tojo <masaya@tojo.tokyo> skribis:

> * gnu/packages/guile-xyz.scm (guile-cv)[propagated-inputs]: Change from
> guile-lib to guile2.2-lib.

I agree with Maxime that Guile 3.0 would be best, but in the meantime,
your patch looks like the right thing.

Applied, thanks!

Ludo’.




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-04-09 15:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 17:25 [bug#47659] [PATCH] gnu: guile-cv: Use guile2.2 version of guile-lib Masaya Tojo
2021-04-08 20:05 ` Maxime Devos
2021-04-09 14:36   ` Masaya Tojo
2021-04-09 15:28 ` bug#47659: " Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).