From: "Ludovic Courtès" <ludo@gnu.org>
To: Andy Tai <atai@atai.org>
Cc: 64261@debbugs.gnu.org
Subject: [bug#64261] [PATCH] gnu: Add xrdp
Date: Tue, 11 Jul 2023 16:12:00 +0200 [thread overview]
Message-ID: <87zg4235cf.fsf_-_@gnu.org> (raw)
In-Reply-To: <eb07db4c5ce6ee7d09cff956448209990ab1038d.1687850929.git.atai@atai.org> (Andy Tai's message of "Tue, 27 Jun 2023 00:29:39 -0700")
Hi Andy,
Andy Tai <atai@atai.org> skribis:
> * gnu/packages/rdesktop.scm (xrdp): New variabble
> (xorgxrdp): New variable
Could you send a v2 with one patch per package, as is customary?
> + (home-page "https://www.xrdp.org")
> + (synopsis "Open source RDP server ")
Please remote the trailing slash as well as “open source”: everything is
free software in here, so no need to specify it! :-) However, please
spell out “Remote Desktop Protocol (RDP)”.
> + (description
> + "Xrdp provides a graphical login to remote machines using
> +Microsoft Remote Desktop Protocol (RDP). Xrdp accepts connections from a
> +variety of RDP clients:
> +* FreeRDP
> +* rdesktop
Please use @itemize.
See
<https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html>.
> +(define-public xorgxrdp
> + (package
> + (name "xorgxrdp")
> + (version "0.9.19")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/neutrinolabs/xorgxrdp/releases/download/v"
> + version "/xorgxrdp-" version ".tar.gz"))
> + (sha256
> + (base32
> + "0m8lvdnhfvwwqrr56difgy3mblplp23x6iy12kl4r8i87ic4rky1"))))
Should it inherit from ‘xrdp’? I fail to see what the difference is.
> + (arguments
> + (list #:configure-flags #~(list "--enable-strict-locations=yes"
> + (string-append "XRDP_CFLAGS=-I"
> + (assoc-ref %build-inputs
> + "xrdp")
> + "/common"))))
Rather than (assoc-ref …), write #$(this-package-input "xrdp').
Also, xrdp should not have .h files under /common; it should be under
/include or /include/common or similar. Could you check that?
> + (home-page "https://github.com/neutrinolabs/xorgxrdp")
> + (synopsis "Xorg drivers for xrdp")
> + (description
> + "xorgxrdp is a collection of modules to be used with a pre-existing X.Org
> +install to make the X server act like X11rdp")
Please add a period at the end of the sentence and expound a bit so one
can better understand what this is about.
Thanks in advance!
Ludo’.
next prev parent reply other threads:[~2023-07-11 14:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-24 7:37 [bug#64261] [PATCH] gnu: Add xrdp Andy Tai
2023-06-24 9:21 ` [bug#64261] [PATCH v2] " Andy Tai
2023-06-27 7:29 ` [bug#64261] [PATCH v3] gnu: Add xrdp and xorgxrdp Andy Tai
2023-07-11 14:12 ` Ludovic Courtès [this message]
2023-07-11 14:13 ` [bug#64261] [PATCH] gnu: Add xrdp Andy Tai
2023-07-22 23:28 ` [bug#64261] [PATCH v4 0/2] Add xrdp and xorgxrdp Andy Tai
2023-07-22 23:28 ` [bug#64261] [PATCH v4 1/2] gnu: Add xrdp Andy Tai
2023-07-22 23:28 ` [bug#64261] [PATCH v4 2/2] gnu: Add xorgxrdp Andy Tai
2023-07-26 5:56 ` [bug#64261] Guix QA showing failure on invalid derivation Andy Tai
2023-07-26 9:53 ` Christopher Baines
2023-07-29 3:53 ` [bug#64261] [PATCH v5 1/2] gnu: Add xrdp Andy Tai
2023-07-29 3:53 ` [bug#64261] [PATCH v5 2/2] gnu: Add xorgxrdp Andy Tai
2023-08-07 13:27 ` [bug#64261] [PATCH] gnu: Add xrdp Ludovic Courtès
2023-08-07 13:29 ` Andy Tai
2023-08-10 5:31 ` [bug#64261] [PATCH v6 1/2] " Andy Tai
2023-08-10 5:31 ` [bug#64261] [PATCH v6 2/2] gnu: Add xorgxrdp Andy Tai
2023-08-12 20:42 ` bug#64261: [PATCH v6 1/2] gnu: Add xrdp Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg4235cf.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=64261@debbugs.gnu.org \
--cc=atai@atai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).