From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id CBoUGuNqrWQ4fQAASxT56A (envelope-from ) for ; Tue, 11 Jul 2023 16:44:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id QNqzGONqrWSGYgEAG6o9tA (envelope-from ) for ; Tue, 11 Jul 2023 16:44:51 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 098BA41536 for ; Tue, 11 Jul 2023 16:44:51 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=pzPITbxI; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689086691; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=X6ttQ2nzxvJsdFjDAaFgJOXQrJPik7pB0z7YD7qnhcM=; b=C7irZ30rLoED3e8Vp68kXDyTyDPNFberUZIYkdNDBGt++75UMKu+dAZVf1fGkNFYCHc/MF fZwXXaU983EuUcAc/TcIaqilNpyGKnTqKvLQf04C7yk4hz8TCBEvljxBmtguUXKtAmK+R4 n8o54DQ5YVx5ro/rFnvQuhTQwi4/ao+syi7U4/FhLfZ59s4FqohfmwE6II7WRNmnt8+bch UuryJrQqbE3pa6011G6hbMCWoqkPJLdFCxNZtb6hNlL8R53DEV/RgtYq13Amm4+1j06Y0X Ow+WcBTOJNV7HfZawvfuS5+gmHQpIWOofolHjFJmiLkgIrier+jBSi0JEjZL6g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=pzPITbxI; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689086691; a=rsa-sha256; cv=none; b=AEGsW2aiXGGgQqFJ8ra3h/045BK+s6oSdtc4C/mrmEfnNrgfPkfFPw9Ms4ypm8uU36BoA7 X7yQ0OMGZWS8FJnY6G5M74vVRTvAo7q2D24W/v60meNOsqJjbHp3EVGzxg9MuowsVTL8NV m3ybCtRnp3LXmz2PtTi7Qf3ciKgOZaK6IfZZCfy38qqAs+pI737o/3fRCcy/GipflgJRrS rkQHhCTBVulg3cEN5zW0ieEUE4x5tvwxzqWyDaXrGQ93NzxNqKZcTmKNI4EMwgnJ/fXzom JrSHyWlDmUbPiTJMTLiOEDOuFt+0OpHxVU4+23+tWfygJW1R/Gbi9/fp1BRkQg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJE71-00018I-W2; Tue, 11 Jul 2023 10:13:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJE6y-00017U-H4 for guix-patches@gnu.org; Tue, 11 Jul 2023 10:13:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJE6w-0002rh-Lq for guix-patches@gnu.org; Tue, 11 Jul 2023 10:13:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qJE6w-0006E5-7g for guix-patches@gnu.org; Tue, 11 Jul 2023 10:13:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64261] [PATCH] gnu: Add xrdp Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 11 Jul 2023 14:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64261 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andy Tai Cc: 64261@debbugs.gnu.org Received: via spool by 64261-submit@debbugs.gnu.org id=B64261.168908473623837 (code B ref 64261); Tue, 11 Jul 2023 14:13:02 +0000 Received: (at 64261) by debbugs.gnu.org; 11 Jul 2023 14:12:16 +0000 Received: from localhost ([127.0.0.1]:50845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJE6B-0006CP-JR for submit@debbugs.gnu.org; Tue, 11 Jul 2023 10:12:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJE66-0006C4-G1 for 64261@debbugs.gnu.org; Tue, 11 Jul 2023 10:12:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJE5z-0002TK-BN; Tue, 11 Jul 2023 10:12:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=X6ttQ2nzxvJsdFjDAaFgJOXQrJPik7pB0z7YD7qnhcM=; b=pzPITbxIphLlGWssbMyT SFn3Zvd1klAqUg6w2N3JdbIgCJt+uShn8DXP2skbe7oYu3j24fBimLrqYghNIIDPwmLozHSB3ajIx ILaviWPrzckahlodlu1lJRMNqdF3dmJReXz0FGr46/lWRIvMVfeGGuLepRr5p8IGPaYI8PB4Upk51 sDRHg/EPh00urSuAScR1WWsgF9QO/EgVrpACB/sNJCsepQK8vTupHbpydPEKU+b3prl69iFb/DLwx Rj1Nzj+m8y1Nw7/fD9Gcd5/Vq7vWZ+foB4VVpFZC5fQ8mkKFWwz1IwQvdEzeubjw1ZpH6cAPi8s4D XTzeVy67CnCVhQ==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJE5y-00029p-Sk; Tue, 11 Jul 2023 10:12:03 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <6175dfd2c421fadf757a66ebd96ed1085c168c6b.1687592180.git.atai@atai.org> Date: Tue, 11 Jul 2023 16:12:00 +0200 In-Reply-To: (Andy Tai's message of "Tue, 27 Jun 2023 00:29:39 -0700") Message-ID: <87zg4235cf.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -7.20 X-Spam-Score: -7.20 X-Migadu-Queue-Id: 098BA41536 X-Migadu-Scanner: mx1.migadu.com X-TUID: 55zUuZhitpaT Hi Andy, Andy Tai skribis: > * gnu/packages/rdesktop.scm (xrdp): New variabble > (xorgxrdp): New variable Could you send a v2 with one patch per package, as is customary? > + (home-page "https://www.xrdp.org") > + (synopsis "Open source RDP server ") Please remote the trailing slash as well as =E2=80=9Copen source=E2=80=9D: = everything is free software in here, so no need to specify it! :-) However, please spell out =E2=80=9CRemote Desktop Protocol (RDP)=E2=80=9D. > + (description > + "Xrdp provides a graphical login to remote machines using > +Microsoft Remote Desktop Protocol (RDP). Xrdp accepts connections from a > +variety of RDP clients: > +* FreeRDP > +* rdesktop Please use @itemize. See . > +(define-public xorgxrdp > + (package > + (name "xorgxrdp") > + (version "0.9.19") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "https://github.com/neutrinolabs/xorgxrdp/releases/d= ownload/v" > + version "/xorgxrdp-" version ".tar.gz")) > + (sha256 > + (base32 > + "0m8lvdnhfvwwqrr56difgy3mblplp23x6iy12kl4r8i87ic4rky1"))= )) Should it inherit from =E2=80=98xrdp=E2=80=99? I fail to see what the diff= erence is. > + (arguments > + (list #:configure-flags #~(list "--enable-strict-locations=3Dyes" > + (string-append "XRDP_CFLAGS=3D-I" > + (assoc-ref %build-in= puts > + "xrdp") > + "/common")))) Rather than (assoc-ref =E2=80=A6), write #$(this-package-input "xrdp'). Also, xrdp should not have .h files under /common; it should be under /include or /include/common or similar. Could you check that? > + (home-page "https://github.com/neutrinolabs/xorgxrdp") > + (synopsis "Xorg drivers for xrdp") > + (description > + "xorgxrdp is a collection of modules to be used with a pre-existing= X.Org > +install to make the X server act like X11rdp") Please add a period at the end of the sentence and expound a bit so one can better understand what this is about. Thanks in advance! Ludo=E2=80=99.