From: ludo@gnu.org (Ludovic Courtès)
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 27596@debbugs.gnu.org
Subject: [bug#27596] [PATCH] guix: lint: Add checker for new upstream versions.
Date: Tue, 22 Aug 2017 15:17:58 +0200 [thread overview]
Message-ID: <87y3qb4u7t.fsf@gnu.org> (raw)
In-Reply-To: <20170801112046.GG2406@macbook42.flashner.co.il> (Efraim Flashner's message of "Tue, 1 Aug 2017 14:20:46 +0300")
Hi Efraim,
Sorry for the delay.
Efraim Flashner <efraim@flashner.co.il> skribis:
> From 136841864c883338381764ef09a6f4ec967949e7 Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@flashner.co.il>
> Date: Thu, 6 Jul 2017 09:13:31 +0300
> Subject: [PATCH] guix: lint: Add checker for new upstream versions.
>
> * guix/scripts/lint.scm (check-for-updates): New procedure.
> (%checkers): Add it.
> * guix/scripts/refresh.scm (importer-modules, %updaters): Move
> from here ...
> * guix/upstream.scm: ... to here.
[...]
> +(define (check-for-updates package)
> + "Check if there is an update available for PACKAGE."
> + (match (package-latest-release package (force %updaters))
> + ((? upstream-source? source)
> + (when (version>? (upstream-source-version source)
> + (package-version package))
> + (emit-warning package
> + (format #f (G_ "can be upgraded to ~a~%")
> + (upstream-source-version source)))))))
I think you can (1) use ‘package-latest-release*’ which ensures that the
returned version is newer, and (2) add a case for #f since
‘package-latest-release*’ can return #f.
Apart from that it LGTM, thank you!
Ludo’.
next prev parent reply other threads:[~2017-08-22 13:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 10:17 [bug#27596] [PATCH] guix: lint: Add checker for new upstream versions Efraim Flashner
2017-07-06 14:35 ` Ludovic Courtès
2017-08-01 11:20 ` Efraim Flashner
2017-08-22 13:17 ` Ludovic Courtès [this message]
2017-10-07 20:50 ` Ludovic Courtès
2017-10-08 19:49 ` Efraim Flashner
2017-10-09 7:28 ` Ludovic Courtès
2017-10-09 11:17 ` bug#27596: " Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3qb4u7t.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=27596@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).