From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49804)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dk95G-0002w1-RN
	for guix-patches@gnu.org; Tue, 22 Aug 2017 09:19:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dk95C-00065i-Qo
	for guix-patches@gnu.org; Tue, 22 Aug 2017 09:19:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:40123)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dk95C-000657-Mp
	for guix-patches@gnu.org; Tue, 22 Aug 2017 09:19:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dk95C-0003XV-F7
	for guix-patches@gnu.org; Tue, 22 Aug 2017 09:19:02 -0400
Subject: [bug#27596] [PATCH] guix: lint: Add checker for new upstream versions.
Resent-Message-ID: <handler.27596.B27596.150340789713553@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170706101723.3349-1-efraim@flashner.co.il>
	<87h8ypocp1.fsf@gnu.org>
	<20170801112046.GG2406@macbook42.flashner.co.il>
Date: Tue, 22 Aug 2017 15:17:58 +0200
In-Reply-To: <20170801112046.GG2406@macbook42.flashner.co.il> (Efraim
	Flashner's message of "Tue, 1 Aug 2017 14:20:46 +0300")
Message-ID: <87y3qb4u7t.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 27596@debbugs.gnu.org

Hi Efraim,

Sorry for the delay.

Efraim Flashner <efraim@flashner.co.il> skribis:

> From 136841864c883338381764ef09a6f4ec967949e7 Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@flashner.co.il>
> Date: Thu, 6 Jul 2017 09:13:31 +0300
> Subject: [PATCH] guix: lint: Add checker for new upstream versions.
>
> * guix/scripts/lint.scm (check-for-updates): New procedure.
> (%checkers): Add it.
> * guix/scripts/refresh.scm (importer-modules, %updaters): Move
> from here ...
> * guix/upstream.scm: ... to here.

[...]

> +(define (check-for-updates package)
> +  "Check if there is an update available for PACKAGE."
> +  (match (package-latest-release package (force %updaters))
> +    ((? upstream-source? source)
> +     (when (version>? (upstream-source-version source)
> +                      (package-version package))
> +       (emit-warning package
> +                     (format #f (G_ "can be upgraded to ~a~%")
> +                             (upstream-source-version source)))))))

I think you can (1) use =E2=80=98package-latest-release*=E2=80=99 which ens=
ures that the
returned version is newer, and (2) add a case for #f since
=E2=80=98package-latest-release*=E2=80=99 can return #f.

Apart from that it LGTM, thank you!

Ludo=E2=80=99.