From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 30201@debbugs.gnu.org
Subject: [bug#30201] [PATCH] Fix Solfege configuration skeleton
Date: Mon, 22 Jan 2018 00:06:28 +0100 [thread overview]
Message-ID: <87y3kqak23.fsf@nicolasgoaziou.fr> (raw)
[-- Attachment #1: Type: text/plain, Size: 915 bytes --]
Hello,
Currently, Guix Solfege package replaces, in the skeleton configuration,
hard-coded filenames to various sound players with hard-coded filenames
to the same players in the store. I think this is no good.
The first time it is run, Solfege copies the skeleton configuration in
home directory, as a dot file. However, at some point, possibly long
after you forget about this detail, initial inputs are GC'ed, leaving
non-existing filenames in a now broken configuration. Once you realize
it, you need to find the new inputs in the store, rinse and repeat.
One option would be to move players to propagated-inputs. Since they do
not prevent Solfege from building, however, I think simply removing them
from the package is enough. One can always add them to their profile if
needed.
The following patch implements this.
Regards,
--
Nicolas Goaziou 0x80A93738
[-- Attachment #2: Fix Solfege --]
[-- Type: text/x-diff, Size: 3037 bytes --]
From e30b919f03ad9b37123b96dc38c24d41e562a02a Mon Sep 17 00:00:00 2001
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date: Sun, 21 Jan 2018 23:43:02 +0100
Subject: [PATCH] gnu: solfege: Make configuration more robust to GC
* gnu/packages/music.scm (solfege): Do not introduce store filenames in the
configuration skeleton.
[inputs]: Remove optional players.
---
gnu/packages/music.scm | 30 ++++++------------------------
1 file changed, 6 insertions(+), 24 deletions(-)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index b7dc7d9aa..e618e2bf1 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -10,7 +10,7 @@
;;; Copyright © 2016 Alex Griffin <a@ajgrf.com>
;;; Copyright © 2017 ng0 <contact.ng0@cryptolab.net>
;;; Copyright © 2017 Rodger Fox <thylakoid@openmailbox.org>
-;;; Copyright © 2017 Nicolas Goaziou <mail@nicolasgoaziou.fr>
+;;; Copyright © 2017, 2018 Nicolas Goaziou <mail@nicolasgoaziou.fr>
;;; Copyright © 2017 Pierre Langlois <pierre.langlois@gmx.com>
;;; Copyright © 2017 Arun Isaac <arunisaac@systemreboot.net>
;;; Copyright © 2017, 2018 Tobias Geerinckx-Rice <me@tobias.gr>
@@ -1055,22 +1055,10 @@ complete studio.")
(add-after 'unpack 'fix-configuration
(lambda* (#:key inputs #:allow-other-keys)
(substitute* "default.config"
- (("csound=csound")
- (string-append "csound="
- (assoc-ref inputs "csound")
- "/bin/csound"))
- (("/usr/bin/aplay")
- (string-append (assoc-ref inputs "aplay")
- "/bin/aplay"))
- (("/usr/bin/timidity")
- (string-append (assoc-ref inputs "timidity")
- "/bin/timidity"))
- (("/usr/bin/mpg123")
- (string-append (assoc-ref inputs "mpg123")
- "/bin/mpg123"))
- (("/usr/bin/ogg123")
- (string-append (assoc-ref inputs "ogg123")
- "/bin/ogg123")))
+ (("/usr/bin/aplay" "aplay"))
+ (("/usr/bin/timidity") "timidity")
+ (("/usr/bin/mpg123") "mpg123")
+ (("/usr/bin/ogg123") "ogg123"))
#t))
(add-before 'build 'patch-python-shebangs
(lambda _
@@ -1110,13 +1098,7 @@ for path in [path for path in sys.path if 'site-packages' in path]: site.addsite
("pygtk" ,python2-pygtk)
("gettext" ,gettext-minimal)
("gtk" ,gtk+)
- ("lilypond" ,lilypond)
- ;; players needed at runtime
- ("aplay" ,alsa-utils)
- ("csound" ,csound) ; optional, needed for some exercises
- ("mpg123" ,mpg123)
- ("ogg123" ,vorbis-tools)
- ("timidity" ,timidity++)))
+ ("lilypond" ,lilypond)))
(native-inputs
`(("pkg-config" ,pkg-config)
("txt2man" ,txt2man)
--
2.15.1
next reply other threads:[~2018-01-21 23:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-21 23:06 Nicolas Goaziou [this message]
2018-01-31 22:55 ` [bug#30201] [PATCH] Fix Solfege configuration skeleton Ludovic Courtès
2018-02-01 21:39 ` bug#30201: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3kqak23.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=30201@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).