From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edOhe-0001Da-7R for guix-patches@gnu.org; Sun, 21 Jan 2018 18:07:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edOha-0007Z6-GY for guix-patches@gnu.org; Sun, 21 Jan 2018 18:07:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:57832) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1edOha-0007Yz-CD for guix-patches@gnu.org; Sun, 21 Jan 2018 18:07:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1edOha-0004EF-3P for guix-patches@gnu.org; Sun, 21 Jan 2018 18:07:02 -0500 Subject: [bug#30201] [PATCH] Fix Solfege configuration skeleton Resent-Message-ID: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edOh8-00012W-6X for guix-patches@gnu.org; Sun, 21 Jan 2018 18:06:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edOh4-0006wB-Hs for guix-patches@gnu.org; Sun, 21 Jan 2018 18:06:34 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:56395) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1edOh4-0006ua-A4 for guix-patches@gnu.org; Sun, 21 Jan 2018 18:06:30 -0500 Received: from saiph.selenimh (000043010000000000000469.ipv6.commingeshautdebit.fr [IPv6:2a03:a0a0:0:4301::469]) (Authenticated sender: mail@nicolasgoaziou.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id D3DC71720AC for ; Mon, 22 Jan 2018 00:06:28 +0100 (CET) Received: from ngz by saiph.selenimh with local (Exim 4.89) (envelope-from ) id 1edOh2-0003pW-6H for guix-patches@gnu.org; Mon, 22 Jan 2018 00:06:28 +0100 From: Nicolas Goaziou Date: Mon, 22 Jan 2018 00:06:28 +0100 Message-ID: <87y3kqak23.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 30201@debbugs.gnu.org --=-=-= Content-Type: text/plain Hello, Currently, Guix Solfege package replaces, in the skeleton configuration, hard-coded filenames to various sound players with hard-coded filenames to the same players in the store. I think this is no good. The first time it is run, Solfege copies the skeleton configuration in home directory, as a dot file. However, at some point, possibly long after you forget about this detail, initial inputs are GC'ed, leaving non-existing filenames in a now broken configuration. Once you realize it, you need to find the new inputs in the store, rinse and repeat. One option would be to move players to propagated-inputs. Since they do not prevent Solfege from building, however, I think simply removing them from the package is enough. One can always add them to their profile if needed. The following patch implements this. Regards, -- Nicolas Goaziou 0x80A93738 --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-solfege-Make-configuration-more-robust-to-GC.patch Content-Transfer-Encoding: quoted-printable Content-Description: Fix Solfege >From e30b919f03ad9b37123b96dc38c24d41e562a02a Mon Sep 17 00:00:00 2001 From: Nicolas Goaziou Date: Sun, 21 Jan 2018 23:43:02 +0100 Subject: [PATCH] gnu: solfege: Make configuration more robust to GC * gnu/packages/music.scm (solfege): Do not introduce store filenames in the configuration skeleton. [inputs]: Remove optional players. --- gnu/packages/music.scm | 30 ++++++------------------------ 1 file changed, 6 insertions(+), 24 deletions(-) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index b7dc7d9aa..e618e2bf1 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -10,7 +10,7 @@ ;;; Copyright =C2=A9 2016 Alex Griffin ;;; Copyright =C2=A9 2017 ng0 ;;; Copyright =C2=A9 2017 Rodger Fox -;;; Copyright =C2=A9 2017 Nicolas Goaziou +;;; Copyright =C2=A9 2017, 2018 Nicolas Goaziou ;;; Copyright =C2=A9 2017 Pierre Langlois ;;; Copyright =C2=A9 2017 Arun Isaac ;;; Copyright =C2=A9 2017, 2018 Tobias Geerinckx-Rice @@ -1055,22 +1055,10 @@ complete studio.") (add-after 'unpack 'fix-configuration (lambda* (#:key inputs #:allow-other-keys) (substitute* "default.config" - (("csound=3Dcsound") - (string-append "csound=3D" - (assoc-ref inputs "csound") - "/bin/csound")) - (("/usr/bin/aplay") - (string-append (assoc-ref inputs "aplay") - "/bin/aplay")) - (("/usr/bin/timidity") - (string-append (assoc-ref inputs "timidity") - "/bin/timidity")) - (("/usr/bin/mpg123") - (string-append (assoc-ref inputs "mpg123") - "/bin/mpg123")) - (("/usr/bin/ogg123") - (string-append (assoc-ref inputs "ogg123") - "/bin/ogg123"))) + (("/usr/bin/aplay" "aplay")) + (("/usr/bin/timidity") "timidity") + (("/usr/bin/mpg123") "mpg123") + (("/usr/bin/ogg123") "ogg123")) #t)) (add-before 'build 'patch-python-shebangs (lambda _ @@ -1110,13 +1098,7 @@ for path in [path for path in sys.path if 'site-pack= ages' in path]: site.addsite ("pygtk" ,python2-pygtk) ("gettext" ,gettext-minimal) ("gtk" ,gtk+) - ("lilypond" ,lilypond) - ;; players needed at runtime - ("aplay" ,alsa-utils) - ("csound" ,csound) ; optional, needed for some exercises - ("mpg123" ,mpg123) - ("ogg123" ,vorbis-tools) - ("timidity" ,timidity++))) + ("lilypond" ,lilypond))) (native-inputs `(("pkg-config" ,pkg-config) ("txt2man" ,txt2man) --=20 2.15.1 --=-=-=--