unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Greg Hogan <code@greghogan.com>
Cc: 43619@debbugs.gnu.org
Subject: [bug#43619] [PATCH 1/2] gnu: Add liburing.
Date: Tue, 29 Sep 2020 22:38:33 +0200	[thread overview]
Message-ID: <87y2ks48ty.fsf@gnu.org> (raw)
In-Reply-To: <CA+3U0ZmMhiv0q8SpGdSYmHF1M58y=-BjEFTWzOMsYEVaDNx9HA@mail.gmail.com> (Greg Hogan's message of "Fri, 25 Sep 2020 14:11:56 -0400")

Hi Greg,

Greg Hogan <code@greghogan.com> skribis:

>>From 4cd8b67741d61b69e70ae2271b1063f53e3513e8 Mon Sep 17 00:00:00 2001
> From: Greg Hogan <code@greghogan.com>
> Date: Tue, 22 Sep 2020 15:21:43 +0000
> Subject: [PATCH 1/2] gnu: Add liburing.
>
> * gnu/packages/liburing.scm (liburing): New variable.

[...]

> +(define-module (gnu packages liburing)

I would tend to put it in another module, probably (gnu packages linux)
in this case because it’s Linux-specific.

> +    (arguments
> +     `(#:tests? #f

Please add a comment explaining why the test suite is skipped.

> +    (home-page "https://github.com/axboe/liburing")
> +    (synopsis "Simplified interface for io_uring")

Maybe “Interface to the Linux kernel @code{io_uring} interface”?

Could you send an updated patch?

Thanks,
Ludo’.




  reply	other threads:[~2020-09-29 20:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-25 18:11 [bug#43619] [PATCH 1/2] gnu: Add liburing Greg Hogan
2020-09-29 20:38 ` Ludovic Courtès [this message]
2020-10-10 16:15   ` Greg Hogan
2020-10-10 20:50     ` bug#43619: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2ks48ty.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=43619@debbugs.gnu.org \
    --cc=code@greghogan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).