From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8HpyJ3abc19lLgAA0tVLHw (envelope-from ) for ; Tue, 29 Sep 2020 20:39:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id EMc3I3abc1+7aAAAbx9fmQ (envelope-from ) for ; Tue, 29 Sep 2020 20:39:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E965C94023C for ; Tue, 29 Sep 2020 20:39:17 +0000 (UTC) Received: from localhost ([::1]:57382 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNMP6-0001mg-FZ for larch@yhetil.org; Tue, 29 Sep 2020 16:39:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35762) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNMOt-0001kv-8D for guix-patches@gnu.org; Tue, 29 Sep 2020 16:39:08 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45745) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNMOs-0006D1-IP for guix-patches@gnu.org; Tue, 29 Sep 2020 16:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNMOs-0008Cw-GZ for guix-patches@gnu.org; Tue, 29 Sep 2020 16:39:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43619] [PATCH 1/2] gnu: Add liburing. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 29 Sep 2020 20:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43619 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Greg Hogan Cc: 43619@debbugs.gnu.org Received: via spool by 43619-submit@debbugs.gnu.org id=B43619.160141192231523 (code B ref 43619); Tue, 29 Sep 2020 20:39:02 +0000 Received: (at 43619) by debbugs.gnu.org; 29 Sep 2020 20:38:42 +0000 Received: from localhost ([127.0.0.1]:57291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNMOY-0008CN-Fx for submit@debbugs.gnu.org; Tue, 29 Sep 2020 16:38:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNMOX-0008C9-3h for 43619@debbugs.gnu.org; Tue, 29 Sep 2020 16:38:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47197) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNMOR-0006BR-Kd; Tue, 29 Sep 2020 16:38:35 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57450 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kNMOR-0003C1-6A; Tue, 29 Sep 2020 16:38:35 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Tue, 29 Sep 2020 22:38:33 +0200 In-Reply-To: (Greg Hogan's message of "Fri, 25 Sep 2020 14:11:56 -0400") Message-ID: <87y2ks48ty.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: e6TTVn36XR4f Hi Greg, Greg Hogan skribis: >>>From 4cd8b67741d61b69e70ae2271b1063f53e3513e8 Mon Sep 17 00:00:00 2001 > From: Greg Hogan > Date: Tue, 22 Sep 2020 15:21:43 +0000 > Subject: [PATCH 1/2] gnu: Add liburing. > > * gnu/packages/liburing.scm (liburing): New variable. [...] > +(define-module (gnu packages liburing) I would tend to put it in another module, probably (gnu packages linux) in this case because it=E2=80=99s Linux-specific. > + (arguments > + `(#:tests? #f Please add a comment explaining why the test suite is skipped. > + (home-page "https://github.com/axboe/liburing") > + (synopsis "Simplified interface for io_uring") Maybe =E2=80=9CInterface to the Linux kernel @code{io_uring} interface=E2= =80=9D? Could you send an updated patch? Thanks, Ludo=E2=80=99.