From: Mathieu Othacehe <othacehe@gnu.org>
To: Vinicius Monego <monego@posteo.net>
Cc: 44768@debbugs.gnu.org
Subject: [bug#44768] [PATCH v2] gnu: Add gnash.
Date: Wed, 25 Nov 2020 14:17:53 +0100 [thread overview]
Message-ID: <87y2iplgn2.fsf@gnu.org> (raw)
In-Reply-To: <20201124230446.20948-1-monego@posteo.net> (Vinicius Monego's message of "Tue, 24 Nov 2020 20:04:46 -0300")
Hey Vinicius,
> +of v8 and v9. It is possible to configure Gnash to use several differemt
Small typo here: "different".
> + // Clean up allocated data.
> +-#if GIFLIB_MAJOR==5 && GIFLIB_MINOR==1
> ++#if GIFLIB_MAJOR==5 && GIFLIB_MINOR!=0
It would be nice to add a small comment with the patch to explain what
it does and who is the author.
Could you also rebase your "lightspark" patch on top of the gnash v2?
Thanks,
Mathieu
next prev parent reply other threads:[~2020-11-25 13:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 20:05 [bug#44768] [PATCH 1/2] gnu: Add gnash Vinicius Monego
2020-11-20 20:07 ` [bug#44768] [PATCH 2/2] gnu: Add lightspark Vinicius Monego
2020-11-24 23:04 ` [bug#44768] [PATCH v2] gnu: Add gnash Vinicius Monego
2020-11-25 13:17 ` Mathieu Othacehe [this message]
2020-11-25 17:18 ` [bug#44768] [PATCH v3 1/2] " Vinicius Monego
2020-11-25 17:18 ` [bug#44768] [PATCH v3 2/2] gnu: Add lightspark Vinicius Monego
2020-11-28 16:15 ` Christopher Baines
2021-02-02 17:10 ` Vinicius Monego
2020-11-28 16:12 ` [bug#44768] [PATCH v3 1/2] gnu: Add gnash Christopher Baines
2021-02-02 17:29 ` [bug#44768] [PATCH v4] gnu: Add lightspark Vinicius Monego
2021-04-30 0:22 ` [bug#44768] [PATCH v5] " Vinicius Monego
2021-05-26 13:34 ` bug#44768: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2iplgn2.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=44768@debbugs.gnu.org \
--cc=monego@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).