From: Christopher Baines <mail@cbaines.net>
To: Vinicius Monego <monego@posteo.net>
Cc: 44768@debbugs.gnu.org
Subject: [bug#44768] [PATCH v3 2/2] gnu: Add lightspark.
Date: Sat, 28 Nov 2020 16:15:01 +0000 [thread overview]
Message-ID: <875z5ptq4a.fsf@cbaines.net> (raw)
In-Reply-To: <20201125171857.28120-2-monego@posteo.net>
[-- Attachment #1: Type: text/plain, Size: 4037 bytes --]
Vinicius Monego <monego@posteo.net> writes:
> * gnu/packages/animation.scm (lightspark): New variable.
> ---
> Rebased on the previous commit
Thanks for the patch, the main thing I noticed with this is that there's
some bundled code, at least I spotted pugixml included in the lightspark
code, and Guix already has a package for pugixml.
If possible, lightspark should be built with pugixml from Guix.
> gnu/packages/animation.scm | 64 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 64 insertions(+)
>
> diff --git a/gnu/packages/animation.scm b/gnu/packages/animation.scm
> index 102b0f47f7..9b94c1d214 100644
> --- a/gnu/packages/animation.scm
> +++ b/gnu/packages/animation.scm
> @@ -25,9 +25,11 @@
> #:use-module (guix git-download)
> #:use-module (guix utils)
> #:use-module ((guix licenses) #:prefix license:)
> + #:use-module (guix build-system cmake)
> #:use-module (guix build-system gnu)
> #:use-module (gnu packages)
> #:use-module (gnu packages algebra)
> + #:use-module (gnu packages assembly)
> #:use-module (gnu packages autotools)
> #:use-module (gnu packages boost)
> #:use-module (gnu packages compression)
> @@ -43,6 +45,8 @@
> #:use-module (gnu packages image)
> #:use-module (gnu packages imagemagick)
> #:use-module (gnu packages jemalloc)
> + #:use-module (gnu packages networking)
> + #:use-module (gnu packages pcre)
> #:use-module (gnu packages perl)
> #:use-module (gnu packages pkg-config)
> #:use-module (gnu packages pulseaudio)
> @@ -397,3 +401,63 @@ audio or video backends, ensuring good performance.")
> (home-page "https://www.gnu.org/software/gnash/")
> (license license:gpl3+))))
>
> +(define-public lightspark
> + (package
> + (name "lightspark")
> + (version "0.8.3")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/lightspark/lightspark")
> + (commit version)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "0rgqqppnv4n3kv623sgr1zpc2fdsnrqzfiqgk4clcmfl5ipklg6f"))))
> + (build-system cmake-build-system)
> + (arguments
> + `(#:tests? #f ;requires Adobe Flex SDK, see README.tests
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'relative-etc-dir
> + ;; Write default config file to ./etc instead of /etc.
> + (lambda _
> + (substitute* "CMakeLists.txt" (("\\/etc") "etc"))
> + #t))
> + (replace 'check
> + (lambda* (#:key tests? #:allow-other-keys)
> + (if tests?
> + (begin
> + (invoke "./tests"))
> + #t))))))
I'd normally write this as:
(when tests?
(invoke "./tests"))
#t
> + (native-inputs
> + `(("gettext" ,gettext-minimal)
> + ("glib:bin" ,glib "bin")
> + ("nasm" ,nasm)
> + ("perl" ,perl)
> + ("pkg-config" ,pkg-config)
> + ("python" ,python-wrapper)))
> + (inputs
> + `(("cairo" ,cairo)
> + ("curl" ,curl)
> + ("ffmpeg" ,ffmpeg)
> + ("freeglut" ,freeglut)
> + ("glew" ,glew)
> + ("glibmm" ,glibmm)
> + ("gnash" ,gnash)
> + ("libjpeg" ,libjpeg-turbo)
> + ("openssl" ,openssl)
> + ("pango" ,pango)
> + ("pcre2" ,pcre2)
> + ("rtmpdump" ,rtmpdump)
> + ("sdl2" ,sdl2)
> + ("sdl2-mixer" ,sdl2-mixer)
> + ("zlib" ,zlib)))
> + (home-page "https://lightspark.github.io/")
> + (synopsis "Flash player implementation")
> + (description
> + "Lightspark is a Flash player implementation for playing files in the SWF
> +format. Lightspark can run as a web browser plugin or as a standalone
> +application. Lightspark supports SWF files written on all versions of the
> +ActionScript language.")
> + (license license:lgpl3+)))
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
next prev parent reply other threads:[~2020-11-28 16:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 20:05 [bug#44768] [PATCH 1/2] gnu: Add gnash Vinicius Monego
2020-11-20 20:07 ` [bug#44768] [PATCH 2/2] gnu: Add lightspark Vinicius Monego
2020-11-24 23:04 ` [bug#44768] [PATCH v2] gnu: Add gnash Vinicius Monego
2020-11-25 13:17 ` Mathieu Othacehe
2020-11-25 17:18 ` [bug#44768] [PATCH v3 1/2] " Vinicius Monego
2020-11-25 17:18 ` [bug#44768] [PATCH v3 2/2] gnu: Add lightspark Vinicius Monego
2020-11-28 16:15 ` Christopher Baines [this message]
2021-02-02 17:10 ` Vinicius Monego
2020-11-28 16:12 ` [bug#44768] [PATCH v3 1/2] gnu: Add gnash Christopher Baines
2021-02-02 17:29 ` [bug#44768] [PATCH v4] gnu: Add lightspark Vinicius Monego
2021-04-30 0:22 ` [bug#44768] [PATCH v5] " Vinicius Monego
2021-05-26 13:34 ` bug#44768: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z5ptq4a.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=44768@debbugs.gnu.org \
--cc=monego@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).