unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrew Tropin <andrew@trop.in>
To: Alexey Abramov <levenson@mmer.org>
Cc: 46113@debbugs.gnu.org
Subject: [bug#46113] [PATCH] gnu: obs: Update obs to fb347c.
Date: Wed, 27 Jan 2021 12:36:58 +0300	[thread overview]
Message-ID: <87y2geiuv9.fsf@trop.in> (raw)
In-Reply-To: <87eei7wugf.fsf@trop.in>


> I patched obs here [1]. I checked the upstream patch, and noticed that
> it ammends AddExtraModulePaths function. With Guix the list of plugin
> directories will contain *two* locations with the very same plugins,
> one with the obs store and guix-profile, hence obs will print
> 'Duplicate library?' warning messages.

It's very true, obs, will have same plugins in load paths twice, but
from what I found the problem will happen only during shutdown of obs,
when it will try to unload the same plugin twice, which doesn't affect
runtime anyhow. I had a small workaround for that (a separate
envirnoment variable, which toggles the loading of plugins from
INSTALL_PREFIX), but during review one of obs mantainers said that it's
an adhoc solution and better to solve this problem in general. The
comment from @kkartaltepe and related changes [fn:1].

The other solution was to check if OBS_PLUGINS_PATH is present and ommit
loading of builtin plugins in that case, but it will break in case
someone wants to specify just additional plugin load path (some non-guix
use case).

I decided to go without any fix to that problem as it is not directly
related to changeset I proposed and doesn't affect runtime, but it's
probably a good idea to report double free on shutdown issue to
upstream.

* Footnotes

[fn:1] https://github.com/obsproject/obs-studio/pull/4067 




  parent reply	other threads:[~2021-01-27  9:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26 15:59 [bug#46113] [PATCH] gnu: obs: Update obs to fb347c Andrew Tropin
2021-01-26 16:26 ` Andrew Tropin
2021-01-27  7:27   ` Alexey Abramov
2021-01-26 21:10 ` Leo Famulari
2021-01-27  9:36 ` Andrew Tropin [this message]
2021-01-27  9:45 ` [bug#46113] [PATCH] gnu: obs: Update " Andrew Tropin
2021-02-02  0:48   ` Leo Famulari
2021-02-02 11:39     ` Andrew Tropin
2021-02-02 19:33       ` Leo Famulari
2021-02-02 19:43         ` Andrew Tropin
  -- strict thread matches above, loose matches on Subject: below --
2021-02-03 14:40 [bug#45707] [PATCH] gnu: obs: Update obs " Andrew Tropin
2021-02-03 21:11 ` [bug#46113] " Ludovic Courtès
2021-02-04 10:45 ` guix-patches--- via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2geiuv9.fsf@trop.in \
    --to=andrew@trop.in \
    --cc=46113@debbugs.gnu.org \
    --cc=levenson@mmer.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).