From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IdhHK540EWC7MQAA0tVLHw (envelope-from ) for ; Wed, 27 Jan 2021 09:38:38 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id aFt6Jp40EWACJQAAB5/wlQ (envelope-from ) for ; Wed, 27 Jan 2021 09:38:38 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3DAC19403EB for ; Wed, 27 Jan 2021 09:38:38 +0000 (UTC) Received: from localhost ([::1]:38808 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4hHZ-00055h-6w for larch@yhetil.org; Wed, 27 Jan 2021 04:38:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4hH1-0004Ug-G9 for guix-patches@gnu.org; Wed, 27 Jan 2021 04:38:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60499) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l4hH0-0000vx-MZ for guix-patches@gnu.org; Wed, 27 Jan 2021 04:38:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l4hH0-0002du-LA for guix-patches@gnu.org; Wed, 27 Jan 2021 04:38:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46113] [PATCH] gnu: obs: Update obs to fb347c. References: <87eei7wugf.fsf@trop.in> In-Reply-To: <87eei7wugf.fsf@trop.in> Resent-From: Andrew Tropin Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 27 Jan 2021 09:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46113 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alexey Abramov Received: via spool by 46113-submit@debbugs.gnu.org id=B46113.161174023110041 (code B ref 46113); Wed, 27 Jan 2021 09:38:02 +0000 Received: (at 46113) by debbugs.gnu.org; 27 Jan 2021 09:37:11 +0000 Received: from localhost ([127.0.0.1]:43800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4hGA-0002bs-NV for submit@debbugs.gnu.org; Wed, 27 Jan 2021 04:37:10 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:39965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4hG8-0002bc-3E for 46113@debbugs.gnu.org; Wed, 27 Jan 2021 04:37:09 -0500 Received: by mail-lj1-f193.google.com with SMTP id s18so1290002ljg.7 for <46113@debbugs.gnu.org>; Wed, 27 Jan 2021 01:37:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version; bh=EmZ+vEKTWS4YGUNItyZGDV6cpncrOyyf0z2u5V52SQA=; b=kx0PPZqR6+bCgHh5JIVoi49X2tS/6dbcvfVIxqq2jJ9tKA6zu/5I9TCFZjOxz1qFjX ptTxAAhnxfPauFAhvRoOJQm2X6gaBDi4CwaZNIhUDhxprBIHL3nSUlU2D/B8eh0hRWcc YshepBuV2Uw5eyQbxNZfy6dGBGrvB2gCoyytfZxjvTkI8nV6uSHhzjaCTgFUhJhjOTlV U6dmtw7EedNNKSQQBHUAAQiKx1+KuvvH9sSgLR+bne1/j33d54v26Jo2VUh/mrYf1rwQ b88/CtzMwrnlwpo+aVJzADlGsLc81Y5JL/xuIK5uUePt03KjCZBkqiFxKNB28SWb5AP4 oAng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=EmZ+vEKTWS4YGUNItyZGDV6cpncrOyyf0z2u5V52SQA=; b=BK7JdkvrSP8GlLov/QogBrSwqO1gO72EAHhDBx2YWT3r+6PkV+/INz2sszudmzOqXT T8BbBODrscMWcYPSfkVhWmR+/2j2iAMQaBlEU6HArSeuh7QTrYc1pPiyN7SCx66jSKua fBmzPIlsXBZH6nF/RaTkqOhvvXA1rN2twZDBcG41lCTw1hkXE487JMczPBSOFQvBCGOB lYxqJ077ZwVdWmKsVQfE7U8nrynxKqQk1mpNZ1s+vLAhdXWI5brmMrY4FHEl6vphsN68 UaF0fuTr+e5EY1NNj+mFHGQqzYh8iZYXyZK8m/P1hBFNUjApmzmQYYHUPRsi/9IK+mjV oJWg== X-Gm-Message-State: AOAM533sVCCjgoCATMHFz/XS6VeosLPAmHXictCa4NcVCdX4+khKxOQ7 YadnPVIiSfvThmlXuFOQbOra048AFrnDTw== X-Google-Smtp-Source: ABdhPJzjtMRfWP5MYXXFMhv+KUmaWshfmpe/Z2D9zI6m2bx6pVsXeuC6aKu9mfNQusbiDauDR4cnxg== X-Received: by 2002:a2e:3306:: with SMTP id d6mr5236506ljc.371.1611740221507; Wed, 27 Jan 2021 01:37:01 -0800 (PST) Received: from ixy ([109.252.99.251]) by smtp.gmail.com with ESMTPSA id f25sm199346ljj.72.2021.01.27.01.37.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 01:37:00 -0800 (PST) From: Andrew Tropin Date: Wed, 27 Jan 2021 12:36:58 +0300 Message-ID: <87y2geiuv9.fsf@trop.in> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 46113@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.35 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop-in.20150623.gappssmtp.com header.s=20150623 header.b=kx0PPZqR; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 3DAC19403EB X-Spam-Score: -1.35 X-Migadu-Scanner: scn1.migadu.com X-TUID: NZTRqgikcGiG > I patched obs here [1]. I checked the upstream patch, and noticed that > it ammends AddExtraModulePaths function. With Guix the list of plugin > directories will contain *two* locations with the very same plugins, > one with the obs store and guix-profile, hence obs will print > 'Duplicate library?' warning messages. It's very true, obs, will have same plugins in load paths twice, but from what I found the problem will happen only during shutdown of obs, when it will try to unload the same plugin twice, which doesn't affect runtime anyhow. I had a small workaround for that (a separate envirnoment variable, which toggles the loading of plugins from INSTALL_PREFIX), but during review one of obs mantainers said that it's an adhoc solution and better to solve this problem in general. The comment from @kkartaltepe and related changes [fn:1]. The other solution was to check if OBS_PLUGINS_PATH is present and ommit loading of builtin plugins in that case, but it will break in case someone wants to specify just additional plugin load path (some non-guix use case). I decided to go without any fix to that problem as it is not directly related to changeset I proposed and doesn't affect runtime, but it's probably a good idea to report double free on shutdown issue to upstream. * Footnotes [fn:1] https://github.com/obsproject/obs-studio/pull/4067