unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 45965@debbugs.gnu.org
Cc: eu@euandre.org
Subject: [bug#45965] [PATCH 0/2] Update fzf, include binaries and install completions
Date: Fri, 05 Feb 2021 21:57:33 +0100	[thread overview]
Message-ID: <87y2g2w7uq.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20210118185925.24412-1-eu@euandre.org> (guix-patches@gnu.org's message of "Mon, 18 Jan 2021 15:59:25 -0300")

Hello,

guix-patches--- via <guix-patches@gnu.org> writes:

> I've tested both the package update and the extra phases added.
> The Bash completions are being installed properly, but I haven't tested
> the zsh ones.
>
> I remember seeing somewhere a discussion on aliasing this type of package,
> so that the "go-github-com-junegunn-fzf" is the default imported Go module,
> to be used as input for other packages, and adding a top-level "fzf" package,
> which does the ad-hoc packaging code I've added, so that a user can install
> the "fzf" package with Bash integration and similar features.

Indeed, having to install "go-github-com-junegunn-fzf" when you are
really looking for "fzf" is not very intuitive.

So, "fzf" could inherit from "go-github-com-junegunn-fzf" and add all
the bells and whistles.

Would you want to provide a patch for that?

Meanwhile, I'm going to apply the update and leave the first patch out.

Regards,
-- 
Nicolas Goaziou




  parent reply	other threads:[~2021-02-05 20:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18 18:59 [bug#45965] [PATCH 0/2] Update fzf, include binaries and install completions guix-patches--- via
2021-01-18 19:04 ` [bug#45965] [PATCH 1/2] gnu: go-github-com-junegunn-fzf: Copy binaries and install shell completions guix-patches--- via
2021-01-18 19:04   ` [bug#45965] [PATCH 2/2] gnu: go-github-com-junegunn-fzf: Update to 0.25.0 guix-patches--- via
2021-02-05 20:57 ` Nicolas Goaziou [this message]
2021-02-05 22:31   ` [bug#45965] [PATCH 0/2] Update fzf, include binaries and install completions EuAndreh via Guix-patches via
2021-02-08 17:08     ` [bug#45965] [PATCH] gnu: Add fzf EuAndreh via Guix-patches via
2021-03-19 21:15       ` bug#45965: [PATCH 0/2] Update fzf, include binaries and install completions Ludovic Courtès
2021-03-21 13:42         ` [bug#45965] " EuAndreh via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2g2w7uq.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=45965@debbugs.gnu.org \
    --cc=eu@euandre.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).