From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id AGFdFGOxHWBzRQAA0tVLHw (envelope-from ) for ; Fri, 05 Feb 2021 20:58:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id CGkuEGOxHWBHawAAB5/wlQ (envelope-from ) for ; Fri, 05 Feb 2021 20:58:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B61EE940275 for ; Fri, 5 Feb 2021 20:58:10 +0000 (UTC) Received: from localhost ([::1]:59312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l88B7-0007pI-Ls for larch@yhetil.org; Fri, 05 Feb 2021 15:58:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l88B0-0007ot-Fo for guix-patches@gnu.org; Fri, 05 Feb 2021 15:58:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:33167) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l88B0-0006Vq-8f for guix-patches@gnu.org; Fri, 05 Feb 2021 15:58:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l88B0-0006TC-7v for guix-patches@gnu.org; Fri, 05 Feb 2021 15:58:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45965] [PATCH 0/2] Update fzf, include binaries and install completions Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 05 Feb 2021 20:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45965 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 45965@debbugs.gnu.org Cc: eu@euandre.org X-Debbugs-Original-To: guix-patches--- via X-Debbugs-Original-Cc: 45965@debbugs.gnu.org, EuAndreh Received: via spool by 45965-submit@debbugs.gnu.org id=B45965.161255866324825 (code B ref 45965); Fri, 05 Feb 2021 20:58:02 +0000 Received: (at 45965) by debbugs.gnu.org; 5 Feb 2021 20:57:43 +0000 Received: from localhost ([127.0.0.1]:44709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l88Ag-0006SL-W4 for submit@debbugs.gnu.org; Fri, 05 Feb 2021 15:57:43 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:49995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l88Af-0006S7-FZ for 45965@debbugs.gnu.org; Fri, 05 Feb 2021 15:57:42 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 1B44F1BF204; Fri, 5 Feb 2021 20:57:33 +0000 (UTC) From: Nicolas Goaziou References: <20210118185925.24412-1-eu@euandre.org> Date: Fri, 05 Feb 2021 21:57:33 +0100 In-Reply-To: <20210118185925.24412-1-eu@euandre.org> (guix-patches@gnu.org's message of "Mon, 18 Jan 2021 15:59:25 -0300") Message-ID: <87y2g2w7uq.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.36 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B61EE940275 X-Spam-Score: -2.36 X-Migadu-Scanner: scn1.migadu.com X-TUID: eA3jjBRXh6Y7 Hello, guix-patches--- via writes: > I've tested both the package update and the extra phases added. > The Bash completions are being installed properly, but I haven't tested > the zsh ones. > > I remember seeing somewhere a discussion on aliasing this type of package, > so that the "go-github-com-junegunn-fzf" is the default imported Go module, > to be used as input for other packages, and adding a top-level "fzf" package, > which does the ad-hoc packaging code I've added, so that a user can install > the "fzf" package with Bash integration and similar features. Indeed, having to install "go-github-com-junegunn-fzf" when you are really looking for "fzf" is not very intuitive. So, "fzf" could inherit from "go-github-com-junegunn-fzf" and add all the bells and whistles. Would you want to provide a patch for that? Meanwhile, I'm going to apply the update and leave the first patch out. Regards, -- Nicolas Goaziou