From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Adam Kandur <kefironpremise@gmail.com>
Cc: 55152@debbugs.gnu.org
Subject: [bug#55152] [PATCH] gnu: Add emacs-soothe-theme.
Date: Mon, 27 Jun 2022 12:27:29 +0200 [thread overview]
Message-ID: <87y1xijt9q.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20220427133137.2603-1-kefironpremise@gmail.com> (Adam Kandur's message of "Wed, 27 Apr 2022 16:31:37 +0300")
Hello,
Adam Kandur <kefironpremise@gmail.com> writes:
> * gnu/packages/emacs-xyz.scm (emacs-soothe-theme): New variable.
Thank you. Sorry for the delay. Some comments follow.
> +(define-public emacs-soothe-theme
> + (let ((commit "0786fe70c6c1b4ddcfb932fdc6862b9611cfc09b")
> + (revision "0"))
> + (package
> + (name "emacs-soothe-theme")
> + (version (git-version "0.1" revision commit))
Where does this "0.1" come from? According to "soothe-theme.el" and
Changelog, version is 20141027.2233.
Also, I suggest to stick to commit hash
0568a61eeec0b074d8911886359a6c5da13d14cb, which is the penultimate
commit, but matches version bump. You don't need to use `git-version'
then.
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/emacsfodder/emacs-soothe-theme.git")
You can drop the ".git" suffix from the URL.
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "10gh1hvxq9gm29r6qzlnva7vjidd7n4kih4z2ihyvbvy9za20xqw"))))
> + (build-system emacs-build-system)
> + (home-page "https://github.com/emacsfodder/emacs-soothe-theme.git")
> + (synopsis "A colorful, but muted theme for Emacs 24, dark background with light text")
Synopsis must not start with an article. I would also remove reference
to Emacs 24, which is unimportant in Guix.
> + (description
> + "An amalgam of muted color tones and highlighted backgrounds. Builtin support
> +for rainbow-delimiters, org-mode, whitespace-mode, ECB, flyspell, ido, linum, highlight
> +indentation, show-paren-mode, further mode support to come.")
Description must contain complete sentence only. So it should be "Soothe
theme is an amalgam…".
Also (nitpick) major mode are usually capitalized and un-hyphenized at
least in the Emacs manual. So: Rainbom delimiters, Org mode, Whitespace
mode, Flyspell, Ido, Linum…
Since the project hasn't seen any commit in the last 7 years, maybe
"further mode support to come" should be removed.
> + (license license:gpl3+))))
License seems to be gpl3, not gpl3+.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2022-06-27 10:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 13:31 [bug#55152] [PATCH] gnu: Add emacs-soothe-theme Adam Kandur
2022-06-27 10:27 ` Nicolas Goaziou [this message]
2022-07-20 13:01 ` bug#55152: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1xijt9q.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=55152@debbugs.gnu.org \
--cc=kefironpremise@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).