From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oOn/BxSMuWIUxwAAbAwnHQ (envelope-from ) for ; Mon, 27 Jun 2022 12:53:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GK33BhSMuWLE6gAAG6o9tA (envelope-from ) for ; Mon, 27 Jun 2022 12:53:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8ED502C831 for ; Mon, 27 Jun 2022 12:53:07 +0200 (CEST) Received: from localhost ([::1]:56374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5mMc-0002Bi-2s for larch@yhetil.org; Mon, 27 Jun 2022 06:53:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5lyM-0001hZ-FC for guix-patches@gnu.org; Mon, 27 Jun 2022 06:28:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56043) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5lyM-00061l-2K for guix-patches@gnu.org; Mon, 27 Jun 2022 06:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o5lyL-00012e-VQ for guix-patches@gnu.org; Mon, 27 Jun 2022 06:28:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55152] [PATCH] gnu: Add emacs-soothe-theme. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 27 Jun 2022 10:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55152 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Adam Kandur Cc: 55152@debbugs.gnu.org Received: via spool by 55152-submit@debbugs.gnu.org id=B55152.16563256603973 (code B ref 55152); Mon, 27 Jun 2022 10:28:01 +0000 Received: (at 55152) by debbugs.gnu.org; 27 Jun 2022 10:27:40 +0000 Received: from localhost ([127.0.0.1]:49940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5ly0-000121-18 for submit@debbugs.gnu.org; Mon, 27 Jun 2022 06:27:40 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:54551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5lxy-00011l-9J for 55152@debbugs.gnu.org; Mon, 27 Jun 2022 06:27:39 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id C8A35200004; Mon, 27 Jun 2022 10:27:30 +0000 (UTC) From: Nicolas Goaziou References: <20220427133137.2603-1-kefironpremise@gmail.com> Date: Mon, 27 Jun 2022 12:27:29 +0200 In-Reply-To: <20220427133137.2603-1-kefironpremise@gmail.com> (Adam Kandur's message of "Wed, 27 Apr 2022 16:31:37 +0300") Message-ID: <87y1xijt9q.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656327187; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=cin7vT1ycRMEk8Dn+E8lnaP2E+b5vEmfa4E7cw6FT+o=; b=Kx4YuhZW76xYFcXnwGZ7WnIGsMBnBf1nZfx9g58jw+xcxzDNNj8OHHIx+nBEukG8TZZJIL 6354MY/llqCpPqFLrrwlQYF3NSCiM959NSBUA/gUxn7CtW8DXTi5WOGa3G5KiSmxbwJCOJ SwKySgFF1u5wuT7fmmads0BEPEkH+UjeCiwAYduyifmXOcIAhNjnLoNuuqQ9Cy3iB1r62Z d2FmtUlCz/qgtAL9+14PKuEyxAvqy7PRqflI1jHjFLvu+3Okrxo5Hajq5WMmiBY+oSf3Pu hOFnAtlr+e19x3aWzPbCf3M1EEktjZkljtTKIpIhLS3Ma1w5KwS3klHq4K/Y0g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656327187; a=rsa-sha256; cv=none; b=Q8q/jeuyp/XqZdkMwSn5hr5M5LPjyyfUvpnGlbRJesV7y04zb7qd/pAurQn6nqJOWxLDlG 8+eYtsQeqfTnCNmKfB4N65wuxd44noC3/8Ru8PaRQwqHXey8lM2LGl8cuSMO78NQ0trMyY R6F72cGrtXILly5ELPCjPv/Vuc+MQYQNK4RSWzQ/sOCIGqsJXuszpnWNltD0dB7CL6XGdG In3hhbAeD5beZcqRsi0ov7ln28dcbF24QN9NkYmZ8Mc9JN9ipX3wd/+dCoYNjzLTukCGp5 MOXU6ZqTw4sLztehooWPPA5gIXv4guWCRdiz49NLmD2bMItGqWTN/EhTGAuPNg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.75 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8ED502C831 X-Spam-Score: -3.75 X-Migadu-Scanner: scn0.migadu.com X-TUID: 2Zi9GdjJlpPj Hello, Adam Kandur writes: > * gnu/packages/emacs-xyz.scm (emacs-soothe-theme): New variable. Thank you. Sorry for the delay. Some comments follow. > +(define-public emacs-soothe-theme > + (let ((commit "0786fe70c6c1b4ddcfb932fdc6862b9611cfc09b") > + (revision "0")) > + (package > + (name "emacs-soothe-theme") > + (version (git-version "0.1" revision commit)) Where does this "0.1" come from? According to "soothe-theme.el" and Changelog, version is 20141027.2233. Also, I suggest to stick to commit hash 0568a61eeec0b074d8911886359a6c5da13d14cb, which is the penultimate commit, but matches version bump. You don't need to use `git-version' then. > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/emacsfodder/emacs-soothe-theme.git") You can drop the ".git" suffix from the URL. > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "10gh1hvxq9gm29r6qzlnva7vjidd7n4kih4z2ihyvbvy9za20xqw")))) > + (build-system emacs-build-system) > + (home-page "https://github.com/emacsfodder/emacs-soothe-theme.git") > + (synopsis "A colorful, but muted theme for Emacs 24, dark backgrou= nd with light text") Synopsis must not start with an article. I would also remove reference to Emacs 24, which is unimportant in Guix. > + (description > + "An amalgam of muted color tones and highlighted backgrounds. Bu= iltin support=20 > +for rainbow-delimiters, org-mode, whitespace-mode, ECB, flyspell, ido, l= inum, highlight > +indentation, show-paren-mode, further mode support to come.") Description must contain complete sentence only. So it should be "Soothe theme is an amalgam=E2=80=A6". Also (nitpick) major mode are usually capitalized and un-hyphenized at least in the Emacs manual. So: Rainbom delimiters, Org mode, Whitespace mode, Flyspell, Ido, Linum=E2=80=A6 Since the project hasn't seen any commit in the last 7 years, maybe "further mode support to come" should be removed. > + (license license:gpl3+)))) License seems to be gpl3, not gpl3+. Could you send an updated patch? Regards, --=20 Nicolas Goaziou