[bug#63501] [PATCH] hurd-boot: Symlink /hurd before setting up translators.

[bug#63501] [PATCH] hurd-boot: Symlink /hurd before setting up translators.

[Josselin Poiret via Guix-patches via]

From: Josselin Poiret <dev@jpoiret.xyz>

* gnu/build/hurd-boot.scm (boot-hurd-system): Symlink /hurd before setting up
translators.
---

Hi everyone,

This should fix the Hurd not booting.

Enjoy! (and now we also need to fix the native Hurd compilation problems, but
that's for another patch)

 gnu/build/hurd-boot.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/build/hurd-boot.scm b/gnu/build/hurd-boot.scm
index abcf0304c2..95c15907dd 100644
--- a/gnu/build/hurd-boot.scm
+++ b/gnu/build/hurd-boot.scm
@@ -280,14 +280,14 @@ (define* (boot-hurd-system #:key (on-error 'debug))
             (system  (find-long-option "gnu.system" args))
             (to-load (find-long-option "gnu.load" args)))
 
-       (format #t "Setting-up essential translators...\n")
-       (setenv "PATH" (string-append system "/profile/bin"))
-       (set-hurd-device-translators)
-
        (false-if-exception (delete-file "/hurd"))
        (let ((hurd/hurd (readlink* (string-append system "/profile/hurd"))))
          (symlink hurd/hurd "/hurd"))
 
+       (format #t "Setting-up essential translators...\n")
+       (setenv "PATH" (string-append system "/profile/bin"))
+       (set-hurd-device-translators)
+
        (format #t "Starting pager...\n")
        (unless (zero? (system* "/hurd/mach-defpager"))
          (format #t "FAILED...Good luck!\n"))

base-commit: eb7312401ea89e634f8d686db71bacda58b2755f
-- 
2.40.1

[bug#63501] [PATCH] hurd-boot: Symlink /hurd before setting up translators.

[Janneke Nieuwenhuizen]

Josselin Poiret via Guix-patches via writes:

Hi Josselin!

> * gnu/build/hurd-boot.scm (boot-hurd-system): Symlink /hurd before setting up
> translators.
> ---
> This should fix the Hurd not booting.
>
> Enjoy! (and now we also need to fix the native Hurd compilation problems, but
> that's for another patch)

Haven't reconfigured using this, but it works for me using

    ./pre-inst-env guix system image -t hurd-qcow2 gnu/system/examples/bare-hurd.tmpl

and

--8<---------------cut here---------------start------------->8---
$(guix build qemu | grep -Ev '(doc|static)$')/bin/qemu-system-i386      \
-m 4096                                                                 \
--device rtl8139,netdev=net0                                            \
--netdev user,id=net0,hostfwd=tcp:0.0.0.0:11022-:2222                   \
--snapshot                                                              \
--no-reboot                                                             \
--hda /gnu/store/nap53abhcsjqc2xg8dvbyy1vplb8kkzf-disk-image
--8<---------------cut here---------------end--------------->8---

after some waiting, I get:

--8<---------------cut here---------------start------------->8---
16:07:15 janneke@drakenpad:~/src/guix/master [env]
$ ssh childhurd1
Last login: Sun May 14 16:07:03 2023 from 10.0.2.2


  This is the GNU Hurd.  Welcome.

root@guixygnu ~# 
--8<---------------cut here---------------end--------------->8---

Well done, phew that was quite a puzzle!

> diff --git a/gnu/build/hurd-boot.scm b/gnu/build/hurd-boot.scm
> index abcf0304c2..95c15907dd 100644
> --- a/gnu/build/hurd-boot.scm
> +++ b/gnu/build/hurd-boot.scm
> @@ -280,14 +280,14 @@ (define* (boot-hurd-system #:key (on-error 'debug))
>              (system  (find-long-option "gnu.system" args))
>              (to-load (find-long-option "gnu.load" args)))
>  
> -       (format #t "Setting-up essential translators...\n")
> -       (setenv "PATH" (string-append system "/profile/bin"))
> -       (set-hurd-device-translators)
> -
>         (false-if-exception (delete-file "/hurd"))
>         (let ((hurd/hurd (readlink* (string-append system "/profile/hurd"))))
>           (symlink hurd/hurd "/hurd"))
>  
> +       (format #t "Setting-up essential translators...\n")
> +       (setenv "PATH" (string-append system "/profile/bin"))
> +       (set-hurd-device-translators)
> +

So, LGTM!

Interesting how this seemed to work with earlier versions of the Hurd...

Greetings,
Janneke

-- 
Janneke Nieuwenhuizen <janneke@gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com

[bug#63501] [PATCH] hurd-boot: Symlink /hurd before setting up translators.

[Ludovic Courtès]

Hello!

Josselin Poiret <dev@jpoiret.xyz> skribis:

> From: Josselin Poiret <dev@jpoiret.xyz>
>
> * gnu/build/hurd-boot.scm (boot-hurd-system): Symlink /hurd before setting up
> translators.

Good catch!

Any idea when the regression was introduced?

Anyhow, LGTM.

Thanks for investigating!

Ludo’.

[bug#63501] [PATCH] hurd-boot: Symlink /hurd before setting up translators.

[Brian Cully via Guix-patches via]

This patch is working for me to get ‘hurd-vm-service-type’ working on master.

bug#63501: [PATCH] hurd-boot: Symlink /hurd before setting up translators.

[Josselin Poiret via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

Hi,

Josselin Poiret <dev@jpoiret.xyz> writes:
> * gnu/build/hurd-boot.scm (boot-hurd-system): Symlink /hurd before setting up
> translators.

Pushed as e041801e615d9194505d30093a7fdc8ac1d4a929.

Best,
-- 
Josselin Poiret

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]