unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#69166] [PATCH 0/2] Fix random test failures and update leptonica
@ 2024-02-15 12:44 Ahmad Draidi via Guix-patches via
  2024-02-15 12:55 ` [bug#69166] [PATCH 1/2] gnu: leptonica: Fix random test failures Ahmad Draidi via Guix-patches via
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Ahmad Draidi via Guix-patches via @ 2024-02-15 12:44 UTC (permalink / raw)
  To: 69166; +Cc: Ahmad Draidi

Hello Guix,

This series fixes random test failures I observed while building leptonica,
and updates it to the latest version while we're at it.

I observed, on Debian and Guix (guix shell -D ...), that running the tests in
parallel (e.g. "make check -j16") fails sometimes. And building leptonica using
"guix build leptonica --check --rounds=10 --no-grafts" fails for me every
time. It doesn't fail anymore when disabling parallel tests.

This fixes #65441.

Ahmad Draidi (2):
  gnu: leptonica: Fix random test failures.
  gnu: leptonica: Update to 1.84.1.

 gnu/packages/image.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)


base-commit: 06014750338159a03a6374d7ebdd783c210b3715
-- 
2.41.0





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#69166] [PATCH 1/2] gnu: leptonica: Fix random test failures.
  2024-02-15 12:44 [bug#69166] [PATCH 0/2] Fix random test failures and update leptonica Ahmad Draidi via Guix-patches via
@ 2024-02-15 12:55 ` Ahmad Draidi via Guix-patches via
  2024-02-15 12:55 ` [bug#69166] [PATCH 2/2] gnu: leptonica: Update to 1.84.1 Ahmad Draidi via Guix-patches via
  2024-02-24 10:24 ` bug#69166: [PATCH 0/2] Fix random test failures and update leptonica Guillaume Le Vaillant
  2 siblings, 0 replies; 4+ messages in thread
From: Ahmad Draidi via Guix-patches via @ 2024-02-15 12:55 UTC (permalink / raw)
  To: 69166; +Cc: Ahmad Draidi

Fixes <https://issues.guix.gnu.org/65441>.

Running tests in parallel (e.g. "make check -j16") causes random test
failures. Same behavior observed on Debian.

* gnu/packages/image.scm (leptonica)[arguments]: Disable parallel tests.

Change-Id: I629c6c8be626a704be046dc79ea4480896cd11cc
---
 gnu/packages/image.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 1f434667f8..8ca928c616 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -779,6 +779,8 @@ (define-public leptonica
            zlib))
     (arguments
      (list
+      ;; Parallel tests cause some tests to fail randomly. Same thing observed on Debian.
+      #:parallel-tests? #f
       #:phases
       #~(modify-phases %standard-phases
           (add-after 'unpack 'patch-reg-wrapper
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#69166] [PATCH 2/2] gnu: leptonica: Update to 1.84.1.
  2024-02-15 12:44 [bug#69166] [PATCH 0/2] Fix random test failures and update leptonica Ahmad Draidi via Guix-patches via
  2024-02-15 12:55 ` [bug#69166] [PATCH 1/2] gnu: leptonica: Fix random test failures Ahmad Draidi via Guix-patches via
@ 2024-02-15 12:55 ` Ahmad Draidi via Guix-patches via
  2024-02-24 10:24 ` bug#69166: [PATCH 0/2] Fix random test failures and update leptonica Guillaume Le Vaillant
  2 siblings, 0 replies; 4+ messages in thread
From: Ahmad Draidi via Guix-patches via @ 2024-02-15 12:55 UTC (permalink / raw)
  To: 69166; +Cc: Ahmad Draidi

* gnu/packages/image.scm (leptonica): Update to 1.84.1.

Change-Id: I9070ca7f08c0c3114fa7a5a414695051b587f00b
---
 gnu/packages/image.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 8ca928c616..4eeedeed59 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -752,7 +752,7 @@ (define-public libtiff
 (define-public leptonica
   (package
     (name "leptonica")
-    (version "1.83.1")
+    (version "1.84.1")
     (source
      (origin
        (method git-fetch)
@@ -761,7 +761,7 @@ (define-public leptonica
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1j7qf9flb48q0aymf0yx9rypy3bs6hfjcln08zmy8qn2qcjzrmvi"))))
+        (base32 "0b4ikf1p2ll4310n4dg5lg0b79wys71fb6nj22i7pz17wjdma0j8"))))
     (build-system gnu-build-system)
     (native-inputs
      (list gnuplot ;needed for test suite
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#69166: [PATCH 0/2] Fix random test failures and update leptonica
  2024-02-15 12:44 [bug#69166] [PATCH 0/2] Fix random test failures and update leptonica Ahmad Draidi via Guix-patches via
  2024-02-15 12:55 ` [bug#69166] [PATCH 1/2] gnu: leptonica: Fix random test failures Ahmad Draidi via Guix-patches via
  2024-02-15 12:55 ` [bug#69166] [PATCH 2/2] gnu: leptonica: Update to 1.84.1 Ahmad Draidi via Guix-patches via
@ 2024-02-24 10:24 ` Guillaume Le Vaillant
  2 siblings, 0 replies; 4+ messages in thread
From: Guillaume Le Vaillant @ 2024-02-24 10:24 UTC (permalink / raw)
  To: Ahmad Draidi; +Cc: 69166-done

[-- Attachment #1: Type: text/plain, Size: 83 bytes --]

Patches applied as df5653adcbd1f9799f810f46d514b2ca4112af97 and
following.
Thanks.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-02-24 10:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-15 12:44 [bug#69166] [PATCH 0/2] Fix random test failures and update leptonica Ahmad Draidi via Guix-patches via
2024-02-15 12:55 ` [bug#69166] [PATCH 1/2] gnu: leptonica: Fix random test failures Ahmad Draidi via Guix-patches via
2024-02-15 12:55 ` [bug#69166] [PATCH 2/2] gnu: leptonica: Update to 1.84.1 Ahmad Draidi via Guix-patches via
2024-02-24 10:24 ` bug#69166: [PATCH 0/2] Fix random test failures and update leptonica Guillaume Le Vaillant

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).