[bug#27477] [PATCH] gnu: acl: Enable tests.

[bug#27477] [PATCH] gnu: acl: Enable tests.

[Kei Kebreau]

* gnu/packages/acl.scm (acl)[arguments]: Enable tests. Add 'patch-tests' phase.
---
 gnu/packages/acl.scm | 23 +++++++++++++++++------
 1 file changed, 17 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/acl.scm b/gnu/packages/acl.scm
index ae6764993..34f8c294a 100644
--- a/gnu/packages/acl.scm
+++ b/gnu/packages/acl.scm
@@ -44,19 +44,30 @@
       (patches (search-patches "acl-hurd-path-max.patch"))))
     (build-system gnu-build-system)
     (arguments
-     `(#:tests? #f   ; FIXME: Investigate test suite failures
-       #:test-target "tests"
+     `(#:test-target "tests"
        #:phases
         (alist-cons-after
          'build 'patch-exec-bin-sh
          (lambda _
            (substitute* "test/run"
              (("/bin/sh") (which "sh"))))
-         (alist-replace
-          'install
+         (alist-cons-before
+          'check 'patch-tests
           (lambda _
-            (zero? (system* "make" "install" "install-lib" "install-dev")))
-          %standard-phases))))
+            ;; The coreutils do not have an ACL bit to remove from their
+            ;; output, so the sed expression that removes the bit is disabled.
+            (substitute* "test/sbits-restore.test"
+              (("\\| sed.*'") ""))
+            ;; These tests require the existence of a user named "bin", but
+            ;; this user does not exist within Guix's build environment.
+            (for-each (lambda (file)
+                        (delete-file (string-append "test/" file)))
+                      '("setfacl-X.test" "cp.test" "misc.test")))
+          (alist-replace
+           'install
+           (lambda _
+             (zero? (system* "make" "install" "install-lib" "install-dev")))
+           %standard-phases)))))
     (inputs `(("attr" ,attr)))
     (native-inputs
      `(("gettext" ,gettext-minimal)
-- 
2.13.1

[bug#27477] [PATCH] gnu: acl: Enable tests.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

On Sat, Jun 24, 2017 at 02:06:06PM -0400, Kei Kebreau wrote:
> * gnu/packages/acl.scm (acl)[arguments]: Enable tests. Add 'patch-tests' phase.

Great!

But we'll probably need to wait for the next core-updates cycle. I've
applied to locally to a core-updates-next branch but it would be great
if you kept it around for the next cycle :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#27477] [PATCH] gnu: acl: Enable tests.

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Sat, Jun 24, 2017 at 02:06:06PM -0400, Kei Kebreau wrote:
>> * gnu/packages/acl.scm (acl)[arguments]: Enable tests. Add
>> 'patch-tests' phase.
>
> Great!
>
> But we'll probably need to wait for the next core-updates cycle. I've
> applied to locally to a core-updates-next branch but it would be great
> if you kept it around for the next cycle :)

Cool. I'll hold on to the patch!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#27477] [PATCH] gnu: acl: Enable tests.

[Ludovic Courtès]

Kei Kebreau <kei@openmailbox.org> skribis:

> Leo Famulari <leo@famulari.name> writes:
>
>> On Sat, Jun 24, 2017 at 02:06:06PM -0400, Kei Kebreau wrote:
>>> * gnu/packages/acl.scm (acl)[arguments]: Enable tests. Add
>>> 'patch-tests' phase.
>>
>> Great!
>>
>> But we'll probably need to wait for the next core-updates cycle. I've
>> applied to locally to a core-updates-next branch but it would be great
>> if you kept it around for the next cycle :)
>
> Cool. I'll hold on to the patch!

Now is the time to try the patch on ‘core-updates’!

Ludo’.

[bug#27477] [PATCH] gnu: acl: Enable tests.

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 827 bytes --]

ludo@gnu.org (Ludovic Courtès) writes:

> Kei Kebreau <kei@openmailbox.org> skribis:
>
>> Leo Famulari <leo@famulari.name> writes:
>>
>>> On Sat, Jun 24, 2017 at 02:06:06PM -0400, Kei Kebreau wrote:
>>>> * gnu/packages/acl.scm (acl)[arguments]: Enable tests. Add
>>>> 'patch-tests' phase.
>>>
>>> Great!
>>>
>>> But we'll probably need to wait for the next core-updates cycle. I've
>>> applied to locally to a core-updates-next branch but it would be great
>>> if you kept it around for the next cycle :)
>>
>> Cool. I'll hold on to the patch!
>
> Now is the time to try the patch on ‘core-updates’!
>
> Ludo’.

Aw, I missed this becuase of my email migration. I'll catch it next time
as long as this message makes it to kkebreau@posteo.net instead of
kei@openmailbox.org.

Thanks in advance.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

bug#27477: [PATCH] gnu: acl: Enable tests.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]

On Thu, Sep 14, 2017 at 09:46:33AM -0400, Kei Kebreau wrote:
> ludo@gnu.org (Ludovic Courtès) writes:
> 
> > Kei Kebreau <kei@openmailbox.org> skribis:
> >
> >> Leo Famulari <leo@famulari.name> writes:
> >>
> >>> On Sat, Jun 24, 2017 at 02:06:06PM -0400, Kei Kebreau wrote:
> >>>> * gnu/packages/acl.scm (acl)[arguments]: Enable tests. Add
> >>>> 'patch-tests' phase.
> >>>
> >>> Great!
> >>>
> >>> But we'll probably need to wait for the next core-updates cycle. I've
> >>> applied to locally to a core-updates-next branch but it would be great
> >>> if you kept it around for the next cycle :)
> >>
> >> Cool. I'll hold on to the patch!
> >
> > Now is the time to try the patch on ‘core-updates’!
> >
> > Ludo’.
> 
> Aw, I missed this becuase of my email migration. I'll catch it next time
> as long as this message makes it to kkebreau@posteo.net instead of
> kei@openmailbox.org.
> 
> Thanks in advance.

I amended this patch to apply and pushed it as
2d433b5363fecba0d63caa1844c937dec4ccc23b.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#27477] [PATCH] gnu: acl: Enable tests.

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 1128 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Thu, Sep 14, 2017 at 09:46:33AM -0400, Kei Kebreau wrote:
>> ludo@gnu.org (Ludovic Courtès) writes:
>> 
>> > Kei Kebreau <kei@openmailbox.org> skribis:
>> >
>> >> Leo Famulari <leo@famulari.name> writes:
>> >>
>> >>> On Sat, Jun 24, 2017 at 02:06:06PM -0400, Kei Kebreau wrote:
>> >>>> * gnu/packages/acl.scm (acl)[arguments]: Enable tests. Add
>> >>>> 'patch-tests' phase.
>> >>>
>> >>> Great!
>> >>>
>> >>> But we'll probably need to wait for the next core-updates cycle. I've
>> >>> applied to locally to a core-updates-next branch but it would be great
>> >>> if you kept it around for the next cycle :)
>> >>
>> >> Cool. I'll hold on to the patch!
>> >
>> > Now is the time to try the patch on ‘core-updates’!
>> >
>> > Ludo’.
>> 
>> Aw, I missed this becuase of my email migration. I'll catch it next time
>> as long as this message makes it to kkebreau@posteo.net instead of
>> kei@openmailbox.org.
>> 
>> Thanks in advance.
>
> I amended this patch to apply and pushed it as
> 2d433b5363fecba0d63caa1844c937dec4ccc23b.

Thank you!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]