[bug#29880] [PATCH] gnu: grep: Add PCRE support.

[bug#29880] [PATCH] gnu: grep: Add PCRE support.

[Oleg Pykhalov]

[-- Attachment #1.1: Type: text/plain, Size: 70 bytes --]

Hello Guix,

This patch allows to grep with perl regular expression.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: [PATCH] gnu: grep: Add PCRE support. --]
[-- Type: text/x-patch, Size: 1180 bytes --]

From db4fe96c7c6c0fcaa82e1131aba157c5d5e5f537 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Thu, 28 Dec 2017 22:12:13 +0300
Subject: [PATCH] gnu: grep: Add PCRE support.

* gnu/packages/base.scm (grep)[inputs]: New field.
---
 gnu/packages/base.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm
index 9cb628d8d..2b439e958 100644
--- a/gnu/packages/base.scm
+++ b/gnu/packages/base.scm
@@ -40,6 +40,7 @@
   #:use-module (gnu packages linux)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages hurd)
+  #:use-module (gnu packages pcre)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages gettext)
   #:use-module (guix utils)
@@ -92,6 +93,7 @@ command-line arguments, multiple languages, and so on.")
             (patches (search-patches "grep-timing-sensitive-test.patch"
                                      "grep-gnulib-lock.patch"))))
    (build-system gnu-build-system)
+   (inputs `(("pcre" ,pcre)))
    (native-inputs `(("perl" ,perl)))             ;some of the tests require it
    (arguments
     `(#:phases
-- 
2.15.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#29880] [PATCH] gnu: grep: Add PCRE support.

[Ludovic Courtès]

Hi Oleg,

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> This patch allows to grep with perl regular expression.
>
> From db4fe96c7c6c0fcaa82e1131aba157c5d5e5f537 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Thu, 28 Dec 2017 22:12:13 +0300
> Subject: [PATCH] gnu: grep: Add PCRE support.
>
> * gnu/packages/base.scm (grep)[inputs]: New field.

This would be for the next ‘core-updates’.  Did you try a full rebuild?

I’m mildly wary of this change because PCRE is a non-trivial piece of
software that increases the attack surface, and we’d end up grafting
things potentially often.  For instance, right now I get:

  $ guix lint pcre
  gnu/packages/pcre.scm:77:2: pcre@8.41: probably vulnerable to CVE-2017-11164

Would it make sense to instead have a separate “grep-pcre”?

What do people think?

Thanks,
Ludo’.

[bug#29880] [PATCH] gnu: grep: Add PCRE support.

[Roel Janssen]

Ludovic Courtès writes:

> Hi Oleg,
>
> Oleg Pykhalov <go.wigust@gmail.com> skribis:
>
>> This patch allows to grep with perl regular expression.
>>
>> From db4fe96c7c6c0fcaa82e1131aba157c5d5e5f537 Mon Sep 17 00:00:00 2001
>> From: Oleg Pykhalov <go.wigust@gmail.com>
>> Date: Thu, 28 Dec 2017 22:12:13 +0300
>> Subject: [PATCH] gnu: grep: Add PCRE support.
>>
>> * gnu/packages/base.scm (grep)[inputs]: New field.
>
> This would be for the next ‘core-updates’.  Did you try a full rebuild?
>
> I’m mildly wary of this change because PCRE is a non-trivial piece of
> software that increases the attack surface, and we’d end up grafting
> things potentially often.  For instance, right now I get:
>
>   $ guix lint pcre
>   gnu/packages/pcre.scm:77:2: pcre@8.41: probably vulnerable to CVE-2017-11164
>
> Would it make sense to instead have a separate “grep-pcre”?
>
> What do people think?

I have been maintaining a separate package for grep with PCRE support
for the users on our cluster.  What I would like to add is that at least
Debian and RedHat enable PCRE in their grep versions.  So using Guix's
grep broke some scripts.

If compatibility with other GNU/Linux distributions counts for anything,
I'd say we should enable it.  I am in favor of enabling PCRE.

We could provide a separate version of grep without PCRE as a
grep-minimal.

Thanks for your time!

Kind regards,
Roel Janssen

[bug#29880] [PATCH] gnu: grep: Add PCRE support.

[Ludovic Courtès]

Hello,

Roel Janssen <roel@gnu.org> skribis:

> I have been maintaining a separate package for grep with PCRE support
> for the users on our cluster.  What I would like to add is that at least
> Debian and RedHat enable PCRE in their grep versions.  So using Guix's
> grep broke some scripts.
>
> If compatibility with other GNU/Linux distributions counts for anything,
> I'd say we should enable it.  I am in favor of enabling PCRE.

OK, that makes sense.

> We could provide a separate version of grep without PCRE as a
> grep-minimal.

Alternately, what we could do is:

  1. Keep ‘grep-final’ as it is right now (without PCRE support; this
     has never been a problem so far.)

  2. Add PCRE to ‘grep’ itself (like Oleg did).

Thoughts?

Ludo’.

[bug#29880] [PATCH] gnu: grep: Add PCRE support.

[Roel Janssen]

Ludovic Courtès writes:

> Hello,
>
> Roel Janssen <roel@gnu.org> skribis:
>
>> I have been maintaining a separate package for grep with PCRE support
>> for the users on our cluster.  What I would like to add is that at least
>> Debian and RedHat enable PCRE in their grep versions.  So using Guix's
>> grep broke some scripts.
>>
>> If compatibility with other GNU/Linux distributions counts for anything,
>> I'd say we should enable it.  I am in favor of enabling PCRE.
>
> OK, that makes sense.
>
>> We could provide a separate version of grep without PCRE as a
>> grep-minimal.
>
> Alternately, what we could do is:
>
>   1. Keep ‘grep-final’ as it is right now (without PCRE support; this
>      has never been a problem so far.)
>
>   2. Add PCRE to ‘grep’ itself (like Oleg did).
>
> Thoughts?

Yes that seems fine to me.

Kind regards,
Roel Janssen

bug#29880: [PATCH] gnu: grep: Add PCRE support.

[Ludovic Courtès]

Hi,

Roel Janssen <roel@gnu.org> skribis:

> Ludovic Courtès writes:

[...]

>> Alternately, what we could do is:
>>
>>   1. Keep ‘grep-final’ as it is right now (without PCRE support; this
>>      has never been a problem so far.)
>>
>>   2. Add PCRE to ‘grep’ itself (like Oleg did).
>>
>> Thoughts?
>
> Yes that seems fine to me.

Done in 20bf5fce7dbdc754a6c430abbeb50fb0662bda38.

Thanks!

Ludo'.