[bug#30211] [PATCH 3/4] gnu: Add python-pycryptodome.

[Oleg Pykhalov <go.wigust@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 3052 bytes --]

Hello Leo,

Thank you for review!  I applied all and attached a new patch.

Leo Famulari <leo@famulari.name> writes:

> On Mon, Jan 22, 2018 at 11:05:24PM +0300, Oleg Pykhalov wrote:
>> * gnu/packages/python-crypto.scm (python-pycryptodome): New public variable.
>
>> +(define-public python-pycryptodome
>> +  (package
>> +    ;; XXX: Skipping GMP tests which requires not packaged 'mpir' library.
>> +    (name "python-pycryptodome")
>
> I don't understand this comment.

This is a quote from a build log.  See:
--8<---------------cut here---------------start------------->8---
starting phase `check'
running "python setup.py" with command "test" and parameters ()
running test
running build
running build_py
running build_ext
Skipping GMP tests (Cannot load library 'mpir')
Compiling support for Intel AES instructions
Crypto.Math implementation: {}

----------------------------------------------------------------------
Ran 22598 tests in 75.857s

OK
phase `check' succeeded after 84.6 seconds
--8<---------------cut here---------------end--------------->8---

Do you have an idea how to make it more clear?

>> +    (home-page "http://www.pycryptodome.org")
>
> Please use HTTPS here.

Oh, sure.  Thanks.

>> +    (synopsis "Cryptographic library for Python")
>> +    (description "This package provides a cryptographic library for Python.")
>
> If possible, please give a little more information in the description.
> I'm specifically interested in how this library differs from the Python
> 'cryptography' library.

Dunno about 'pycryptodome' Vs Python 'cryptography', but 'pycryptodome'
is a fork of PyCrypto.

From <https://www.pycryptodome.org/en/latest/src/introduction.html>:

    PyCryptodome is a fork of PyCrypto. It brings the following
    enhancements with respect to the last official version of PyCrypto
    (2.6.1):

        - Authenticated encryption modes (GCM, CCM, EAX, SIV, OCB)
        - Accelerated AES on Intel platforms via AES-NI
        - First class support for PyPy
        - Elliptic curves cryptography (NIST P-256 curve only)
        - Better and more compact API (nonce and iv attributes for
          ciphers, automatic generation of random nonces and IVs,
          simplified CTR cipher mode, and more)
        - SHA-3 (including SHAKE XOFs) and BLAKE2 hash algorithms
        - Salsa20 and ChaCha20 stream ciphers
        - scrypt and HKDF
        - Deterministic (EC)DSA
        - Password-protected PKCS#8 key containers
        - Shamir’s Secret Sharing scheme
        - Random numbers get sourced directly from the OS (and not from a
          CSPRNG in userspace)
        - Simplified install process, including better support for
          Windows
        - Cleaner RSA and DSA key generation (largely based on FIPS
          186-4)
        - Major clean ups and simplification of the code base

I pasted this into the description except:

        - Simplified install process, including better support for Windows



[-- Attachment #1.2: [PATCH 3/4] gnu: Add python-pycryptodome. --]
[-- Type: text/x-patch, Size: 2496 bytes --]

From 2318cf980af1b46ec4d3a57d1c8dde3a157b1a0e Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Fri, 19 Jan 2018 22:58:50 +0300
Subject: [PATCH] gnu: Add python-pycryptodome.

* gnu/packages/python-crypto.scm (python-pycryptodome): New public variable.
---
 gnu/packages/python-crypto.scm | 44 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/python-crypto.scm b/gnu/packages/python-crypto.scm
index a545f0ddc..213ff69a9 100644
--- a/gnu/packages/python-crypto.scm
+++ b/gnu/packages/python-crypto.scm
@@ -715,3 +715,47 @@ protocol (Javascript Object Signing and Encryption).")
 
 (define-public python2-josepy
   (package-with-python2 python-josepy))
+
+(define-public python-pycryptodome
+  (package
+    ;; XXX: Skipping GMP tests which requires not packaged 'mpir' library.
+    (name "python-pycryptodome")
+    (version "3.4.7")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pycryptodome" version))
+       (sha256
+        (base32
+         "1xrsd6ql4w0ypkxnsg3fivs3r3z6dd93x44lhvam7jzh3gixzn0q"))))
+    (build-system python-build-system)
+    (home-page "https://www.pycryptodome.org")
+    (synopsis "Cryptographic library for Python")
+    (description "This package provides a cryptographic library for Python.
+
+It brings the following enhancements with respect to the last official version
+of PyCrypto:
+
+@itemize
+@item Authenticated encryption modes (GCM, CCM, EAX, SIV, OCB)
+@item Accelerated AES on Intel platforms via AES-NI
+@item First class support for PyPy
+@item Elliptic curves cryptography (NIST P-256 curve only)
+@item Better and more compact API (nonce and iv attributes for ciphers,
+automatic generation of random nonces and IVs, simplified CTR cipher mode, and
+more)
+@item SHA-3 (including SHAKE XOFs) and BLAKE2 hash algorithms
+@item Salsa20 and ChaCha20 stream ciphers
+@item scrypt and HKDF
+@item Deterministic (EC)DSA
+@item Password-protected PKCS#8 key containers
+@item Shamir’s Secret Sharing scheme
+@item Random numbers get sourced directly from the OS (and not from a CSPRNG
+in userspace)
+@item Cleaner RSA and DSA key generation (largely based on FIPS 186-4)
+@item Major clean ups and simplification of the code base
+@end itemize\n")
+    (license license:bsd-2)))
+
+(define-public python2-pycryptodome
+  (package-with-python2 python-pycryptodome))
-- 
2.15.1


[-- Attachment #1.3: Type: text/plain, Size: 8 bytes --]



Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]