Hello Leo,

Thank you for review!  I applied all and attached a new patch.

Leo Famulari <leo@famulari.name> writes:

> On Mon, Jan 22, 2018 at 11:05:24PM +0300, Oleg Pykhalov wrote:
>> * gnu/packages/python-crypto.scm (python-pycryptodome): New public variable.
>
>> +(define-public python-pycryptodome
>> +  (package
>> +    ;; XXX: Skipping GMP tests which requires not packaged 'mpir' library.
>> +    (name "python-pycryptodome")
>
> I don't understand this comment.

This is a quote from a build log.  See:
--8<---------------cut here---------------start------------->8---
starting phase `check'
running "python setup.py" with command "test" and parameters ()
running test
running build
running build_py
running build_ext
Skipping GMP tests (Cannot load library 'mpir')
Compiling support for Intel AES instructions
Crypto.Math implementation: {}

----------------------------------------------------------------------
Ran 22598 tests in 75.857s

OK
phase `check' succeeded after 84.6 seconds
--8<---------------cut here---------------end--------------->8---

Do you have an idea how to make it more clear?

>> +    (home-page "http://www.pycryptodome.org")
>
> Please use HTTPS here.

Oh, sure.  Thanks.

>> +    (synopsis "Cryptographic library for Python")
>> +    (description "This package provides a cryptographic library for Python.")
>
> If possible, please give a little more information in the description.
> I'm specifically interested in how this library differs from the Python
> 'cryptography' library.

Dunno about 'pycryptodome' Vs Python 'cryptography', but 'pycryptodome'
is a fork of PyCrypto.

From <https://www.pycryptodome.org/en/latest/src/introduction.html>:

    PyCryptodome is a fork of PyCrypto. It brings the following
    enhancements with respect to the last official version of PyCrypto
    (2.6.1):

        - Authenticated encryption modes (GCM, CCM, EAX, SIV, OCB)
        - Accelerated AES on Intel platforms via AES-NI
        - First class support for PyPy
        - Elliptic curves cryptography (NIST P-256 curve only)
        - Better and more compact API (nonce and iv attributes for
          ciphers, automatic generation of random nonces and IVs,
          simplified CTR cipher mode, and more)
        - SHA-3 (including SHAKE XOFs) and BLAKE2 hash algorithms
        - Salsa20 and ChaCha20 stream ciphers
        - scrypt and HKDF
        - Deterministic (EC)DSA
        - Password-protected PKCS#8 key containers
        - Shamir’s Secret Sharing scheme
        - Random numbers get sourced directly from the OS (and not from a
          CSPRNG in userspace)
        - Simplified install process, including better support for
          Windows
        - Cleaner RSA and DSA key generation (largely based on FIPS
          186-4)
        - Major clean ups and simplification of the code base

I pasted this into the description except:

        - Simplified install process, including better support for Windows