unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: iyzsong@member.fsf.org (宋文武)
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 36738-done@debbugs.gnu.org
Subject: bug#36738: [PATCH] guix deploy: Support '--no-grafts' and '--system'
Date: Wed, 24 Jul 2019 20:36:11 +0800	[thread overview]
Message-ID: <87wog7zk1w.fsf@member.fsf.org> (raw)
In-Reply-To: <87d0i01ltd.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 23 Jul 2019 23:29:50 +0200")

Ludovic Courtès <ludo@gnu.org> writes:

> Hello,
>
> zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) skribis:
>
>> Hello Wenwu,
>> iyzsong@member.fsf.org (宋文武) writes:
>>
>>> Hello, this patch handle the '--no-grafts' command line option:
>>> ...
>>> And '--system', so I can deploy a "i686-linux" from my "x86_64-linux":
>>
>> These patches look good to me, thank you!
>>
>> Ludo, Dave, Chris, any additional comments?
>
> Fine with me!
>
> I agree with Dave that we should avoid adding a ‘system-type’ field to
> <machine>, at least for now.  Instead, we should just honor
> (%current-system).
>
> Thanks,
> Ludo’.

Pushed, thanks for the reviews!

      reply	other threads:[~2019-07-24 12:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-20  5:05 [bug#36738] [PATCH] guix deploy: Support '--no-grafts' and '--system' 宋文武
2019-07-22 16:48 ` Jakob L. Kreuze
2019-07-22 22:46   ` Jakob L. Kreuze
2019-07-23 16:45     ` Christopher Lemmer Webber
2019-07-23 19:33       ` Jakob L. Kreuze
2019-07-23 21:59       ` Ricardo Wurmus
2019-07-24  0:11         ` Jakob L. Kreuze
2019-07-23 17:05     ` Thompson, David
2019-07-23 19:35       ` Jakob L. Kreuze
2019-07-23 16:44   ` Christopher Lemmer Webber
2019-07-23 21:29   ` Ludovic Courtès
2019-07-24 12:36     ` 宋文武 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wog7zk1w.fsf@member.fsf.org \
    --to=iyzsong@member.fsf.org \
    --cc=36738-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).