unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze)
To: 宋文武 <iyzsong@member.fsf.org>
Cc: 36738@debbugs.gnu.org
Subject: [bug#36738] [PATCH] guix deploy: Support '--no-grafts' and '--system'
Date: Mon, 22 Jul 2019 12:48:01 -0400	[thread overview]
Message-ID: <874l3eauda.fsf@sdf.lonestar.org> (raw)
In-Reply-To: <87a7d9l2hw.fsf@member.fsf.org> ("宋文武"'s message of "Sat, 20 Jul 2019 13:05:31 +0800")

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

Hello Wenwu,
iyzsong@member.fsf.org (宋文武) writes:

> Hello, this patch handle the '--no-grafts' command line option:
> ...
> And '--system', so I can deploy a "i686-linux" from my "x86_64-linux":

These patches look good to me, thank you!

Ludo, Dave, Chris, any additional comments?

> Or better we can add a 'system' field to the <machine> record, so we
> can deploy a list of machines with different 'system'. Currently a
> <machine> has 'system' as a field for the <operating-system>, so where
> to put this machine/arch 'system'...

Great idea. I think that continuing to call the machine's
<operating-system> 'system' would be confusing if we introduced the
notion of a target architecture, because we use "system" to refer to the
target architecture in the rest of Guix's command-line tools. Maybe it
would make sense to rename the <operating-system> field to 'os' or
something similar, and use the 'system' field to specify the target
architecture instead? Any thoughs?

Regards,
Jakob

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2019-07-22 16:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-20  5:05 [bug#36738] [PATCH] guix deploy: Support '--no-grafts' and '--system' 宋文武
2019-07-22 16:48 ` Jakob L. Kreuze [this message]
2019-07-22 22:46   ` Jakob L. Kreuze
2019-07-23 16:45     ` Christopher Lemmer Webber
2019-07-23 19:33       ` Jakob L. Kreuze
2019-07-23 21:59       ` Ricardo Wurmus
2019-07-24  0:11         ` Jakob L. Kreuze
2019-07-23 17:05     ` Thompson, David
2019-07-23 19:35       ` Jakob L. Kreuze
2019-07-23 16:44   ` Christopher Lemmer Webber
2019-07-23 21:29   ` Ludovic Courtès
2019-07-24 12:36     ` bug#36738: " 宋文武

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874l3eauda.fsf@sdf.lonestar.org \
    --to=zerodaysfordays@sdf.lonestar.org \
    --cc=36738@debbugs.gnu.org \
    --cc=iyzsong@member.fsf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).