* [bug#49244] [PATCH] gnu: grub-efi: Only enable the stack protector on x86_64-linux.
@ 2021-06-27 18:47 Christopher Baines
2021-06-29 15:36 ` Mathieu Othacehe
0 siblings, 1 reply; 4+ messages in thread
From: Christopher Baines @ 2021-06-27 18:47 UTC (permalink / raw)
To: 49244
Follow up to 018f95094153660e3041ec160718f0bda286a3dc, as gcc on aarch64-linux
doesn't seem to support -mstack-protector-guard=global.
* gnu/packages/bootloaders.scm (grub-efi)[arguments]: Only add
"--enable-stack-protector" to #:configure-flags when system is x86_64-linux.
---
gnu/packages/bootloaders.scm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
index e83f21ea63..1ff0348ac7 100644
--- a/gnu/packages/bootloaders.scm
+++ b/gnu/packages/bootloaders.scm
@@ -303,7 +303,10 @@ menu to select one of the installed operating systems.")
((#:tests? _ #f) #f)
((#:configure-flags flags ''())
`(cons* "--with-platform=efi"
- "--enable-stack-protector" ; EFI-only for now
+ ,@(if (string=? (%current-system)
+ "x86_64-linux")
+ '("--enable-stack-protector") ; EFI-only for now
+ '())
,flags))
((#:phases phases)
`(modify-phases ,phases
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#49244] [PATCH] gnu: grub-efi: Only enable the stack protector on x86_64-linux.
2021-06-27 18:47 [bug#49244] [PATCH] gnu: grub-efi: Only enable the stack protector on x86_64-linux Christopher Baines
@ 2021-06-29 15:36 ` Mathieu Othacehe
2021-06-30 15:14 ` Maxime Devos
2021-07-01 23:30 ` bug#49244: " Christopher Baines
0 siblings, 2 replies; 4+ messages in thread
From: Mathieu Othacehe @ 2021-06-29 15:36 UTC (permalink / raw)
To: Christopher Baines; +Cc: 49244
Hey Chris,
> + ,@(if (string=? (%current-system)
> + "x86_64-linux")
> + '("--enable-stack-protector") ; EFI-only for now
> + '())
Maybe we should also avoid this option when cross-compiling? Otherwise
it looks OK.
Thanks,
Mathieu
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#49244] [PATCH] gnu: grub-efi: Only enable the stack protector on x86_64-linux.
2021-06-29 15:36 ` Mathieu Othacehe
@ 2021-06-30 15:14 ` Maxime Devos
2021-07-01 23:30 ` bug#49244: " Christopher Baines
1 sibling, 0 replies; 4+ messages in thread
From: Maxime Devos @ 2021-06-30 15:14 UTC (permalink / raw)
To: Mathieu Othacehe, Christopher Baines; +Cc: 49244
[-- Attachment #1: Type: text/plain, Size: 556 bytes --]
Mathieu Othacehe schreef op di 29-06-2021 om 17:36 [+0200]:
> Hey Chris,
>
> > + ,@(if (string=? (%current-system)
> > + "x86_64-linux")
> > + '("--enable-stack-protector") ; EFI-only for now
> > + '())
>
> Maybe we should also avoid this option when cross-compiling? Otherwise
> it looks OK.
Or rather,
(string-prefix? (or (%current-target-system) (%current-system)) "x86_64")
(or was it the other way around)?
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#49244: [PATCH] gnu: grub-efi: Only enable the stack protector on x86_64-linux.
2021-06-29 15:36 ` Mathieu Othacehe
2021-06-30 15:14 ` Maxime Devos
@ 2021-07-01 23:30 ` Christopher Baines
1 sibling, 0 replies; 4+ messages in thread
From: Christopher Baines @ 2021-07-01 23:30 UTC (permalink / raw)
To: 49244-done; +Cc: Mathieu Othacehe
[-- Attachment #1: Type: text/plain, Size: 602 bytes --]
Mathieu Othacehe <othacehe@gnu.org> writes:
> Hey Chris,
>
>> + ,@(if (string=? (%current-system)
>> + "x86_64-linux")
>> + '("--enable-stack-protector") ; EFI-only for now
>> + '())
>
> Maybe we should also avoid this option when cross-compiling? Otherwise
> it looks OK.
Yeah, I was trying to test the cross-compiling case, but I think
something else fails regardless. Anyway, I've pushed something similar
to what Maxime suggested as fd549750d9ab23a0505aeb4c03e1299e860a4f16.
Thanks,
CHris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-01 23:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-27 18:47 [bug#49244] [PATCH] gnu: grub-efi: Only enable the stack protector on x86_64-linux Christopher Baines
2021-06-29 15:36 ` Mathieu Othacehe
2021-06-30 15:14 ` Maxime Devos
2021-07-01 23:30 ` bug#49244: " Christopher Baines
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).