unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: 39961-done@debbugs.gnu.org, Christopher Baines <mail@cbaines.net>
Subject: bug#39961: [PATCH] gnu: Add traceroute.
Date: Tue, 13 Jul 2021 23:15:04 -0400	[thread overview]
Message-ID: <87wnptpow7.fsf_-_@gmail.com> (raw)
In-Reply-To: <20210111163240.20986-1-vincent.legoll@gmail.com> (Vincent Legoll's message of "Mon, 11 Jan 2021 17:32:40 +0100")

Hello,

Vincent Legoll <vincent.legoll@gmail.com> writes:

> * gnu/packages/networking.scm (traceroute): New variable.
> ---
>  gnu/packages/networking.scm | 39 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 39 insertions(+)
>
> diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
> index 83a99ded72..4c3faaa578 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -3680,6 +3680,45 @@ simulation, and a number of other applications.")
>  network.  This must be enabled on the target host, usually in the BIOS.")
>      (license license:gpl2)))
>  
> +(define-public traceroute
> +  (package
> +    (name "traceroute")
> +    (version "2.1.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "mirror://sourceforge/traceroute/traceroute/"
> +                           "traceroute-" version "/traceroute-" version ".tar.gz"))
> +       (sha256
> +        (base32 "1dh32vcfawkl1p9g4ral1p0camds4paqr8db1kaqxwyk6hmd4s9n"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f                      ; No tests.
> +       #:make-flags
> +       (list (string-append "LIBRARY_PATH="
> +                            (assoc-ref %build-inputs "libc")           "/lib")
> +             (string-append "CFLAGS=-I"
> +                            (assoc-ref %build-inputs "kernel-headers") "/include")
> +             "LDFLAGS=-lm -L../libsupp"
> +             (string-append "prefix=" (assoc-ref %outputs "out")))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-make
> +           (lambda _
> +             (substitute* "default.rules"
> +               ((" \\$\\(LIBDEPS\\)") "$(filter-out -l%,$(LIBDEPS))"))
> +             #t))
> +         (delete 'bootstrap)           ; there is no configure.ac file
> +         (delete 'configure))))        ; there is no configure script
> +    (home-page "http://traceroute.sourceforge.net/")
> +    (synopsis "Tracks the route taken by packets over an IP network")
> +    (description "Traceroute tracks the route packets taken from an IP network
> +on their way to a given host.  It utilizes the IP protocol's time to live (TTL)
> +field and attempts to elicit an ICMP TIME_EXCEEDED response from each gateway
> +along the path to the host.")
> +    (license '(license:gpl2+
> +               license:lgpl2.1+)))) ; for the libsupp subdirectory
> +
>  (define-public vde2
>    (package
>      (name "vde2")

I edited it to expound the description someone and for cosmetic reasons
(fitting in the 80 chars limit for example), like so:

--8<---------------cut here---------------start------------->8---
1 file changed, 18 insertions(+), 14 deletions(-)
gnu/packages/networking.scm | 32 ++++++++++++++++++--------------

modified   gnu/packages/networking.scm
@@ -3796,17 +3796,19 @@ network.  This must be enabled on the target host, usually in the BIOS.")
      (origin
        (method url-fetch)
        (uri (string-append "mirror://sourceforge/traceroute/traceroute/"
-                           "traceroute-" version "/traceroute-" version ".tar.gz"))
+                           "traceroute-" version "/traceroute-"
+                           version ".tar.gz"))
        (sha256
         (base32 "1dh32vcfawkl1p9g4ral1p0camds4paqr8db1kaqxwyk6hmd4s9n"))))
     (build-system gnu-build-system)
     (arguments
-     `(#:tests? #f                      ; No tests.
+     `(#:tests? #f                      ;no test suite
        #:make-flags
        (list (string-append "LIBRARY_PATH="
-                            (assoc-ref %build-inputs "libc")           "/lib")
+                            (assoc-ref %build-inputs "libc") "/lib")
              (string-append "CFLAGS=-I"
-                            (assoc-ref %build-inputs "kernel-headers") "/include")
+                            (assoc-ref %build-inputs "kernel-headers")
+                            "/include")
              "LDFLAGS=-lm -L../libsupp"
              (string-append "prefix=" (assoc-ref %outputs "out")))
        #:phases
@@ -3814,18 +3816,20 @@ network.  This must be enabled on the target host, usually in the BIOS.")
          (add-after 'unpack 'patch-make
            (lambda _
              (substitute* "default.rules"
-               ((" \\$\\(LIBDEPS\\)") "$(filter-out -l%,$(LIBDEPS))"))
-             #t))
-         (delete 'bootstrap)           ; there is no configure.ac file
-         (delete 'configure))))        ; there is no configure script
+               ((" \\$\\(LIBDEPS\\)") "$(filter-out -l%,$(LIBDEPS))"))))
+         (delete 'bootstrap)            ;no configure.ac file
+         (delete 'configure))))         ;no configure script
     (home-page "http://traceroute.sourceforge.net/")
     (synopsis "Tracks the route taken by packets over an IP network")
-    (description "Traceroute tracks the route packets taken from an IP network
-on their way to a given host.  It utilizes the IP protocol's time to live (TTL)
-field and attempts to elicit an ICMP TIME_EXCEEDED response from each gateway
-along the path to the host.")
-    (license '(license:gpl2+
-               license:lgpl2.1+)))) ; for the libsupp subdirectory
+    (description "This package provides a modern, but Linux-specific
+implementation of the @command{traceroute} command that can be used to follow
+the route taken by packets on an IP network on their way to a given host.  It
+utilizes the IP protocol's time to live (TTL) field and attempts to elicit an
+ICMP TIME_EXCEEDED response from each gateway along the path to the host.
+Compared to other implementations, this @command{traceroute} command allows
+some traces for unprivileged users.")
+    (license (list license:gpl2+
+                   license:lgpl2.1+)))) ;for the libsupp subdirectory
 
 (define-public vde2
   (package
--8<---------------cut here---------------end--------------->8---

And pushed as 59e97a67ba.

Thank you!

Closing.

Maxim




      reply	other threads:[~2021-07-14  3:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-06 23:13 [bug#39961] [PATCH] gnu: Add traceroute Vincent Legoll
2020-03-07  1:28 ` Vincent Legoll
2020-03-07 11:06 ` Vincent Legoll
2020-03-07 11:08 ` Vincent Legoll
2020-03-07 13:09 ` Leo Famulari
2020-03-07 13:23   ` Vincent Legoll
2020-12-28 14:45 ` [bug#39961] traceroute Vincent Legoll
2021-01-01 12:08   ` Christopher Baines
2021-01-11 16:31 ` [bug#39961] New patch Vincent Legoll
2021-01-11 16:31 ` [bug#39961] [PATCH] gnu: Add traceroute Vincent Legoll
2021-01-11 16:32 ` Vincent Legoll
2021-07-14  3:15   ` Maxim Cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnptpow7.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=39961-done@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    --cc=vincent.legoll@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).