From: Christopher Baines <mail@cbaines.net>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: 39961@debbugs.gnu.org
Subject: [bug#39961] traceroute
Date: Fri, 01 Jan 2021 12:08:01 +0000 [thread overview]
Message-ID: <87o8i897xa.fsf@cbaines.net> (raw)
In-Reply-To: <CAEwRq=ppPXpJRp6E0ttCB1OWhj+LapuyauE8=f4+RqpushYQDw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]
Vincent Legoll <vincent.legoll@gmail.com> writes:
> ping ?
>
> Anything I should add ?
This traceroute implementation looks to be particularly difficult to
build, just searching the web for some of the errors brings up other
people having problems with it (like [1]).
1: https://patchwork.ozlabs.org/project/buildroot/patch/1539902241-10211-1-git-send-email-sergio.prado@e-labworks.com/
Some comments though, I'd suggest transforming what you're doing with
make flags from modifying the phases to adding to the #:make-flags
argument, so something like this:
#:make-flags
(list (string-append "LIBRARY_PATH="
(assoc-ref %build-inputs "libc")
"/lib")
(string-append "CFLAGS=-I"
(assoc-ref %build-inputs "kernel-headers")
"/include")
"LDFLAGS=-lm -L../libsupp"
(string-append "prefix=" (assoc-ref %outputs "out")))
What I've also done here is used the %build-inputs alist, which includes
the implicit libc and kernel-headers inputs, so you can remove those
inputs from the package definition.
As for the -lm issue with the Makefile, that's pretty frustrating. The
best thing I could come up with is something like this:
(substitute* "default.rules"
((" \\$\\(LIBDEPS\\)") "$(filter-out -l%,$(LIBDEPS))"))
That has the advantage of still passing the -lm flag to gcc, and just
avoiding make tripping up over it.
Finally, I think the license might be gpl2+, with lgpl2.1+ for libsupp,
so it would be good to list both of those, with a comment describing
what the lgpl license applies to.
Could you send an updated patch?
Thanks,
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
next prev parent reply other threads:[~2021-01-01 12:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 23:13 [bug#39961] [PATCH] gnu: Add traceroute Vincent Legoll
2020-03-07 1:28 ` Vincent Legoll
2020-03-07 11:06 ` Vincent Legoll
2020-03-07 11:08 ` Vincent Legoll
2020-03-07 13:09 ` Leo Famulari
2020-03-07 13:23 ` Vincent Legoll
2020-12-28 14:45 ` [bug#39961] traceroute Vincent Legoll
2021-01-01 12:08 ` Christopher Baines [this message]
2021-01-11 16:31 ` [bug#39961] New patch Vincent Legoll
2021-01-11 16:31 ` [bug#39961] [PATCH] gnu: Add traceroute Vincent Legoll
2021-01-11 16:32 ` Vincent Legoll
2021-07-14 3:15 ` bug#39961: " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8i897xa.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=39961@debbugs.gnu.org \
--cc=vincent.legoll@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).