* [bug#53525] [PATCH] gnu: Add emacs-puni
@ 2022-01-25 16:46 Niklas Eklund
2022-01-25 17:09 ` Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: Niklas Eklund @ 2022-01-25 16:46 UTC (permalink / raw)
To: 53525
[-- Attachment #1: Type: text/plain, Size: 55 bytes --]
Hi,
this patch adds the Emacs puni package.
/Niklas
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: emacs-puni --]
[-- Type: text/x-patch, Size: 1701 bytes --]
From db8621385ed0b3b60f24396732dfb94800732822 Mon Sep 17 00:00:00 2001
From: Niklas Eklund <niklas.eklund@posteo.net>
Date: Tue, 25 Jan 2022 17:42:48 +0100
Subject: [PATCH] gnu: Add emacs-puni
---
gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 387f1b93fd..205b6d84c6 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -633,6 +633,29 @@ (define-public emacs-paredit
when typing parentheses directly or commenting out code line by line.")
(license license:gpl3+)))
+(define-public emacs-puni
+ ;; No tagged release upstream
+ (let ((commit "ed4a863460329a3019c286ff382e2ddc0ffdc9d7") (revision "0"))
+ (package
+ (name "emacs-puni")
+ (version (git-version "0" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/AmaiKinono/puni")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "14lcqf0qdkq2rklx12v12qpgfahz2bpqmnl3bzcz5myawgjjcphd"))))
+ (build-system emacs-build-system)
+ (propagated-inputs (list emacs-with-editor))
+ (home-page "https://github.com/AmaiKinono/puni")
+ (synopsis "Parentheses Universalistic")
+ (description
+ "Structured editing (soft deletion, expression navigating & manipulating) that supports many major modes out of the box.")
+ (license license:gpl3+))))
+
(define-public emacs-project
(package
(name "emacs-project")
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#53525] [PATCH] gnu: Add emacs-puni
2022-01-25 16:46 [bug#53525] [PATCH] gnu: Add emacs-puni Niklas Eklund
@ 2022-01-25 17:09 ` Nicolas Goaziou
2022-01-25 17:18 ` Niklas Eklund
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2022-01-25 17:09 UTC (permalink / raw)
To: Niklas Eklund; +Cc: 53525
Hello,
Niklas Eklund <niklas.eklund@posteo.net> writes:
> Subject: [PATCH] gnu: Add emacs-puni
Thank you.
> +(define-public emacs-puni
> + ;; No tagged release upstream
> + (let ((commit "ed4a863460329a3019c286ff382e2ddc0ffdc9d7") (revision "0"))
Nitpick: could you add a newline character between (commit ...) and
(revision ...)?
> + (home-page "https://github.com/AmaiKinono/puni")
> + (synopsis "Parentheses Universalistic")
This synopsis is not very useful. Could you expound it a bit?
> + (description
> + "Structured editing (soft deletion, expression navigating & manipulating) that supports many major modes out of the box.")
Description are expected to consist of full sentences. I suggest:
Puni is an Emacs minor mode for structured editing: soft deletion,
expression navigating and manipulating. It supports many major modes
out of the box.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#53525] [PATCH] gnu: Add emacs-puni
2022-01-25 17:09 ` Nicolas Goaziou
@ 2022-01-25 17:18 ` Niklas Eklund
2022-01-25 20:53 ` bug#53525: " Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: Niklas Eklund @ 2022-01-25 17:18 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 53525
[-- Attachment #1: Type: text/plain, Size: 1213 bytes --]
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Hello,
>
> Niklas Eklund <niklas.eklund@posteo.net> writes:
>
>> Subject: [PATCH] gnu: Add emacs-puni
>
> Thank you.
>
>> +(define-public emacs-puni
>> + ;; No tagged release upstream
>> + (let ((commit "ed4a863460329a3019c286ff382e2ddc0ffdc9d7") (revision "0"))
>
> Nitpick: could you add a newline character between (commit ...) and
> (revision ...)?
Oops, how did that end up there, of course!
>> + (home-page "https://github.com/AmaiKinono/puni")
>> + (synopsis "Parentheses Universalistic")
>
> This synopsis is not very useful. Could you expound it a bit?
Will give it a go :)
>> + (description
>> + "Structured editing (soft deletion, expression navigating & manipulating) that supports many major modes out of the box.")
>
> Description are expected to consist of full sentences. I suggest:
>
> Puni is an Emacs minor mode for structured editing: soft deletion,
> expression navigating and manipulating. It supports many major modes
> out of the box.
>
> Could you send an updated patch?
>
> Regards,
> --
> Nicolas Goaziou
Absolutely, thanks for the feedback :)
Here is an updated patch.
Best regards,
Niklas
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: emacs-puni --]
[-- Type: text/x-patch, Size: 1761 bytes --]
From 7c1a30a2567d85bd10d6a767358bafa67f8fc610 Mon Sep 17 00:00:00 2001
From: Niklas Eklund <niklas.eklund@posteo.net>
Date: Tue, 25 Jan 2022 17:42:48 +0100
Subject: [PATCH] gnu: Add emacs-puni
---
gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 387f1b93fd..9d9adbb1e5 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -633,6 +633,32 @@ (define-public emacs-paredit
when typing parentheses directly or commenting out code line by line.")
(license license:gpl3+)))
+(define-public emacs-puni
+ ;; No tagged release upstream
+ (let ((commit "ed4a863460329a3019c286ff382e2ddc0ffdc9d7")
+ (revision "0"))
+ (package
+ (name "emacs-puni")
+ (version (git-version "0" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/AmaiKinono/puni")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "14lcqf0qdkq2rklx12v12qpgfahz2bpqmnl3bzcz5myawgjjcphd"))))
+ (build-system emacs-build-system)
+ (propagated-inputs (list emacs-with-editor))
+ (home-page "https://github.com/AmaiKinono/puni")
+ (synopsis "Emacs minor mode for structured editing")
+ (description
+ "Puni is an Emacs minor mode for structured editing: soft deletion,
+expression navigating and manipulating. It supports many major modes
+out of the box.")
+ (license license:gpl3+))))
+
(define-public emacs-project
(package
(name "emacs-project")
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#53525: [PATCH] gnu: Add emacs-puni
2022-01-25 17:18 ` Niklas Eklund
@ 2022-01-25 20:53 ` Nicolas Goaziou
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2022-01-25 20:53 UTC (permalink / raw)
To: Niklas Eklund; +Cc: 53525-done
Hello,
Niklas Eklund <niklas.eklund@posteo.net> writes:
> Here is an updated patch.
Applied. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-25 20:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-25 16:46 [bug#53525] [PATCH] gnu: Add emacs-puni Niklas Eklund
2022-01-25 17:09 ` Nicolas Goaziou
2022-01-25 17:18 ` Niklas Eklund
2022-01-25 20:53 ` bug#53525: " Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).