unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Sughosha <Sughosha@proton.me>
Cc: 58681@debbugs.gnu.org
Subject: [bug#58681] [PATCH] gnu: Add synthpod
Date: Tue, 25 Oct 2022 10:25:30 +0100	[thread overview]
Message-ID: <87wn8ofe0p.fsf@cbaines.net> (raw)
In-Reply-To: <D0Yk1G0jYgxZkFGBF0gB4894QtivLuoVpdRCHLbVBwhjvldD8HHWjjO3CZwH2rCUU_9o_Gh0hpA9brEvK2GQx-A_f2MlhTbTGWXjIK7tW-s=@proton.me>

[-- Attachment #1: Type: text/plain, Size: 3593 bytes --]


Sughosha via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/music.scm (synthpod): New variable.
> ---
>  gnu/packages/music.scm | 45 +++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 45 insertions(+)

Hey, thanks for the patch.

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                     (url "https://git.open-music-kontrollers.ch/lv2/synthpod")
> +                     ;; Version is not tagged but mentioned in VERSION file.
> +                     (commit "8273142cd702583cb3662fbe0e2fd5d4075ee703")))
> +              (sha256
> +                (base32
> +                 "120qsd090pwkc21g9a5mm0pjb0rqn1iy4rs5lx3fs0qf3wa7k6ri"))))

The linter should be telling you something about the source file not
containing the package name. I'd take a look at the file-name bit in
other package sources that also use git-fetch.

> +    (build-system meson-build-system)
> +    ;; Fontconfig error: No writable cache directories
> +    (arguments (list #:tests? #f))

The cache directory bit is a hint, as that's often within the users home
directory. The build environment uses a non-existent home directory, but
you can change that. Quite a few packages have (setenv "HOME" "/tmp")
for the tests. Adding that looks like:

    (arguments
     (list
      #:phases
      #~(modify-phases %standard-phases
          (add-before 'check 'fix-home-directory
            (lambda _
              ;; Tests fail with: Fontconfig error: No writable cache
              ;; directories
              (setenv "HOME" "/tmp"))))))

If you do that though, the tests still fail, seems like there's a
missing font?

starting phase `check'
ninja: Entering directory `/tmp/guix-build-synthpod-0.1.6505.drv-0/build'
ninja: no work to do.
1/9 d2tk / Test core            OK              0.09s
2/9 d2tk / Test base            OK              0.48s
3/9 d2tk / FiraSans-Bold.ttf    FAIL            0.02s   exit status 1
>>> MALLOC_PERTURB_=67 /tmp/guix-build-synthpod-0.1.6505.drv-0/source/subprojects/d2tk/check_for_font FiraSans-Bold.ttf

4/9 d2tk / FiraCode-Light.ttf   FAIL            0.03s   exit status 1
>>> MALLOC_PERTURB_=109 /tmp/guix-build-synthpod-0.1.6505.drv-0/source/subprojects/d2tk/check_for_font FiraCode-Light.tt

5/9 d2tk / FiraCode-Regular.ttf FAIL            0.03s   exit status 1
>>> MALLOC_PERTURB_=46 /tmp/guix-build-synthpod-0.1.6505.drv-0/source/subprojects/d2tk/check_for_font FiraCode-Regular.ttf

6/9 d2tk / FiraCode-Medium.ttf  FAIL            0.02s   exit status 1
>>> MALLOC_PERTURB_=41 /tmp/guix-build-synthpod-0.1.6505.drv-0/source/subprojects/d2tk/check_for_font FiraCode-Medium.ttf

7/9 d2tk / FiraCode-Bold.ttf    FAIL            0.02s   exit status 1
>>> MALLOC_PERTURB_=10 /tmp/guix-build-synthpod-0.1.6505.drv-0/source/subprojects/d2tk/check_for_font FiraCode-Bold.ttf

8/9 synthpod / LV2 validate     OK              0.07s
9/9 synthpod / LV2 validate     OK              0.07s

Summary of Failures:

3/9 d2tk / FiraSans-Bold.ttf    FAIL            0.02s   exit status 1
4/9 d2tk / FiraCode-Light.ttf   FAIL            0.03s   exit status 1
5/9 d2tk / FiraCode-Regular.ttf FAIL            0.03s   exit status 1
6/9 d2tk / FiraCode-Medium.ttf  FAIL            0.02s   exit status 1
7/9 d2tk / FiraCode-Bold.ttf    FAIL            0.02s   exit status 1


Ok:                 4   
Expected Fail:      0   
Fail:               5   
Unexpected Pass:    0   
Skipped:            0   
Timeout:            0   

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

  reply	other threads:[~2022-10-25  9:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-21 11:19 [bug#58681] [PATCH] gnu: Add synthpod Sughosha via Guix-patches via
2022-10-25  9:25 ` Christopher Baines [this message]
2023-01-06 14:27 ` [bug#58681] [PATCH v2] " Sughosha via Guix-patches via
2023-01-22 22:58 ` Ricardo Wurmus
2023-01-23 21:10   ` Sughosha via Guix-patches via
2023-01-24 23:24     ` bug#58681: " Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wn8ofe0p.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=58681@debbugs.gnu.org \
    --cc=Sughosha@proton.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).