From: Ricardo Wurmus <rekado@elephly.net>
To: 58681@debbugs.gnu.org
Cc: Sughosha <Sughosha@proton.me>
Subject: [bug#58681] [PATCH v2] gnu: Add synthpod.
Date: Sun, 22 Jan 2023 23:58:25 +0100 [thread overview]
Message-ID: <87bkmqf9z4.fsf@elephly.net> (raw)
In-Reply-To: <D0Yk1G0jYgxZkFGBF0gB4894QtivLuoVpdRCHLbVBwhjvldD8HHWjjO3CZwH2rCUU_9o_Gh0hpA9brEvK2GQx-A_f2MlhTbTGWXjIK7tW-s=@proton.me>
[-- Attachment #1: Type: text/plain, Size: 28 bytes --]
Hi,
I made these changes:
[-- Attachment #2: synthpod.diff --]
[-- Type: text/x-patch, Size: 3687 bytes --]
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index ca058638f2..f2f5289dba 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -44,7 +44,7 @@
;;; Copyright © 2021 Simon Streit <simon@netpanic.org>
;;; Copyright © 2021 Xinglu Chen <public@yoctocell.xyz>
;;; Copyright © 2021 Thomas Albers Raviola <thomas@thomaslabs.org>
-;;; Copyright © 2022 Sughosha <sughosha@disroot.org>
+;;; Copyright © 2022, 2023 Sughosha <sughosha@disroot.org>
;;; Copyright © 2022 Remco van 't Veer <remco@remworks.net>
;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
;;; Copyright © 2022 Wamm K. D. <jaft.r@outlook.com>
@@ -3566,44 +3566,53 @@ (define-public synthpod
(source (origin
(method git-fetch)
(uri (git-reference
- (url "https://git.open-music-kontrollers.ch/lv2/synthpod")
- ;; Version is not tagged but mentioned in VERSION file.
- (commit "6e84a075ea8fea95094dcbc2b30f968717a81960")))
+ (url "https://git.open-music-kontrollers.ch/lv2/synthpod")
+ ;; Version is not tagged but mentioned in VERSION file.
+ (commit "6e84a075ea8fea95094dcbc2b30f968717a81960")))
(file-name (git-file-name name version))
(sha256
- (base32
- "1chazkdxjgjzfxqmlk4ywhilkj9l3bybd9xghjg9r67df2diqhbs"))))
+ (base32
+ "1chazkdxjgjzfxqmlk4ywhilkj9l3bybd9xghjg9r67df2diqhbs"))))
(build-system meson-build-system)
(arguments
(list
#:phases
#~(modify-phases %standard-phases
- (add-before 'check 'fix-home-directory
+ (add-after 'unpack 'patch-references
+ (lambda* (#:key inputs #:allow-other-keys)
+ (substitute* '("bin/synthpod_ui"
+ "bin/synthpod_d2tk")
+ (("lv2info") (search-input-file inputs "/bin/lv2info"))
+ ((" synthpod_sandbox_x11")
+ (string-append " " #$output "/bin/synthpod_sandbox_x11")))))
+ (add-before 'check 'set-home-directory
(lambda _
;; Tests fail with: Fontconfig error: No writable cache
;; directories
(setenv "HOME" "/tmp"))))))
- (propagated-inputs (list lilv)) ;required for lv2info
- (inputs (list alsa-lib
- cairo
- eudev
- freetype
- font-fira-code
- font-fira-sans
- fontconfig
- glew
- glu
- jack-1
- libevdev
- libinput
- libvterm
- lv2
- pixman
- sratom
- xcb-util
- xcb-util-wm
- xcb-util-xrm
- zita-alsa-pcmi))
+ (inputs
+ (list alsa-lib
+ cairo
+ eudev
+ freetype
+ font-fira-code
+ font-fira-sans
+ fontconfig
+ glew
+ glu
+ grep
+ jack-2
+ libevdev
+ libinput
+ libvterm
+ lilv ;for lv2info
+ lv2
+ pixman
+ sratom
+ xcb-util
+ xcb-util-wm
+ xcb-util-xrm
+ zita-alsa-pcmi))
(native-inputs (list pkg-config))
(home-page "https://open-music-kontrollers.ch/lv2/synthpod/")
(synopsis "Nonlinear LV2 plugin container")
[-- Attachment #3: Type: text/plain, Size: 1653 bytes --]
It avoids propagation of lilv and patches synthpod_ui to look for other
executables in a known location.
We should probably also wrap the scripts to set PATH to where “grep”,
“coreutils”, “sed”, and “gawk” are found, but I wasn’t able to add (gnu
packages gawk) to the imports of (gnu packages music).
Unfortunately, the program crashes because it can’t find the LV2 files
for Synthpod itself:
--8<---------------cut here---------------start------------->8---
$ /gnu/store/pp3rysfcssf3kigh01mrz7jc16dgp51p-synthpod-0.1.6507/bin/synthpod_ui
error: failed to open file /home/rekado/.lv2/Synthpod_default.preset.lv2/manifest.ttl (No such file or directory)
lilv_world_load_file(): error: Error loading file `file:///home/rekado/.lv2/Synthpod_default.preset.lv2/manifest.ttl'
lilv_world_load_bundle(): error: Error reading file:///home/rekado/.lv2/Synthpod_default.preset.lv2/manifest.ttl
Plugin not found.
Synthpod 0.1.6507
Copyright (c) 2015-2016 Hanspeter Portner (dev@open-music-kontrollers.ch)
Released under Artistic License 2.0 by Open Music Kontrollers
error: failed to open file /home/rekado/dev/gx/branches/master/manifest.ttl (No such file or directory)
lilv_world_load_file(): error: Error loading file `file:///home/rekado/dev/gx/branches/master/manifest.ttl'
lilv_world_load_bundle(): error: Error reading file:///home/rekado/dev/gx/branches/master/manifest.ttl
lilv_plugins_get_by_uri failed
Segmentation fault
--8<---------------cut here---------------end--------------->8---
These probably should be looked up in $out/lib/synthpod/lv2 instead of
searching the LV2 path.
--
Ricardo
next prev parent reply other threads:[~2023-01-22 23:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 11:19 [bug#58681] [PATCH] gnu: Add synthpod Sughosha via Guix-patches via
2022-10-25 9:25 ` Christopher Baines
2023-01-06 14:27 ` [bug#58681] [PATCH v2] " Sughosha via Guix-patches via
2023-01-22 22:58 ` Ricardo Wurmus [this message]
2023-01-23 21:10 ` Sughosha via Guix-patches via
2023-01-24 23:24 ` bug#58681: " Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkmqf9z4.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=58681@debbugs.gnu.org \
--cc=Sughosha@proton.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).